[GitHub] [zeppelin] jongyoul commented on a change in pull request #4332: [ZEPPELIN-5668] Support statement set in flink

2022-03-28 Thread GitBox


jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836553204



##
File path: flink/flink1.14-shims/pom.xml
##
@@ -171,7 +171,7 @@
 -unchecked
 -deprecation
 -feature
--target:jvm-1.8
+

Review comment:
   ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] jongyoul commented on a change in pull request #4332: [ZEPPELIN-5668] Support statement set in flink

2022-03-28 Thread GitBox


jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836553028



##
File path: flink/flink1.13-shims/pom.xml
##
@@ -178,7 +178,7 @@
 -unchecked
 -deprecation
 -feature
--target:jvm-1.8
+

Review comment:
   ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] jongyoul commented on a change in pull request #4332: [ZEPPELIN-5668] Support statement set in flink

2022-03-28 Thread GitBox


jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836552806



##
File path: flink/flink1.12-shims/pom.xml
##
@@ -176,7 +176,7 @@
 -unchecked
 -deprecation
 -feature
--target:jvm-1.8
+

Review comment:
   ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] jongyoul commented on a change in pull request #4332: [ZEPPELIN-5668] Support statement set in flink

2022-03-28 Thread GitBox


jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836541197



##
File path: flink/flink1.14-shims/pom.xml
##
@@ -171,7 +171,7 @@
 -unchecked
 -deprecation
 -feature
--target:jvm-1.8
+

Review comment:
   Same here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] jongyoul commented on a change in pull request #4332: [ZEPPELIN-5668] Support statement set in flink

2022-03-28 Thread GitBox


jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836540877



##
File path: flink/flink1.13-shims/pom.xml
##
@@ -178,7 +178,7 @@
 -unchecked
 -deprecation
 -feature
--target:jvm-1.8
+

Review comment:
   Same here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] jongyoul commented on a change in pull request #4332: [ZEPPELIN-5668] Support statement set in flink

2022-03-28 Thread GitBox


jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836540738



##
File path: flink/flink1.12-shims/pom.xml
##
@@ -176,7 +176,7 @@
 -unchecked
 -deprecation
 -feature
--target:jvm-1.8
+

Review comment:
   How about removing this line?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org