[GitHub] [zeppelin] zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin
Notebooks in vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#discussion_r328980138
##
File path: zeppelin-web-vue/src/services/api.js
##
@@ -0,0 +1,33 @@
+export default {
+ getWebsocketUrl () {
+let wsProtocol = location.protocol === 'https:' ? 'wss:' : 'ws:'
+return wsProtocol + '//' + location.hostname + ':' + this.getWSPort() +
'/ws'
+ },
+
+ getWSPort () {
+if (location.hostname.includes('qubole')) {
+ if (location.protocol === 'https:') {
+return 443
+ }
+}
+return this.getPort()
+ },
+
+ getPort () {
+let port = Number(location.port - 1)
+if (!port) {
+ port = 80
+ if (location.protocol === 'https:') {
+port = 443
+ }
+}
+if (port === || port === 9000) {
Review comment:
Where does `` and `9000` come from ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin
Notebooks in vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#discussion_r328974785
##
File path: zeppelin-web-vue/src/components/Notebook/Create.vue
##
@@ -0,0 +1,136 @@
+
+
+
+
+Cancel
+
+ {{ this.actionLabel }}
+
+
+
+
+
+
+
+
+
+
+
+ {{interpreter.id}}
+
+
+
+
+
+
+
+
+
+
+
+
+
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin
Notebooks in vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#discussion_r328974785
##
File path: zeppelin-web-vue/src/components/Notebook/Create.vue
##
@@ -0,0 +1,136 @@
+
+
+
+
+Cancel
+
+ {{ this.actionLabel }}
+
+
+
+
+
+
+
+
+
+
+
+ {{interpreter.id}}
+
+
+
+
+
+
+
+
+
+
+
+
+
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#discussion_r328973250 ## File path: zeppelin-web-vue/public/index.html ## @@ -0,0 +1,17 @@ + + + + + + + +Zeppelin Studio Review comment: Please rename it still to `Zeppelin Notebook`, changing product name is beyond the scope of this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
