[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1393 Thanks @Leemoonsoo for reviewing this! Could you please merge this? - Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1393 Thanks @kavinkumarks for the contribution. This changes not only resolving race condition described in ZEPPELIN-1142 but also changes user experience. i.e. Before, owner is not defined when creating note. After, owner is set to current user when creating note. (when authentication is enabled) Especially with code changes such as https://github.com/apache/zeppelin/pull/1330, user will experience bigger behavior changes. But i think having current user as a owner when creating note is natural behavior that most people can think, even though it brings some UX changes. LGTM and merge if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1393 Could someone else have a look at this and merge if everything is okay? Thanks, Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1393 @kavinkumarks i believe some of the committers or pmcs will take a look into this pr before merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1393 Thanks @khalidhuseynov ! Can we get this merged? -Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1393 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1393 The CI build is green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1393 Fixed the build test failure and the CI build is in progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1393 Found an build test failure, working on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1393 Reopening to trigger the CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1393 @khalidhuseynov thanks for the review! I have replied to the comments and the CI build is in progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1393 @kavinkumarks thanks for improvement and it makes sense indeed to assign owner when creating note. just need to address above minor comments as well as restart CI, some profiles are failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
