[GitHub] zeppelin issue #1470: ZEPPELIN-1423 - Allow users to specify pre/post-execut...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1470 Apologies for late response. Changes LGTM. Last CI failure is irrelevant to this change. Merge if there're no more discussion. Thanks @agoodm for making step forward to ZEPPELIN-1344! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1470: ZEPPELIN-1423 - Allow users to specify pre/post-execut...
Github user agoodm commented on the issue: https://github.com/apache/zeppelin/pull/1470 @Leemoonsoo I have addressed your second comment, let me know if this looks good to merge into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1470: ZEPPELIN-1423 - Allow users to specify pre/post-execut...
Github user agoodm commented on the issue: https://github.com/apache/zeppelin/pull/1470 @Leemoonsoo Thanks for the review, I have provided some responses. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1470: ZEPPELIN-1423 - Allow users to specify pre/post-execut...
Github user agoodm commented on the issue: https://github.com/apache/zeppelin/pull/1470 @Leemoonsoo please review, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---