[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-04 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1583
  
Since #1595 will fix the issue let's test it out quickly, and merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue:

https://github.com/apache/zeppelin/pull/1583
  
#1595 will fix this issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1583
  
I thought Zeppelin does not read conf/shiro.ini.template, but it actually 
does.
Therefore now default behavior is changed to require authentication and i 
think it's not a minor change.

Should i revert it? or https://github.com/apache/zeppelin/pull/1595 will 
bring default behavior back? @anthonycorbacho @minahlee @prabhjyotsingh 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-03 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue:

https://github.com/apache/zeppelin/pull/1583
  
Good catch!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-03 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue:

https://github.com/apache/zeppelin/pull/1583
  
merging if no more discussion ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-03 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1583
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1583
  
Nice! LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1583
  
Yeah it makes sense. LGTM 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-02 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1583
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---