[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1598 @jaspinderdineout Hi :) Zeppelin doesn't support es 5.0 currently as i know. I will close this PR. This issue can be easily handled after #1902. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1598 \cc @1ambda --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0
Github user jaspinderdineout commented on the issue: https://github.com/apache/zeppelin/pull/1598 Is it live? Does zeppelin support elasricsearch 5.0 ??? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1598
@bbonnin Thanks for the quick review :)
1. Duplicated code in `executeDeleteQuery` is due to incompatible API
between 2.x and 5.x
```
// 2.x
public boolean isFound() { ... }
// 5.x
RestStatus.NOT_FOUND != response.status())
```
But we can extract duplicated validation logic to the base class as you
mentioned.
2. @bzz, @bbonnin Regarding to update docs,
Are there more files I should update? I am asking because
- new maven profile is added `elasticsearch-2` (activated by default),
`elasticsearch-5`
- `elasticsearch-5` profile requires java 8 +
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1598 Great work @1ambda ! Do you know if there are any ETA for Elasticsearch 5.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1598 Blocked until 5.1 release due to too many undocumented breaking changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1598 Ref - https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking_50_java_api_changes.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
