[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user krskoondra commented on the issue: https://github.com/apache/zeppelin/pull/1688 @Leemoonsoo my id is krskoondra. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 @krskoondra Could you let me know you apache JIRA id? so i can assign you in this https://issues.apache.org/jira/browse/ZEPPELIN-1637 issue and resolve. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 @krskoondra Thanks for the nice feature. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 CI test failed with ``` Results : Tests in error: ParagraphActionsIT.testRemoveButton:155->AbstractZeppelinIT.clickAndWait:131 » ElementNotVisible ParagraphActionsIT.testMoveUpAndDown:200->AbstractZeppelinIT.clickAndWait:131 » ElementNotVisible ParagraphActionsIT.testCreateNewButton:85 » ElementNotVisible Element is not c... ZeppelinIT.testAngularDisplay:157->AbstractZeppelinIT.waitForText:84 » StaleElementReference Tests run: 18, Failures: 0, Errors: 4, Skipped: 0 ``` screenshot from ci server ![image](https://cloud.githubusercontent.com/assets/1540981/20824096/7f486f60-b80e-11e6-9e35-64985df71bb1.png) I don't think this PR caused the error but to make sure, could you trigger CI build again? You can add commit or close/open this pullrequest to trigger CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 If i assume your remote name for Zeppelin repository is `apache-github` (you can check it by running `git remote -v`), First, fetch Zeppelin repo (to get latest master) with `git fetch apache-github`, and then rebase or merge the master branch to your branch `git rebase apache-github/master` or `git merge apache-github/master`. Then git will ask you resolve conflict. After resolve all the conflicts you can push the new commit in this branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user krskoondra commented on the issue: https://github.com/apache/zeppelin/pull/1688 Someone help me. How can I resolve "This branch has conflicts that must be resolved"? I'm beginner with opensorce and github. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 Thanks @krskoondra for the contribution. LGTM. merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user epahomov commented on the issue: https://github.com/apache/zeppelin/pull/1688 Yeaaa, I love it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user krskoondra commented on the issue: https://github.com/apache/zeppelin/pull/1688 OK, @Leemoonsoo, the button is now in the dropdown menu of the paragraph and new keyboard shortcut ctrl+shift+c is added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1688 Thanks for updatding description! Agree with @Leemoonsoo. And FYI, you can refer #1686 for assigning keyboard shortcut :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 Top right corner of each paragraph was pretty crowded in early days of Zeppelin. Run, Move up, Move down, Delete, Show title, Show codes, Hides output, and so on. Because it was too crowded, we decided to move most of them under dropdown menu of the paragraph. Shell we move this button into dropdown menu and assign keyboard short cut instead? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1688 @krskoondra Thanks for your contribution. If there are UI changes, some screenshot images can help other ppl to quickly look into this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---