[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1692 LGTM and merge to master if there're no more discussions. Great work @cloverhearts ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1692  i was resolved UI problem. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1692 After checking, the automatic save will actually work. However, it can not be expressed only on the UI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1692 Tested and LGTM. Thanks @cloverhearts for the fix! Could you resolve the conflict? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1692 Cool! LGTM ð Korean Zeppelin community will love this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1692 ace editor 1.2.6 upgrade done. resolved korean typing issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1692  Fix and upgrade done. please, review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1692 @cloverhearts Nice! Hope the new version will be released soon :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1692 Thank you very much, @tae-jun --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1692 There is an input problem other than English, such as Japanese and Korean. To solve this problem, Zeppelin needs to upgrade the Ace editor. We have responded to the latest ace editor first. Actually the version for troubleshooting is currently awaiting release from the ace community. This PR is completed when a new version is released from the ace community. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
