[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1736 @soralee you're right. I checked again and it looks good to me. Thanks for the improvement and merge if there're no further comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 Sorry, I've missed your review @Leemoonsoo If your note has only one paragraph and you checked that menu of paragraph, it normally works like your screenshot. Because that paragraph doesn't need some function like `Move up` and `Move down` and `Remove`. If you want to see all item, could you check middle paragraph menu after making three paragraph? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1736 Tested again. And still not every items are displayed  @soralee could you check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 @Leemoonsoo I fixed the problem regarding not aligned text. Could you test and check again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 Sure! Let me check and test again :smiley: Thanks for test @Leemoonsoo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1736 This is screenshot i got from this branch.  I'm not sure why some items are missing and text are not aligned. @soralee Could you check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 Ping Ping ! Ci is green. It's time to ready to review this PR :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 I updated description of PR as like below. - add shortcut key to tooltip (`cancel to run paragraph`, `toggle editor`, `toggle output`) - add shortcut key to `Link this paragraph` in paragraph menu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 Regarding `Link this paragraph `shortcut key, I just created this issue. (#1736) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 @AhyoungRyu I appreciate to your information! I think I already fixed ParagraphActionsIT.java file. But, each time I tested the CI, the build operation failed differently. So I just wondered that. Let me do the rebase and test again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1736 @soralee Regarding `ParagraphActionsIT.java` change, IMO it would be better to be handled by another PR so that we can only focus on the scope of this patch. There are already many issues related `ParagraphActionsIT.java` as **Flaky Test** category(see [here](https://issues.apache.org/jira/browse/ZEPPELIN-1064?jql=project%20%3D%20ZEPPELIN%20AND%20text%20~%20%22ParagraphActionsIT.java%22)). If [this change that you made](https://github.com/apache/zeppelin/pull/1736/files#diff-48409cf8ca5ddb1aea1a62ada3cd091d) can fix the problem then we can merge it first and then you can rebase based on the latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 @astroshim Thanks for suggestion. The shortcut key of `Run this paragraph` is being presented by tooltip already.  BTW, I agree the shortcut key of `Link this paragraph` seems to be necessary. I'll improve shortcut key and will fix CI in order to be green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1736 @soralee Thank you for contribution of useful function. but I am usually using the `Shift + Enter` to run paragraph, How can be presented this shortcut? and it seems necessary a shortcut for the `Link this paragraph`. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
