[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1982 LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1982 I'v just rebased to resolve conflict ## Newly added commits - Remove `local` values in helium package jsons: https://github.com/apache/zeppelin/pull/1982/commits/ce5f8c0c0f88de79bd9c4172a5d74066c9345a50 - DON't refresh `helium.json` when fetching spell config to reduce execution time: https://github.com/apache/zeppelin/pull/1982/commits/dbc4f10fd3ee556d5e38cb4f6e391eaf69a9 @Leemoonsoo Could you help review? Thanks again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1982 Shell we also remove `"version": "local"` from zeppelin-examples/zeppelin-example-spell-echo/zeppelin-example-spell-echo.json zeppelin-examples/zeppelin-example-spell-flowchart/zeppelin-example-spell-flowchart.json zeppelin-examples/zeppelin-example-spell-markdown/zeppelin-example-spell-markdown.json zeppelin-examples/zeppelin-example-spell-translator/zeppelin-example-spell-translator.json ? Otherthan that, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1982 just rebased to apply new CI system. ### Newly added commits - Close config panel after saving: https://github.com/apache/zeppelin/pull/1982/commits/008ae4a0e81dc5f3d8f9a8a8d8e5b53edb02c9f4 - Remove version field from helium package while cleaning related code: https://github.com/apache/zeppelin/pull/1982/commits/c3100a38b879d8d6d936f528f8f8078bff2623d4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1982 @1ambda oh i see :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1982 @Leemoonsoo cause I added config before to test :( https://github.com/1ambda/zeppelin-echo-spell/blob/master/package.json#L13-#L18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1982 > The published echo spell doesn't have repeat implementation since spell config feature is not merged. I'm little bit confused. Then how does spell page displays configuration if published echo spell does not have configuration? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1982 @Leemoonsoo Thanks for review. - Then we need to close the configuration panel after saving. I will update it. - You have to use echo spell provided by zeppelin (`examples/`). Published echo spell doesn't have repeat implementation since spell config feature is not merged. (https://github.com/1ambda/zeppelin-echo-spell/blob/master/index.js) - Regarding to version, I will check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1982 I tried last commit and when i click 'save' button in Helium package configuration, save button saves configuration but there're no visual indication of it. This confuses little bit.  And i can still see 'version' field. Is 'version' field in use somewhere? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1982 @Leemoonsoo I'v just updated this PR. - Using `artifact` as config - https://github.com/apache/zeppelin/pull/1982/commits/6e91b78880777ace0e780c746e376a8e0c88b520 - Disabling `config` button while fetching (see the screenshot below)  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1982 @AhyoungRyu I totally agree! Now we have basic things, thus we need docs for it. I will work it on https://issues.apache.org/jira/browse/ZEPPELIN-2070 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1982 Great! How about adding some guide docs? Even if SPELL can be improved in the future, I believe the docs can help not only users but also the other PR reviewers to understand what SPELL is, how we can use SPELL type of pkgs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
