[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2000 Merge into `gh-pages` if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2000 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2000 Looks nice :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2000 Hi~ @AhyoungRyu @1ambda I updated this as your comment! Thanks for that could you review again, please? :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2000 Thanks for review! @AhyoungRyu @1ambda I'll update this soon! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2000 Hi @soralee :) I would like to suggest using `'ngInject'l` instead of `$inject = ['$location'];` as like https://github.com/apache/zeppelin/pull/1994 > http://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2000 I found another typo in [contribution/zeppelinweb/goodPracticeGuide04.html](http://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide04.html). Could you fix this one as well? It should be `ng-bing` -> `ng-bind` :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2000 @AhyoungRyu @1ambda Could you review this, please whether I missed something or not? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
