[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2093 Thanks for pinging. LGTM and merge to master if no further discussions. Meanwhile, @andreaTP do you mind create a JIRA issue? So later, everyone can more easily track when this feature has beed added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2093 I believe this is ready to merge. Please let me know if I need to do anything more. cc. @Leemoonsoo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2093 added even the row in the configuration table, thanks a lot for your patience! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2093 @Leemoonsoo thanks a lot for the hints, this simplify a lot and even CI is happy. I already squashed commits since now this PR looks in a good shape, but feel free to ask/argue about anything else. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2093 @Leemoonsoo thanks a lot for your comments, I hope to have targeted all of them, not sure how it works here, I will squash commits at the end of the process if you agree. b.t.w. tests consistently fail at ```pySparkDepLoaderTest``` https://travis-ci.org/andreaTP/zeppelin/jobs/208145522#L2932 but don't know how to start debugging this, it immediately fail with reflection errors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2093 Thanks @andreaTP for the contribution. I left some comment. Please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2093 ok, I don't know exactly how to proceed on debugging this :-S, the problem is with dependency loading in python interpreter... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2093 Not sure how to debug the CI failure, https://travis-ci.org/andreaTP/zeppelin/jobs/207318026 help needed please :-) sorry I'm new in this codebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
