[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Remilito Thanks for great work! LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Leemoonsoo : updated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Leemoonsoo thanks for the feedback, I think we should keep only B. I'll update the PR in a couple of days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2099
@Remilito Thanks for explain.
Let's say `graph: {mode: {...}}` is api A, and `config: {results: [{graph:
mode: {...}}]}` is api B.
When user use api A with multiple results, it can be ambiguous that config
will be applied to which particular result. I think this should be defined and
documented. Also it'll be better documentation explain what is difference
between api A and api B.
Alternative is just supporting api B, which i think superset of api A.
@Remilito Which do you prefer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...
Github user Remilito commented on the issue:
https://github.com/apache/zeppelin/pull/2099
@Leemoonsoo : the most common usages would be to set visual paramaters,
i.e. graph options, paragraph width and paragraph title show, so the idea was
to provide a more direct way to configure those rather than having to provide
the whole config:{results:[{} to do so. Anyway, this is open to discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2099
Thanks @Remilito for the contribution!
Could you elaborate why do you support two different forms of message?
```
{
...
"graph": {
"mode": "pieChart"
}
}
```
and
```
{
...
"config": {
...
"results": [
{
"graph": {
"mode": "scatterChart",
"optionOpen": true
}
}
]
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
