[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2133 Thanks @soralee. merge to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2133 @Leemoonsoo Ready to merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2133 @Leemoonsoo Yeah, this CI problem is related in #2255 if merging #2255, I'll rebase this PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2133 Great improvement @soralee. Tested and LGTM. Merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2133 @Leemoonsoo I added label and default variable furthermore, I changed from radio to button like this.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2133 @Leemoonsoo Thanks for review! Right! Label would be better :+1: Let me update again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2133 @Leemoonsoo I updated description and code as that we talked about above comment. I didn't found how to be calculated based on actual width changed so, I updated manual button it can be used by user wants. Could you review again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
