[GitHub] zeppelin issue #2140: [HOTFIX][ZEPPELIN-2037][ZEPPELIN-1832] "Restart" butto...

2017-03-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2140
  
@jongyoul Great work.

I tested this PR and found some problem. We need some followup here.

 1. Can not use interpreter after restart in `Per User scoped mode`, 
After restart interpreter, user the same interpreter again, then get error

```
ERROR [2017-03-16 08:07:55,589] ({pool-2-thread-14} Job.java[run]:186) - 
Job failed
org.apache.zeppelin.interpreter.InterpreterException: 
org.apache.thrift.TApplicationException: Internal error processing interpret
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.interpret(RemoteInterpreter.java:361)
at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.interpret(LazyOpenInterpreter.java:92)
at org.apache.zeppelin.notebook.Paragraph.jobRun(Paragraph.java:407)
at org.apache.zeppelin.scheduler.Job.run(Job.java:181)
at 
org.apache.zeppelin.scheduler.RemoteScheduler$JobRunner.run(RemoteScheduler.java:329)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.thrift.TApplicationException: Internal error 
processing interpret
at 
org.apache.thrift.TApplicationException.read(TApplicationException.java:111)
at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:71)
at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.recv_interpret(RemoteInterpreterService.java:274)
at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.interpret(RemoteInterpreterService.java:258)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.interpret(RemoteInterpreter.java:333)
... 11 more
```
 2. Interpreter is closed, but process is not terminated in `Per User 
scoped mode`, 

Login with two different user in two browser.
Let's say each user uses the same interpreter, python.
Then there're one `RemoteInterpreterServer` process and two `python` 
process created.
Once both user restart interpreter, two `python` process are terminated.
However `RemoteInterpreterServer` process still remains even though 
reference count becomes 0.

 3. Per Note scoped mode
Restart button does not restart interpreter.

 4. Per User Isolated mode
Restart button in Interpreter binding page does not work
Restart button in interpreter setting page result the same problem 1) 2)

 5. Per Note Isolated mode
Restart button in interpreter binding page works as expected
But restart button in interpreter setting page does not restart 
interpreter. which expected restart all interpreters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2140: [HOTFIX][ZEPPELIN-2037][ZEPPELIN-1832] "Restart" butto...

2017-03-16 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2140
  
My travis seems to get network error. I'll merge it into master and 
branch-0.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2140: [HOTFIX][ZEPPELIN-2037][ZEPPELIN-1832] "Restart" butto...

2017-03-15 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2140
  
@cloverhearts Thanks for testing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2140: [HOTFIX][ZEPPELIN-2037][ZEPPELIN-1832] "Restart" butto...

2017-03-15 Thread cloverhearts
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2140
  
@jongyoul Tested.

Spark and Markdown and Misc interpreter (without shiro)
```
restart interpreter on web ui > restart feature well work.
zeppelin shutdown (daemon stop) --->  well working, I can't reproduce with 
zombie process. :)
```
Thank you for good fix :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---