[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder

2017-04-12 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2228
  
Tested and it's work well, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder

2017-04-11 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2228
  
Thanks @tinkoff-dwh for quick resolving!
Let me check again if CI become green.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder

2017-04-11 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2228
  
@tinkoff-dwh, Before testing, could you rebase for resolving conflicts, 
too? :slightly_smiling_face: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder

2017-04-11 Thread tae-jun
Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/2228
  
Cool feature! LGTM 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder

2017-04-10 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2228
  
Thanks for improvement @tinkoff-dwh!
Let me test and I'll give you feedback!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---