[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2229 Tested. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @AhyoungRyu @felixcheung thank you for the review, have made the suggested changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @AhyoungRyu, @felixcheung ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 Merging this to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2229 From my earlier comment, I'm interested in others thought on having very Hive specific logic in the generic JDBC interpreter? https://github.com/apache/zeppelin/pull/2229/files#r110512765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 Yes, I thought of few options but this was bit con --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @felixcheung any specific change that you are looking for? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2229 Perhaps generalize this to something non-Hive specific? Like a property for userStringToAppend? Add user to JDBC URL should be common place - seems like in this case we just like a way to change the name and value of the property to add on the JDBC URL. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 Sure, got it, have renamed it to "appendProxyUserToURL". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2229
actually, I wasn't referring to the function name at all. instead of having
this fairly hive specific, how about a function like this to take the user name
property name and value
```
// Untested!
private void appendProxyUserToURL(StringBuilder connectionUrl, String
user) {
if ("true".equalsIgnoreCase(property.getProperty("jdbc.url.set.user") {
Integer lastIndexOfUrl = connectionUrl.indexOf("?");
if (lastIndexOfUrl == -1) {
lastIndexOfUrl = connectionUrl.length();
}
if (user != null && !user.equals("anonymous") &&
property.getProperty("jdbc.url.user.property").length() > 1) {
// check not empty or whitespace instead
logger.info("Using jdbc user as :" + user);
connectionUrl.insert(lastIndexOfUrl, ";" +
property.getProperty("jdbc.url.user.property") + "=" + user + ";");
}
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @felixcheung Sure what you have recommended does make a lot of sense, have implemented what you have suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 CI is green; https://travis-ci.org/prabhjyotsingh/zeppelin/builds/225173700 https://travis-ci.org/prabhjyotsingh/zeppelin/builds/225214327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
> why is zeppelin.jdbc.auth.kerberos.proxy.enable removed?
My bad, while fixing the above issues, I thought this is redundant, but I
forgot about the case where KERBEROS is enabled and the user does not want to
use proxy behavior. Have reverted that change.
> also is there a way not to hardcode hive jdbc
[here](https://github.com/apache/zeppelin/pull/2229/files#diff-ecdae8ee9594a5c4b21a3c217a3f130cR365)
Hive doesn't work with
[this](https://github.com/apache/zeppelin/pull/2229/files#diff-ecdae8ee9594a5c4b21a3c217a3f130cR370)
(UserGroupInformation.createProxyUser), and since we allow user to configure
multiple JDBC sources using the same interpreter setting; there can be a case
where user has configured say Phoenix (requires
UserGroupInformation.createProxyUser to proxy user) and Hive (fails if
UserGroupInformation.createProxyUser is used), we could introduce new parameter
like `{profile}.kerberos.proxy.enable` but this will increase the documentation
part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @felixcheung have removed hard coded string "hive" as well. CI fails for; not relavent for this change. ``` Tests in error: ParagraphActionsIT.testClearOutputButton:335->AbstractZeppelinIT.clickAndWait:126 û ElementNotVisible ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @felixcheung ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @felixcheung Have handled your review comments. Let me know if I missed any. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 Thank you @felixcheung. Will merge this to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
