[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree

2017-04-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2234
  
LGTM and merge to master if no further discussions!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree

2017-04-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2234
  
Let me take a look and come back


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree

2017-04-18 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2234
  
@Leemoonsoo could you review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree

2017-04-17 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2234
  
ready to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree

2017-04-11 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2234
  
@tinkoff-dwh, Could you rebase for resolving conflicts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree

2017-04-08 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2234
  
Nice feature @tinkoff-dwh 
Tested and it works well. LGTM!


![image](https://cloud.githubusercontent.com/assets/8110458/24827699/158417ec-1c8a-11e7-85ba-969b404b7954.png)


![image](https://cloud.githubusercontent.com/assets/8110458/24827703/2a365416-1c8a-11e7-9568-cb06aadbf032.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---