[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2235 hmm, I can see your approach though I can also see changing CLASS_PATH makes sense in some cases (for example, a custom library to be loaded). Do you think there is way to accommodate that? also, is there a way this could be configurable to be backward compatible? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Github user cfries commented on the issue:
https://github.com/apache/zeppelin/pull/2235
Hi Felix.
I am not sure if I got your point. The user can change CLASSPATH and
zeppelin.sh will use that. Also, the user can change
${ZEPPELIN_CLASSPATH_OVERRIDES} and ${ZEPPELIN_INTP_CLASSPATH_OVERRIDES} to add
additional files to the class path without changing CLASSPATH. I assume my
change is backward compatible. It is just that the script does not change the
CLASSPATH variable. But since the script is not supposed to call another
script, this should be OK.
In my option the side effect that the zeppelin.sh is polluting CLASSPATH
with the value of ZEPPELIN_CLASSPATH, which is then exported to interpreter.sh
is a bug, because it does not allow to use a JAR in zeppelin server which
should NOT be used in zeppelin interpreter. With my modification this is
possible.
Again: w.r.t. backward compatibility: I would assume that no one should
rely on the bug and if he relied on it, he can fix it by setting
ZEPPELIN_INTP_CLASSPATH_OVERRIDES or ZEPPELIN_INTP_CLASSPATH.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Github user cfries commented on the issue: https://github.com/apache/zeppelin/pull/2235 Also: on OS X the zeppelin does not run if you export CLASSPATH. So I assume no body could rely on this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2235 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2235 great, I review again after rereading what you are saying and I think they make sense and starting ZEPPELIN_CLASSPATH with CLASSPATH should make in compatible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2235 merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2235 @cfries looks like this PR is now including other changes? Could you rebase? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Github user cfries commented on the issue: https://github.com/apache/zeppelin/pull/2235 @Leemoonsoo Ups. Sorry for that. Will fix asap... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2235 CI build passed. https://travis-ci.org/cfries/zeppelin/builds/224499519 Merge to master and branch-0.7 if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
