[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboa...

2017-04-13 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2248
  
@1ambda Thanks for review! 
Yeah, it's make sense. Let me update `command+L` and the document


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboa...

2017-04-13 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2248
  
@soralee Doesn't work for OSX users since the binding is `CMD + L` not 
`CTRL + L` in OSX.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboa...

2017-04-13 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2248
  
@soralee I think we need to add this change into 
https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboa...

2017-04-12 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2248
  
Awesome! It was really annoying. Let me test and comment soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---