[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2251 Thanks @tinkoff-dwh for useful feature! Tested this PR. In interpreter setting page, I can change type of property. ![interpreter_property_type](https://cloud.githubusercontent.com/assets/1540981/25067481/214bd2f8-2280-11e7-96d7-f9db1ef2043f.gif) But shouldn't type supposed to be immutable? And i think we can add more types like 'number', 'boolean', 'url'. Do you have any plan adding more types? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2251 Yes, probably better to make immutable. In the first stage there were no plans to add more although i can add boolean (checkbox) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2251 probably wouldn't be a good idea to change from password to plaintext? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2251 add ![n_add](https://cloud.githubusercontent.com/assets/25951039/25084422/c9f6aafe-2375-11e7-8952-36aee06d4637.png) edit ![n_edit](https://cloud.githubusercontent.com/assets/25951039/25084424/c9f7d064-2375-11e7-85ae-b936b1c2c770.png) view ![n_view](https://cloud.githubusercontent.com/assets/25951039/25084423/c9f735e6-2375-11e7-9a2d-27818781a32a.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2251 One suggestion. What about calling them as 'widget' or something instead of 'type'? cause we might add actual type like 'number', 'string',... as @leemoonsu mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2251 @1ambda widget is ok. About another widgets: angular-xeditable has no implementations for that (there are html5 inputs but old browsers not support html5) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2251 Is it compatible with previous interpreter setting without type ? Maybe use text by default if no type is specified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2251 @zjffdu not compatible (conf/notebook.json), another format of 'properties' (object instead of string) https://github.com/tinkoff-dwh/zeppelin/blob/dd5d6c809aeb2bdb72357a072954cf4a9c882487/docs/install/upgrade.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2251 edit ![edit](https://cloud.githubusercontent.com/assets/25951039/25130228/e2a28060-245a-11e7-895a-d7c1571f885f.png) view ![view](https://cloud.githubusercontent.com/assets/25951039/25130227/e2a10906-245a-11e7-9ea3-0bd070219f42.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2251 @tinkoff-dwh Since conflicts are about lint errors, you can simply rebase by 1. keeping your change and run `rebase --continue` 2. then, execute `eslint src --fix` in `zeppelin-web` dir. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---