[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Hi @vipul1409 , Could you check 
https://github.com/apache/zeppelin/pull/2505?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[vipul1409]

Github user vipul1409 commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Hi Kun,

Raised this PR for the fix.
https://github.com/apache/zeppelin/pull/2392/files

Regards,

On Thu, Jun 1, 2017 at 9:11 PM, Kun  wrote:

> Hi @vipul1409 , This PR occurs an error like
>
> TypeError: Cannot read property 'create' of undefined
> at Object.link (http://localhost:9001/app.bundle.js:9662:52)
> at http://localhost:9001/bower_components/angular/angular.js:1240:18
> at invokeLinkFn 
(http://localhost:9001/bower_components/angular/angular.js:9814:9)
> at nodeLinkFn 
(http://localhost:9001/bower_components/angular/angular.js:9215:11)
> at compositeLinkFn 
(http://localhost:9001/bower_components/angular/angular.js:8510:13)
> at publicLinkFn 
(http://localhost:9001/bower_components/angular/angular.js:8390:30)
> at lazyCompilation 
(http://localhost:9001/bower_components/angular/angular.js:8728:25)
> at boundTranscludeFn 
(http://localhost:9001/bower_components/angular/angular.js:8527:16)
> at controllersBoundTransclude 
(http://localhost:9001/bower_components/angular/angular.js:9265:20)
> at ngRepeatAction 
(http://localhost:9001/bower_components/angular/angular.js:29607:15) 
>
> When I remove viewport-watch directive from notebook.html, there is no
> error.
> Could you fix it?
>
> [image: image]
> 

>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



-- 
Vipul Modi
Software Development Engineer 2
Flipkart Internet Pvt. Ltd.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Hi @vipul1409, This PR occurs an error like

```js
TypeError: Cannot read property 'create' of undefined
at Object.link (http://localhost:9001/app.bundle.js:9662:52)
at http://localhost:9001/bower_components/angular/angular.js:1240:18
at invokeLinkFn 
(http://localhost:9001/bower_components/angular/angular.js:9814:9)
at nodeLinkFn 
(http://localhost:9001/bower_components/angular/angular.js:9215:11)
at compositeLinkFn 
(http://localhost:9001/bower_components/angular/angular.js:8510:13)
at publicLinkFn 
(http://localhost:9001/bower_components/angular/angular.js:8390:30)
at lazyCompilation 
(http://localhost:9001/bower_components/angular/angular.js:8728:25)
at boundTranscludeFn 
(http://localhost:9001/bower_components/angular/angular.js:8527:16)
at controllersBoundTransclude 
(http://localhost:9001/bower_components/angular/angular.js:9265:20)
at ngRepeatAction 
(http://localhost:9001/bower_components/angular/angular.js:29607:15) 
```

When I remove `viewport-watch` directive from `notebook.html`, there is no 
error.
Could you fix it?



![image](https://cloud.githubusercontent.com/assets/4968473/26710441/d7940e48-4794-11e7-9b1f-d16462acc49e.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Thanks @vipul1409 for great contribution.
Thanks @1ambda for the review.

Merge to master if no further discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Tested and works well (both in frontend, backend angular APIs).

LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[vipul1409]

Github user vipul1409 commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Fixed all the issues and the tests have also passed. Please let me know if 
any more details are needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Your travis job failed at 

```
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 125.713 sec 
- in org.apache.zeppelin.integration.AuthenticationIT

Results :

Tests in error: 
  InterpreterIT.testShowDescriptionOnInterpreterCreate:69 » 
ElementNotVisible El...

Tests run: 23, Failures: 0, Errors: 1, Skipped: 0
```

- 
https://s3.amazonaws.com/archive.travis-ci.org/jobs/233893650/log.txt?X-Amz-Expires=30=20170519T140437Z=AWS4-HMAC-SHA256=AKIAJRYRXRSVGNKPKO5A/20170519/us-east-1/s3/aws4_request=host=528cbb815c291c20ab8f4a2418e762fee0d63d63af8cbf652a1262ce8dd2ef9a


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
You can close and reopen this PR to trigger jenkins again (not travis). 

I will test and comment soon. Thanks for update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[vipul1409]

Github user vipul1409 commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Sorry for delayed response.
Rerun of failed job passed. I have also addressed all the PR comments.
Let me know if anything more is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[vipul1409]

Github user vipul1409 commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Even latest master is breaking with exactly same error. I am not able to 
figure out the issue. Any help or suggestions will be great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[vipul1409]

Github user vipul1409 commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Addressed review comments and moved the dependency to npm. One jenkins job 
is failing but looks unrelated to my changes. I also see build is marked as 
failed in master, just double checking if master build is also broken.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[vipul1409]

Github user vipul1409 commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
I checked Jenkins Job. The sub job failing is 
https://travis-ci.org/vipul1409/zeppelin/jobs/230634157 It is failing because 
of some git access issues. Any suggestions on what could be the issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[vipul1409]

Github user vipul1409 commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Any suggestions on why jenkins job is failing? On checking in jenkins 
console output I don't see any smaller job failing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Oops. autocompletion didn't work. Sorry for confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[vi]

Github user vi commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Probably meant "Thanks for the contribution @vipul1409"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2326
  
Thanks for the contribution @vi

1. It is required to update `bin_license/LICENSE` when you want to add a 
new library. 

- 
https://github.com/apache/zeppelin/blob/master/zeppelin-distribution/src/bin_license/LICENSE#L228

2. It is possible to load angular-viewport-watcher using commonjs (webpack) 
instead of bower? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---