[GitHub] zeppelin issue #2515: [ZEPPELIN-2825] - Fix Zeppelin to support any of the S...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2515 CI looks green https://travis-ci.org/VipinRathor/zeppelin/builds/260833075. Will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2515: [ZEPPELIN-2825] - Fix Zeppelin to support any of the S...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2515 Thanks @VipinRathor for the contribution. Looks good to me, but could you try restart failed CI jobs and see if it becomes green? https://travis-ci.org/VipinRathor/zeppelin/builds/260433020 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2515: [ZEPPELIN-2825] - Fix Zeppelin to support any of the S...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2515 LGTM! +1 for adding documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2515: [ZEPPELIN-2825] - Fix Zeppelin to support any of the S...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2515 I think it is better to allow user to provide custom `RolesAuthorizationFilter` for more general case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2515: [ZEPPELIN-2825] - Fix Zeppelin to support any of the S...
Github user VipinRathor commented on the issue: https://github.com/apache/zeppelin/pull/2515 @felixcheung @Leemoonsoo @prabhjyotsingh Please help with review and merge. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---