[GitHub] zeppelin issue #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2520 Will merge this if no more discussion. ---
[GitHub] zeppelin issue #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...
Github user ss77892 commented on the issue: https://github.com/apache/zeppelin/pull/2520 @felixcheung all the tests that doesn't reach maxCount may be considered as the test that calls resultSet.next() multiple time (if the default jdbc would be Phoenix they would produce this exception) and there is a test testSelectQueryMaxResult that tests that the limit has been reached. ---
[GitHub] zeppelin issue #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...
Github user ss77892 commented on the issue: https://github.com/apache/zeppelin/pull/2520 @felixcheung As I mentioned in the JIRA the default jdbc driver that is used in tests has different behavior ( allows to make call next() even if the result set is already at the end). Not sure how to develop a test in this case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2520 Tested on local (for hive and phoenix) works as expected. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
