[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 @zjffdu Thank you a lot :) ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2578 LGTM, just one concern about `PythonCondaInterpreterTest.java`. It is using mock which may not found potential bugs. I think we can do unit without mock. But anyway this could be done in a following up ticket. ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 If there are no comments anymore, I will merge to master on this pr. ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2578 LGTM. ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2578 @zjffdu I created one. Thanks. - https://issues.apache.org/jira/browse/ZEPPELIN-2923 ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2578 @1ambda This is due to IPythonInterpreter, could create a ticket ? I will fix it in another PR. ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2578 Checked that `conda list` works beautifully. But I am getting this ipython related message when activate a new env. Can we remove this message which is not related to conda at all.  ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 fixed test case and conda list feature ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 @1ambda okay :) ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2578 Tested locally and works well. @cloverhearts Can we fix `conda list` command as well? it will need exactly the same code with `conda install`. LGTM except for it. ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 @zjffdu Sure, Thank you :) ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2578 Thanks @cloverhearts , Is it possible to add unit test for `PythonCondaInterpreter` ? Regarding the CI failure, I know this failure and will fix it in another PR ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 The problem of CI is irrelevant to this pr. ``` Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.462 sec <<< FAILURE! - in org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest testStartStop(org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest) Time elapsed: 10.043 sec <<< FAILURE! java.lang.AssertionError: expected: but was: at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest.testStartStop(RemoteInterpreterServerTest.java:62) ``` ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 @1ambda @zjffdu @felixcheung Sorry. I divided the existing PR by the minimum function. Can you review this PR again? Thank you for your help :) ---
