[GitHub] zeppelin issue #2688: [Zeppelin-2571] & [Zeppelin-465] Run paragraphs: from ...

2017-11-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2688
  
Thanks @tinkoff-dwh. LGTM and merge to master if no further discussions.


---


[GitHub] zeppelin issue #2688: [Zeppelin-2571] & [Zeppelin-465] Run paragraphs: from ...

2017-11-29 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2688
  
@Leemoonsoo 
You're right. The description was not true. 
The description has been changed.


---


[GitHub] zeppelin issue #2688: [Zeppelin-2571] & [Zeppelin-465] Run paragraphs: from ...

2017-11-29 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2688
  
@Leemoonsoo
Now paragraph's focus and cursor position stay in the same position after 
launch.


---


[GitHub] zeppelin issue #2688: [Zeppelin-2571] & [Zeppelin-465] Run paragraphs: from ...

2017-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2688
  
Tested last commit and it works well. Looks good to me.

It's minor, if paragraph keeps focus after 'run all above' and 'run all 
below', that would be more convenient to use.


---


[GitHub] zeppelin issue #2688: [Zeppelin-2571] & [Zeppelin-465] Run paragraphs: from ...

2017-11-28 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2688
  
@Leemoonsoo 
Yes, I think it will be more convenient.
I made some changes.


---


[GitHub] zeppelin issue #2688: [Zeppelin-2571] & [Zeppelin-465] Run paragraphs: from ...

2017-11-27 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2688
  
I guess the Jupyter behavior sort of make senses to me...
It sounds like "Run All Above" means "runs everything from the top to right 
before this current paragraph", which can be useful for reruns.



---


[GitHub] zeppelin issue #2688: [Zeppelin-2571] & [Zeppelin-465] Run paragraphs: from ...

2017-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2688
  
Thanks @tinkoff-dwh for the contribution. The feature works as expected.

Jupyer has "Run All Above" and "Run All Below".

![image](https://user-images.githubusercontent.com/1540981/33295712-2d748d0a-d38c-11e7-8f66-7b966b382b90.png)

One interesting thing is, "Run All Above" exclude current cell (paragraph), 
"Run All Below" include the current cell (paragraph).

I think there's a reason why Jupyer designed two very related button 
behavior in slightly different way. @tinkoff-dwh What do you think? Do you 
think Jupyter's "Run All Above" behavior is useful?


---