[GitHub] zeppelin issue #2695: [ZEPPELIN-3089] Create user folders under Trash folder

2018-03-15 Thread prabhjyotsingh 
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2695
  
I have created a new PR https://github.com/apache/zeppelin/pull/2872. Let 
me know if that makes sense, I can close that if required. Have created new as 
this was stale for 3+ months.


---

[GitHub] zeppelin issue #2695: [ZEPPELIN-3089] Create user folders under Trash folder

2017-12-30 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2695
  
what's the next step then?


---

[GitHub] zeppelin issue #2695: [ZEPPELIN-3089] Create user folders under Trash folder

2017-12-11 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2695
  
Whether a user can find the notebook in trash or not is based on permission 
of the notebook, then If user 'B' has properly permission for the notebook 
deleted by user 'A', user 'B' can find the notebook in trash.
However, I find some issues in this PR. For example, user 'A' delete a 
notebook, then user 'B' restore the notebook from trash. In this PR, even if 
user 'B' has 'owner' permission for the notebook, cannot do that.


---

[GitHub] zeppelin issue #2695: [ZEPPELIN-3089] Create user folders under Trash folder

2017-12-07 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2695
  
this https://github.com/apache/zeppelin/pull/2695#issuecomment-349882841 is 
a good point...


---

[GitHub] zeppelin issue #2695: [ZEPPELIN-3089] Create user folders under Trash folder

2017-12-06 Thread tinkoff-dwh 
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2695
  
A note can be used by a group. 
If user 'A' deletes a note, then the note will be "hided" and it will be 
hard for user 'B' to find this note.

Our practice to have its own separate folder for each group and each user.


---

[GitHub] zeppelin issue #2695: [ZEPPELIN-3089] Create user folders under Trash folder

2017-12-05 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2695
  
Yes, the default is anonymous. 
Deleted files will be moved under  ~Trash/anonymous/ folder.


---