[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2700 LGTM, will merge if no more comments ---
[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user nighthawk6389 commented on the issue: https://github.com/apache/zeppelin/pull/2700 Would love to see this merged! ---
[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2700 It is awsome if there's such button. But I don't know how to make such button. BTW usually I would force push a dummy commit to trigger the build. And I believe we should also fix these flaky test which cause inconvenience for developers. ---
[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user mohamagdy commented on the issue: https://github.com/apache/zeppelin/pull/2700 @zjffdu all good. I closed and reopened the pull request. I would suggest making the process of rerunning Jenkins easier than closing and reopening the pull request. This also triggers Travis tests which take around 1.5 hours. Maybe adding a `build` button in Jenkins so that one can rerun the job? What do you think? ---
[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2700 ping @mohamagdy ---
[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2700 @mohamagdy could you check - there are a bunch of errors https://travis-ci.org/mohamagdy/zeppelin/builds/324495310 ---
[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2700 looks like Jenkins has lost the test run result - could you kick that off again? you can do that by closing and reopening this PR. ---
[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2700 and we should probably check why RAT doesn't pick up the missing ASF header for new files? ---
[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2700 Can you restart some failed job on https://travis-ci.org/mohamagdy/zeppelin/builds/317797015 ? ---
[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user mohamagdy commented on the issue: https://github.com/apache/zeppelin/pull/2700 @Leemoonsoo, thanks a lot for reviewing and testing the branch. I will fix the Jenkins job with the information you provided. Regarding the test files, the tests for the `GitNotebookRepo` was not working because those notebooks were missing from the `src` folder, so I added them. I ran the tests using Intellij. ---
[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration
Github user mohamagdy commented on the issue: https://github.com/apache/zeppelin/pull/2700 @felixcheung, the `GitHubNotebookRepo` inherits from `GitNotebookRepo` but the difference is, after the notebook is saved (and committed), the `GitHubNotebookRepo` updates (pushes the local commits) a remote GitHub repository (notebooks repository on GitHub) configured in the `zeppelin-site.xml`. Also, when `GitHubNotebookRepo` is configured as a storage, everytime the notebook is loaded, the latest changes is pulled from the remote GitHub repository. Does this make sense? ---
