[GitHub] zeppelin issue #3084: [zeppelin-3639] Add Ipython interpreter prerequisite c...

2018-07-30 Thread Tagar
Github user Tagar commented on the issue:

https://github.com/apache/zeppelin/pull/3084
  
that makes sense. thanks @khalidhuseynov 


---


[GitHub] zeppelin issue #3084: [zeppelin-3639] Add Ipython interpreter prerequisite c...

2018-07-30 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/3084
  
@Tagar thanks for suggestion, but I think it's better not to include this 
check for tornado in this function since it's not really pre-requisite check. 
if we add it, then we need to keep track it, and restore back when the issue 
with tornado is fixed. 


---


[GitHub] zeppelin issue #3084: [zeppelin-3639] Add Ipython interpreter prerequisite c...

2018-07-19 Thread Tagar
Github user Tagar commented on the issue:

https://github.com/apache/zeppelin/pull/3084
  
Would be nice to check freeze output for tornado version.
tornado 5.x is broken for Zeppelin. 
https://issues.apache.org/jira/browse/ZEPPELIN-3505 


---


[GitHub] zeppelin issue #3084: [zeppelin-3639] Add Ipython interpreter prerequisite c...

2018-07-19 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3084
  
LGTM


---