[GitHub] zeppelin issue #3132: [ZEPPELIN-3701].Missing first several '0' and losing d...

2018-10-02 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3132
  
this should be in 0.9. as for release date plan, please ask on 
dev@zeppelin.apache.org


---


[GitHub] zeppelin issue #3132: [ZEPPELIN-3701].Missing first several '0' and losing d...

2018-10-01 Thread mmukherjee
Github user mmukherjee commented on the issue:

https://github.com/apache/zeppelin/pull/3132
  
Thanks folks for helping with this. Can you please let me know by when 
would this fix be rolled out as as tagged release? Is there a release roadmap I 
could refer to?


---


[GitHub] zeppelin issue #3132: [ZEPPELIN-3701].Missing first several '0' and losing d...

2018-08-14 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3132
  
merging if no more comment


---


[GitHub] zeppelin issue #3132: [ZEPPELIN-3701].Missing first several '0' and losing d...

2018-08-13 Thread Deegue
Github user Deegue commented on the issue:

https://github.com/apache/zeppelin/pull/3132
  
@felixcheung CI passed : 
https://travis-ci.org/Deegue/zeppelin/builds/415389747


---


[GitHub] zeppelin issue #3132: [ZEPPELIN-3701].Missing first several '0' and losing d...

2018-08-13 Thread Deegue
Github user Deegue commented on the issue:

https://github.com/apache/zeppelin/pull/3132
  
That's the problem I haven't met . The check added , but I have trouble in 
CI tests .
I'd appreciate it if you could tell me how to resolve the problem : CI : 
https://travis-ci.org/Deegue/zeppelin/builds/415278918


---


[GitHub] zeppelin issue #3132: [ZEPPELIN-3701].Missing first several '0' and losing d...

2018-08-13 Thread Savalek
Github user Savalek commented on the issue:

https://github.com/apache/zeppelin/pull/3132
  
I mean, it would be nice to add a check `if col[0] === '+'` to ` if 
(!(col[0] === '0' || col.length > float64MaxDigits)) {`


---


[GitHub] zeppelin issue #3132: [ZEPPELIN-3701].Missing first several '0' and losing d...

2018-08-13 Thread Deegue
Github user Deegue commented on the issue:

https://github.com/apache/zeppelin/pull/3132
  
@Savalek It won't be affected in this case , it will keep '00987...' and 
'...'(length>16) as String .
Other cases are still the same as before.


---


[GitHub] zeppelin issue #3132: [ZEPPELIN-3701].Missing first several '0' and losing d...

2018-08-13 Thread Savalek
Github user Savalek commented on the issue:

https://github.com/apache/zeppelin/pull/3132
  
I would like to still display the mobile phone numbers correctly 
`+7918...`. (with sing `+`) 


---