[GitHub] zeppelin pull request #1559: [ZEPPELIN-1461] Doesn't display "description" v...

2016-11-01 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1559


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1559: [ZEPPELIN-1461] Doesn't display "description" v...

2016-10-24 Thread minahlee 
GitHub user minahlee opened a pull request:

https://github.com/apache/zeppelin/pull/1559

[ZEPPELIN-1461] Doesn't display "description" value in interpreter creation 
page

### What is this PR for?
#1522 tried to fix same issue by making as least change as possible, but 
fixing it in backend side looks like more proper approach as 
https://github.com/apache/zeppelin/pull/1522#issuecomment-255109922.
This PR fixes ZEPPELIN-1461 by changing `properties` field of 
`InterpreterSetting` class from `Properties` -> `Object`.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-1461](https://issues.apache.org/jira/browse/ZEPPELIN-1461)

### Screenshots (if appropriate)
Before
![screen shot 2016-10-24 at 8 42 02 
pm](https://cloud.githubusercontent.com/assets/8503346/19644395/5d20a864-9a2a-11e6-806a-8a44e44a108a.png)

After
![screen shot 2016-10-24 at 8 37 17 
pm](https://cloud.githubusercontent.com/assets/8503346/19644281/d72be1ce-9a29-11e6-9b67-6d5de263b0de.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1461

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1559.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1559


commit 9c345b7210f9e97a857f68c912a7a6de37301343
Author: Mina Lee 
Date:   2016-10-24T07:35:44Z

Show description when create new interpreter

commit 4d1467d337247773edf4a125729b22959acefa3e
Author: Mina Lee 
Date:   2016-10-24T08:32:19Z

Fix order of properties in ui and java code style

commit c8cec759dcbcf47cffd9c27a0df2ab3a670d950e
Author: Mina Lee 
Date:   2016-10-24T08:32:56Z

Add selenium test for display description on interpreter create

commit 78bd93f9e15f4da0cebd364d0d9054009df5f33c
Author: Mina Lee 
Date:   2016-10-24T10:54:33Z

Add test checking InterpreterProperty class




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---