[GitHub] zeppelin pull request #1899: [HOTFIX] Does not working settings menu in zepp...

2017-01-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1899


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1899: [HOTFIX] Does not working settings menu in zepp...

2017-01-13 Thread cloverhearts
GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/1899

[HOTFIX] Does not working settings menu in zeppelin web graph ui

### What is this PR for?
Does not working settings menu in zeppelin web graph ui

### What type of PR is it?
Bug Fix

### How should this be tested?
1. toggle settings menu in zeppelin graph ui

### Screenshots (if appropriate)
 Before

![incorrect](https://cloud.githubusercontent.com/assets/10525473/21949815/1733ed6a-d9aa-11e6-92c8-8da98200cf43.gif)

 After

![correct](https://cloud.githubusercontent.com/assets/10525473/21949805/045c9a34-d9aa-11e6-86dc-445ce229f2a8.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin 
ZEEPELIN-SETTING-PROBLEM-WEB-UI

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1899.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1899


commit e3453b7fa41c75d10941273845a38b6a0f8f9609
Author: cloverhearts 
Date:   2017-01-14T00:02:55Z

invalid render life cycle for setting




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---