[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2174


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-24 Thread AhyoungRyu
GitHub user AhyoungRyu reopened a pull request:

https://github.com/apache/zeppelin/pull/2174

[ZEPELIN-2209] Add pagination to Helium menu

### What is this PR for?
Like I did in #2126, added pagination to Helium menu in Zeppelin. 
10 pkgs will be shown per 1 page. 

### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-2209](https://issues.apache.org/jira/browse/ZEPPELIN-2209)

### How should this be tested?
1. Replace temporarily 
[ZeppelinConfiguration.java#L46](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L46)
 with [this 
url](https://raw.githubusercontent.com/AhyoungRyu/spark-notebook-example/master/helium.json)

2. Build \w below command and restart Zeppelin server
```
 $ mvn clean package -DskipTests -pl 'zeppelin-zengine, zeppelin-server, 
zeppelin-interpreter'
```

3. Start web dev server under `ZEPPELIN_HOME/zeppelin-web` and browse 
`localhost:9000`
```
$ yarn run dev
```

4. Go to Helium menu -> Click `INTERPRETER` btn 
(Currently the other types of pkg are registered in online registry less 
than 10. That's why I request to change online registry URI in step 1)
5. Check the pagination works well or not

### Screenshots (if appropriate)

![record](https://cloud.githubusercontent.com/assets/10060731/24182469/58ec965e-0f05-11e7-8cf9-eca7d36c0106.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin add/paginationToHeliumMenu

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2174


commit 050b1dc8d32b2248f285c14e80d23061d2ae5419
Author: RyuAhyoung 
Date:   2017-03-22T04:35:41Z

Add pagination to Helium menu

commit e0bb52a53b0012cab9c866fc72e7aec7a6506cb4
Author: RyuAhyoung 
Date:   2017-03-23T06:50:57Z

Fix pkg orderBy published

commit af3f797919cc4b8383dd9bd55dce2f3ce4585d6e
Author: RyuAhyoung 
Date:   2017-03-25T04:03:33Z

Resolve confilct manually




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at:

https://github.com/apache/zeppelin/pull/2174


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-21 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request:

https://github.com/apache/zeppelin/pull/2174

[ZEPELIN-2209] Add pagination to Helium menu

### What is this PR for?
Like I did in #2126, added pagination to Helium menu in Zeppelin. 
10 pkgs will be shown per 1 page. 

### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-2209](https://issues.apache.org/jira/browse/ZEPPELIN-2209)

### How should this be tested?
1. Replace temporarily 
[ZeppelinConfiguration.java#L46](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L46)
 with [this 
url](https://raw.githubusercontent.com/AhyoungRyu/spark-notebook-example/master/helium.json)

2. Build \w below command and restart Zeppelin server
```
 $ mvn clean package -DskipTests -pl 'zeppelin-zengine, zeppelin-server, 
zeppelin-interpreter'
```

3. Start web dev server under `ZEPPELIN_HOME/zeppelin-web` and browse 
`localhost:9000`
```
$ yarn run dev
```

4. Go to Helium menu -> Click `INTERPRETER` btn 
(Currently the other types of pkg are registered in online registry less 
than 10. That's why I request to change online registry URI in step 1)
5. Check the pagination works well or not

### Screenshots (if appropriate)

![record](https://cloud.githubusercontent.com/assets/10060731/24182469/58ec965e-0f05-11e7-8cf9-eca7d36c0106.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin add/paginationToHeliumMenu

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2174


commit 81a245fcd9220fee2d2a132d5a042caa41c9b454
Author: RyuAhyoung 
Date:   2017-03-22T04:35:41Z

Add pagination to Helium menu




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---