[GitHub] zeppelin pull request #2236: [DOC] Improve documents related to Helium

2017-04-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2236: [DOC] Improve documents related to Helium

2017-04-09 Thread tae-jun
GitHub user tae-jun opened a pull request:

https://github.com/apache/zeppelin/pull/2236

[DOC] Improve documents related to Helium

### What is this PR for?
What I did for the documents:
* Highlight codes
* Follow JSON syntax
* Remove white spaces

And in my opinion, 
[here](https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/development/writingzeppelinvisualization.html#1-create-a-npm-package)
 is ambiguous:
> "Normally, you can add any dependencies in package.json however Zeppelin 
Visualization package only allows two dependencies: zeppelin-vis and 
zeppelin-tabledata."

Does it want to say "you can add any dependencies in package.json, but you 
must include two dependencies: zeppelin-vis and zeppelin-tabledata."?


### What type of PR is it?
[Documentation]

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin helium-doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2236


commit 3e775cfd62d574f9fa74809190cb1eda605ab672
Author: Jun Kim 
Date:   2017-04-09T15:55:47Z

Highlight codes, follow JSON syntax, and remove white spaces




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---