GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/2289
[ZEPPELIN-2452] Can not handle message in revision mode on web.
### What is this PR for?
Requests interpreter editor mode information in revision mode.
However, no information is needed in revision mode.
Produces misleading logs with misleading requests to the server.
```
ERROR [2017-04-26 18:07:48,718] ({qtp1273765644-60}
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
ERROR [2017-04-26 18:07:49,081] ({qtp1273765644-109}
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
ERROR [2017-04-26 18:07:49,083] ({qtp1273765644-14}
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
```
This log is requested as many as the number of paragraphs contained in the
note.
### What type of PR is it?
Bug fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2452
### How should this be tested?
1. Create a git-repo based note. (Supported by default)
2. Modify the paragraph and commit.
3. Go to the committed revision.
4. Reload the page.
5. Check the server logs.
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin
fix/incorrectcall-geteditorsetting-on-revisionmode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2289.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2289
commit 8c77f769826d239bcfaf2ddf1ed6cf4771347b63
Author: CloverHearts
Date: 2017-04-26T09:10:18Z
fix call geteditorsetting
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
