[GitHub] zeppelin pull request #2673: [ZEPPELIN-3054] Update conf/shiro.ini.template ...

2017-11-15 Thread kjmrknsn
GitHub user kjmrknsn opened a pull request:

https://github.com/apache/zeppelin/pull/2673

[ZEPPELIN-3054] Update conf/shiro.ini.template so that non-admin users can 
restart interpreters on a notebook page

### What is this PR for?
On the default configuration of `conf/shiro.ini.template`, non admin users 
cannot restart interpreters on their notebook pages because the path 
`/api/interpreter/setting/restart/**` is not allowed to being accessed by non 
admin users.

https://user-images.githubusercontent.com/31149688/32875326-b0d1bf66-cada-11e7-98b7-6fd058cff3f6.png";>

It is convenient that all authenticated users can restart interpreters on 
their notebook pages by default, so the following line should be inserted into 
conf/shiro.ini.template:

```
/api/interpreter/setting/restart/** = authc
```

### What type of PR is it?
[Improvement]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3054

### How should this be tested?
* Tested manually. I confirmed that non admin users can restart 
interpreters on a notebook page but still cannot access to the interpreter 
settings page by using `conf/shiro.ini.template`.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjmrknsn/zeppelin ZEPPELIN-3054

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2673


commit 37e736d8b8981b52e48131661c22eebfd66f0868
Author: Keiji Yoshida 
Date:   2017-11-16T05:28:43Z

[ZEPPELIN-3054] Update conf/shiro.ini.template so that non-admin users can 
restart interpreters on a notebook page




---


[GitHub] zeppelin pull request #2673: [ZEPPELIN-3054] Update conf/shiro.ini.template ...

2017-11-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2673


---