[GitHub] zeppelin pull request #2994: [ZEPPELIN-3285] Refine the style of Notebook ti...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2994


---

[GitHub] zeppelin pull request #2994: [ZEPPELIN-3285] Refine the style of Notebook ti...

[milooy]

GitHub user milooy opened a pull request:

https://github.com/apache/zeppelin/pull/2994

[ZEPPELIN-3285] Refine the style of Notebook title

### What is this PR for?
Refine the style of Notebook title
(Ellipsis by character, 100% width under medium width browser, align delete 
button)

(Before)

![before](https://user-images.githubusercontent.com/3839771/40781776-1c420044-6518-11e8-94d6-fc7d5103771b.gif)

(After)

![after](https://user-images.githubusercontent.com/3839771/40781830-5bd25dee-6518-11e8-871f-23bbf31507e5.gif)


### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3285

### How should this be tested?
**1. Run webapp** 
```vi
cd zeppelin-web
yarn run dev
```
**2. Check the title have ellipsis by character, not looks cut.**

![image](https://user-images.githubusercontent.com/3839771/40782010-f1771e98-6518-11e8-9373-00fbeed75f2d.png)
(before / after)

**3. Check 'delete button' is aligned**

![image](https://user-images.githubusercontent.com/3839771/40782056-166634aa-6519-11e8-8cbe-8aa7f33f665b.png)

![image](https://user-images.githubusercontent.com/3839771/40782062-1b548f52-6519-11e8-985f-6e79084ce927.png)
(before / after)

**4. Check the title with is 100% under the window width 650px**

![image](https://user-images.githubusercontent.com/3839771/40782107-40b122e2-6519-11e8-9c01-887df47e7f26.png)
(before / after)


* First time? Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed 
behavior
* Outline any manual steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/milooy/zeppelin master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2994.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2994


commit 8b7d1b8db6c6677de37ea4e79372118f2774a90c
Author: Jay Jin 
Date:   2018-05-29T10:32:31Z

ZEPPELIN-3285 Align delete button in action bar

commit a4418341f652cebc54fd9518f15fc07626a62ce4
Author: Jay Jin 
Date:   2018-05-31T12:08:43Z

ZEPPELIN-3285 Delete left margin of title, ellipsis by word, RWD




---