[GitHub] zeppelin pull request #3084: [zeppelin-3639] Add Ipython interpreter prerequ...

2018-08-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3084


---


[GitHub] zeppelin pull request #3084: [zeppelin-3639] Add Ipython interpreter prerequ...

2018-07-19 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/3084

[zeppelin-3639] Add Ipython interpreter prerequisite check for protobuf

### What is this PR for?
This is to protobuf prerequisite check when starting ipython kernel. This 
is required since from grpcio 1.12.0 it's  independent from protobuf


### What type of PR is it?
[ Improvement ]

### Todos
* [x] - add protobuf prerequisite check
* [x] - add to ipython docs

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3639

### How should this be tested?
1. remove grpcio and protobuf 
2. install latest grpcio and try to run ipython interpreter - should fail
3. then install protobuf and try again - should work

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-3639

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3084.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3084


commit 58c06898b7d78790f153dfea9912acf1d837a5c8
Author: Khalid Huseynov 
Date:   2018-07-19T06:47:53Z

add protobuf prerequsite check

commit 066e061d25d0066102818eb57a97840cece77ad5
Author: Khalid Huseynov 
Date:   2018-07-19T07:03:58Z

fix ipython documentation




---