[GitHub] zeppelin pull request #3239: Zeppelin 3879: create "maxRows" and "rowsFetchS...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/3239 ---
[GitHub] zeppelin pull request #3239: Zeppelin 3879: create "maxRows" and "rowsFetchS...
Github user monsieurp closed the pull request at: https://github.com/apache/zeppelin/pull/3239 ---
[GitHub] zeppelin pull request #3239: Zeppelin 3879: create "maxRows" and "rowsFetchS...
GitHub user monsieurp reopened a pull request: https://github.com/apache/zeppelin/pull/3239 Zeppelin 3879: create "maxRows" and "rowsFetchSize" values in interpreter/jdbc/interpreter-setting.json ### What is this PR for? This PR introduces code to configure manually the "maxRows" and "rowsFetchSize" Statement settings directly from the interpreter/jdbc/interpreter-setting.json file. The default value for these two settings is 1000 which can slow down a Zeppelin instance quite a lot if a SQL query returns a big chunk of data. See [1] and [2] for more info about these function calls. [1]: https://docs.oracle.com/javase/8/docs/api/java/sql/Statement.html#setFetchSize-int- [2]: https://docs.oracle.com/javase/8/docs/api/java/sql/Statement.html#setMaxRows-int- ### What type of PR is it? Improvement. ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3879 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? Yes. For the time being, I'd like the Zeppelin authors input whether such a change makes sense. Thanks! You can merge this pull request into a Git repository by running: $ git pull https://github.com/monsieurp/zeppelin ZEPPELIN-3879 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3239 commit 233c2e9a842c4c78530381d9e2ceeca55b886850 Author: Patrice Clement Date: 2018-11-23T22:09:24Z ZEPPELIN-3879: create "rowsFetchSize" value in interpreter/jdbc/interpreter-setting.json commit 5c7fa5a0d4a9f23aa92f2d692141c3b42b83 Author: Patrice Clement Date: 2018-11-23T22:45:44Z ZEPPELIN-3879: create "maxRows" value in interpreter/jdbc/interpreter-setting.json ---
[GitHub] zeppelin pull request #3239: Zeppelin 3879: create "maxRows" and "rowsFetchS...
GitHub user monsieurp opened a pull request: https://github.com/apache/zeppelin/pull/3239 Zeppelin 3879: create "maxRows" and "rowsFetchSize" values in interpreter/jdbc/interpreter-setting.json ### What is this PR for? This PR introduces code to configure manually the "maxRows" and "rowsFetchSize" Statement settings directly from the interpreter/jdbc/interpreter-setting.json file. The default value for these two settings is 1000 which can slow down a Zeppelin instance quite a lot if a SQL query returns a big chunk of data. See [1] and [2] for more info about these function calls. [1]: https://docs.oracle.com/javase/8/docs/api/java/sql/Statement.html#setFetchSize-int- [2]: https://docs.oracle.com/javase/8/docs/api/java/sql/Statement.html#setMaxRows-int- ### What type of PR is it? Improvement. ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3879 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? Yes. For the time being, I'd like the Zeppelin authors input whether such a change make sense. Thanks! You can merge this pull request into a Git repository by running: $ git pull https://github.com/monsieurp/zeppelin ZEPPELIN-3879 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3239 commit bd462c8d1337cbe18aab31896e31d6b0017e8ff4 Author: Patrice Clement Date: 2018-11-23T22:09:24Z ZEPPELIN-3879: create "rowsFetchSize" value in interpreter/jdbc/interpreter-setting.json commit 58068816a341c96aa96a08663a16eb89a7d85904 Author: Patrice Clement Date: 2018-11-23T22:45:44Z ZEPPELIN-3879: create "maxRows" value in interpreter/jdbc/interpreter-setting.json ---
