[GitHub] incubator-zeppelin pull request: Fix dead link and add table tab t...

[corneadoug]

Github user corneadoug commented on the pull request:

https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-179580019
  
Merging if there is no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix dead link and add table tab t...

[corneadoug]

Github user corneadoug commented on the pull request:

https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-179371302
  
Except for that last comment, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix dead link and add table tab t...

[AhyoungRyu]

Github user AhyoungRyu commented on the pull request:

https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-178491535
  
@felixcheung 
I really appreciate to your detailed explanation! I applied your comments 
and pushed again : )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix dead link and add table tab t...

[AhyoungRyu]

Github user AhyoungRyu commented on the pull request:

https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-177457158
  
@Leemoonsoo I see. So I applied your comment and pushed it : )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix dead link and add table tab t...

[AhyoungRyu]

Github user AhyoungRyu commented on the pull request:

https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-177152345
  
@felixcheung You're right.
But I've thought this table is too big to identify at a glance :’-( 
Then, how about adding a note sentence below( or above ) the table such as 
"There are a lot of overlapped facts between `zeppelin-env.sh` and 
`zeppelin-site.xml`. Please compare and use what you need." 
It's just my personal opinion, if two columns in one table are better, I'm 
willing to set back : )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix dead link and add table tab t...

[felixcheung]

Github user felixcheung commented on the pull request:

https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-177030666
  
The tabs are nice but would it be better to put -env.sh in a column, 
-site.xml in another in one table? They have a lot overlap?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix dead link and add table tab t...

[AhyoungRyu]

GitHub user AhyoungRyu opened a pull request:

https://github.com/apache/incubator-zeppelin/pull/679

Fix dead link and add table tab to Zeppelin Configuration section: 
docs/install/install.md

### What is this PR for?
As mentioned at 
[ZEPPELIN-638](https://issues.apache.org/jira/browse/ZEPPELIN-638), there is a 
dead link in `docs/install/install.md`. So I fixed it. Plus, I also add a table 
tab to **Zeppelin Configuration** section because current one is not good to 
look. 

### What type of PR is it?
Improvement | Documentation

### Todos
* [x] - Fix dead link
* [x] - Add table tab to Zeppelin Configuration section

### Is there a relevant Jira issue?
[ZEPPELIN-638](https://issues.apache.org/jira/browse/ZEPPELIN-638) (only 
for fixing dead link)

### How should this be tested?
After applying this PR, you can check this page `Quick Start` -> `Install` 
at Zeppelin documentation. 

### Screenshots (if appropriate)
* Before

![before](https://cloud.githubusercontent.com/assets/10060731/12668250/ed1ba00c-c697-11e5-943c-57f140ccf6db.gif)

* After 

![after](https://cloud.githubusercontent.com/assets/10060731/12668254/fb7a067a-c697-11e5-8061-62a79ab2bbc6.gif)


### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-638

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-zeppelin/pull/679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #679


commit 17ea00eacab9948d596947f04f872eaa84ecf65d
Author: Ryu Ah young 
Date:   2016-01-29T05:37:45Z

Fix dead link and add table tab to Zeppelin Configuration section




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---