ZooKeeper-trunk - Build # 1106 - Failure
See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1106/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 131492 lines...] [exec] Zookeeper_watchers::testChildWatcher2 : elapsed 300 : OK [exec] OK (33) [exec] ./zktest-mt [exec] ZooKeeper server startedRunning [exec] Zookeeper_clientretry::testRetry ZooKeeper server started ZooKeeper server started : elapsed 9717 : OK [exec] Zookeeper_operations::testAsyncWatcher1 : elapsed 54 : OK [exec] Zookeeper_operations::testAsyncGetOperation : elapsed 2 : OK [exec] Zookeeper_operations::testOperationsAndDisconnectConcurrently1 : elapsed 907 : OK [exec] Zookeeper_operations::testOperationsAndDisconnectConcurrently2 : elapsed 0 : OK [exec] Zookeeper_operations::testConcurrentOperations1 : elapsed 4822 : OK [exec] Zookeeper_init::testBasic : elapsed 0 : OK [exec] Zookeeper_init::testAddressResolution : elapsed 0 : OK [exec] Zookeeper_init::testMultipleAddressResolution : elapsed 0 : OK [exec] Zookeeper_init::testNullAddressString : elapsed 0 : OK [exec] Zookeeper_init::testEmptyAddressString : elapsed 0 : OK [exec] Zookeeper_init::testOneSpaceAddressString : elapsed 0 : OK [exec] Zookeeper_init::testTwoSpacesAddressString : elapsed 0 : OK [exec] Zookeeper_init::testInvalidAddressString1 : elapsed 0 : OK [exec] Zookeeper_init::testInvalidAddressString2 : elapsed 1 : OK [exec] Zookeeper_init::testNonexistentHost : elapsed 0 : OK [exec] Zookeeper_init::testOutOfMemory_init : elapsed 0 : OK [exec] Zookeeper_init::testOutOfMemory_getaddrs1 : elapsed 0 : OK [exec] Zookeeper_init::testOutOfMemory_getaddrs2 : elapsed 0 : OK [exec] Zookeeper_init::testPermuteAddrsList : elapsed 0 : OK [exec] Zookeeper_close::testIOThreadStoppedOnExpire : elapsed 237 : OK [exec] Zookeeper_close::testCloseUnconnected : elapsed 0 : OK [exec] Zookeeper_close::testCloseUnconnected1 : elapsed 32 : OK [exec] Zookeeper_close::testCloseConnected1 : elapsed 240 : OK [exec] Zookeeper_close::testCloseFromWatcher1 : elapsed 233 : OK [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server started : elapsed 12348 : OK [exec] Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK [exec] Zookeeper_simpleSystem::testNullData : elapsed 1021 : OK [exec] Zookeeper_simpleSystem::testIPV6 : elapsed 1001 : OK [exec] Zookeeper_simpleSystem::testPath : elapsed 1006 : OK [exec] Zookeeper_simpleSystem::testPathValidation : elapsed 1020 : OK [exec] Zookeeper_simpleSystem::testPing : elapsed 17089 : OK [exec] Zookeeper_simpleSystem::testAcl : elapsed 1008 : OK [exec] Zookeeper_simpleSystem::testChroot : elapsed 4017 : OK [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : elapsed 27369 : OK Build timed out. Aborting [exec] Zookeeper_simpleSystem::testHangingClient [exec] make: *** [run-check] Terminated BUILD FAILED /grid/0/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/build.xml:930: The following error occurred while executing this line: /grid/0/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/build.xml:889: The following error occurred while executing this line: /grid/0/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/build.xml:900: exec returned: 2 Total time: 58 minutes 40 seconds [FINDBUGS] Skipping publisher since build result is FAILURE [WARNINGS] Skipping publisher since build result is FAILURE Recording fingerprints Archiving artifacts Recording test results Publishing Javadoc Publishing Clover coverage report... No Clover report will be published due to a Build Failure Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] Commented: (ZOOKEEPER-784) server-side functionality for read-only mode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998822#comment-12998822 ] Sergey Doroshenko commented on ZOOKEEPER-784: - Has anybody had a chance to look at the latest patch? It's already approved by Hudson, and its previous version has two +1s, so I hope it'll get into trunk soon. > server-side functionality for read-only mode > > > Key: ZOOKEEPER-784 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-784 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Sergey Doroshenko >Assignee: Sergey Doroshenko > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, > ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, > ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, > ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, > ZOOKEEPER-784.patch > > > As per http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode , create > ReadOnlyZooKeeperServer which comes into play when peer is partitioned. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-994) "eclipse" target in the build script doesnot include libraray required for test classes in the classpath
[ https://issues.apache.org/jira/browse/ZOOKEEPER-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999086#comment-12999086 ] Hadoop QA commented on ZOOKEEPER-994: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471317/ZOOKEEPER-994-patch.txt against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/158//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/158//console This message is automatically generated. > "eclipse" target in the build script doesnot include libraray required for > test classes in the classpath > > > Key: ZOOKEEPER-994 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-994 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.3.2 > Environment: Linux box, Eclipse IDE >Reporter: MIS >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-994-patch.txt > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > The "eclipse" target in the zoo-keeper build script doesn't include the > accessive.jar present in the folder /src/java/libtest in the .classpath file. > But the accessive.jar is being referenced from a couple of test classes. > However, the build is successful :) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-998) Issue with Netty in BookKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999088#comment-12999088 ] Hadoop QA commented on ZOOKEEPER-998: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471577/ZOOKEEPER-998.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/157//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/157//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/157//console This message is automatically generated. > Issue with Netty in BookKeeper > -- > > Key: ZOOKEEPER-998 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-998 > Project: ZooKeeper > Issue Type: Bug > Components: contrib-bookkeeper >Affects Versions: 3.3.2 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-998.patch > > > In one my experiments, I found that a BookKeeper object was locked after I > tried to halt it. By searching the Web, I found that the issue is described > here: > http://www.jboss.org/netty/community.html#nabble-td5492010 > I'll upload a patch to fix it. For now, I'm marking it for 3.4.0, but if > there is any chance we can get it in 3.3.3, it would be nice. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-992) MT Native Version of Windows C Client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999102#comment-12999102 ] Hadoop QA commented on ZOOKEEPER-992: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471308/win32_patch.txt against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 27 release audit warnings (more than the trunk's current 24 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/160//testReport/ Release audit warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/160//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/160//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/160//console This message is automatically generated. > MT Native Version of Windows C Client > -- > > Key: ZOOKEEPER-992 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-992 > Project: ZooKeeper > Issue Type: New Feature > Components: c client > Environment: Windows 32 >Reporter: Camille Fournier > Fix For: 3.4.0 > > Attachments: win32_patch.txt > > > This is an extention of the work in > https://issues.apache.org/jira/browse/ZOOKEEPER-859 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-993) Code improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999104#comment-12999104 ] Hadoop QA commented on ZOOKEEPER-993: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471309/ZOOKEEPER-993-patch.txt against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/159//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/159//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/159//console This message is automatically generated. > Code improvements > - > > Key: ZOOKEEPER-993 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-993 > Project: ZooKeeper > Issue Type: Improvement > Components: leaderElection >Affects Versions: 3.3.2, 3.3.3 > Environment: Linux box, Eclipse IDE, >Reporter: MIS >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-993-patch.txt > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In the file org.apache.zookeeper.server.quorum.FastLeaderElection.java for > methods like totalOrderPredicate and termPredicate, which return boolean, the > code is as below : > if (condition) > return true; > else > return false; > I feel, it would be better if the condition itself is returned. > i.e., return condition. > The same thing holds good else where if applicable. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-976) ZooKeeper startup script doesn't use JAVA_HOME
[
https://issues.apache.org/jira/browse/ZOOKEEPER-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999112#comment-12999112
]
Hadoop QA commented on ZOOKEEPER-976:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12470109/ZOOKEEPER-976.patch
against trunk revision 1072085.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/162//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/162//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/162//console
This message is automatically generated.
> ZooKeeper startup script doesn't use JAVA_HOME
> --
>
> Key: ZOOKEEPER-976
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-976
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.3.2
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-976.patch
>
>
> From bug filed on CDH: https://issues.cloudera.org/browse/DISTRO-47 - moving
> it to this jira to address:
> --
> Bug filed by "grep.alex" at
> http://getsatisfaction.com/cloudera/topics/cdh3b3_zookeeper_startup_script_doesnt_use_java_home
> On RedHat 5 (using the RPM installer) I was able to install and run all the
> Hadoop components. The Zookeeper install was fine, but it wouldn't start:
> {noformat}
> [root@aholmes-desktop init.d]# ./hadoop-zookeeper start
> JMX enabled by default
> Using config: /etc/zookeeper/zoo.cfg
> Starting zookeeper ...
> STARTED
> [root@aholmes-desktop init.d]# Exception in thread "main"
> java.lang.NoSuchMethodError: method
> java.lang.management.ManagementFactory.getPlatformMBeanServer with signature
> ()Ljavax.management.MBeanServer; was not found.
> at
> org.apache.zookeeper.jmx.ManagedUtil.registerLog4jMBeans(ManagedUtil.java:48
> ...
> {noformat}
> After some digging around I found the cause - the Zookeeper startup script
> (/usr/lib/zookeeper/bin/zkServer.sh ) uses the java found in the path,
> whereas the other startup scripts use JAVA_HOME. In my case I had the default
> RHEL5 1.4 JDK in the path, and the 1.6 JDK RPM's installed under /usr/java,
> hence the above error, which I'm guessing is a fairly common setup.
> In my opinion all the startup scripts should all use the same mechanism to
> determine where to pick java.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-983) running zkServer.sh start remotely using ssh hangs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999114#comment-12999114 ] Hadoop QA commented on ZOOKEEPER-983: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470108/ZOOKEEPER-983.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/161//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/161//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/161//console This message is automatically generated. > running zkServer.sh start remotely using ssh hangs > -- > > Key: ZOOKEEPER-983 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-983 > Project: ZooKeeper > Issue Type: Bug > Components: scripts >Affects Versions: 3.3.2 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-983.patch > > > If zkServer.sh is run remotely using ssh as follows ssh will "hang" - i.e. > not complete/return once the server is started. This is even though > zkServer.sh starts the java vm in the background. > $ ssh "zkServer.sh start" > this is due to the following issue: > http://www.slac.stanford.edu/comp/unix/ssh_faq.html#logoff_hangs -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-932) Move blocking read/write calls to SendWorker and RecvWorker Threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999115#comment-12999115 ] Hadoop QA commented on ZOOKEEPER-932: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12469274/ZOOKEEPER-932.patchv3 against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/165//console This message is automatically generated. > Move blocking read/write calls to SendWorker and RecvWorker Threads > --- > > Key: ZOOKEEPER-932 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-932 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.3.2 >Reporter: Vishal K >Assignee: Vishal K > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-932.patch, ZOOKEEPER-932.patch, > ZOOKEEPER-932.patch, ZOOKEEPER-932.patchv3, ZOOKEEPER-932.patchv3 > > > Copying relevant comments: > Vishal K added a comment - 02/Nov/10 02:09 PM > Hi Flavio, > I have a suggestion for changing the blocking IO code in QuorumCnxManager. It > keeps the current code structure and requires a small amount of changes. I am > not sure if these comments should go in ZOOKEEPER-901. ZOOKEEPER-901 is > probably addressing netty as well. Please feel free to close this JIRA if you > intend to make all the changes as a part of ZOOKEEPER-901. > Basically we jusy need to move parts of initiateConnection and > receiveConnection to SenderWorker and ReceiveWorker. > A. Current flow for receiving connection: > 1. accept connection in Listener.run() > 2. receiveConnection() > * Read remote server's ID > * Take action based on my ID and remote server's ID (disconnect and > reconnect if my ID is > remote server's ID). > * kill current set of SenderWorker and ReciveWorker threads > * Start a new pair > B Current flow for initiating connection: > 1. In connectOne(), connect if not already connected. else return. > 2. send my ID to the remote server > 3. if my ID < remote server disconnect and return > 4. if my ID > remote server > * kill current set of SenderWorker and ReceiveWorkter threads for the > remote server > * Start a new pair > Proposed changes: > Move the code that performs any blocking IO in SenderWorker and ReceiveWorker. > A. Proposed flow for receiving connection: > 1. accept connection in Listener.run() > 2. receiveConnection() > * kill current set of SenderWorker and ReciveWorker threads > * Start a new pair > Proposed changed to SenderWorker: > * Read remote server's ID > * Take action based on my ID and remote server's ID (disconnect and > reconnect if my ID is > remote server's ID). > * Proceed to normal operation > B Proposed flow for initiating connection: > 1. in connectOne(), return if already connected > 2. Start a new SenderWorker and ReceiveWorker pair > 2. In SenderWorker > * connect to remote server > * write my ID > * if my ID < remote server disconnect and return (shutdown the pair). > * Proceed to normal operation > Questions: > * In QuorumCnxManager, is it necessary to kill the current pair and > restart a new one every time we receive a connect request? > * In receiveConnection we may choose to reject an accepted connection if > a thread in > SenderWorker is in the process of connecting. Otherwise a server with > ID < > remote server may keep sending frequent connect request that will > result in the > remote server closing connections for this peer. But I think we add a > delay > before sending notifications, which might be good enough to prevent this > problem. > Let me know what you think about this. I can also help with the > implementation. > Flavio Junqueira added a comment - 03/Nov/10 05:28 PM > Hi Vishal, I like your proposal, it seems reasonable and not difficult to > implement. > On your questions: >1. I don't think it is necessary to kill a pair SenderWorker/RecvWorker > every time, and I'd certainly support changing it; >2. I'm not sure where you're suggesting to introduce a delay. In the FLE > code, a server sends a new batch of notifications if it changes its vote or > if it times out waiting for a new notification. This timeout value increases > over time. I was actually thinking that we should reset the timeout value > upon receiving a notification. I think this is a bug > Given that it is your proposal, I'd be happy to let you take a stab at it and > help you out if you need a hand. Does
[jira] Commented: (ZOOKEEPER-938) support Kerberos Authentication
[ https://issues.apache.org/jira/browse/ZOOKEEPER-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999119#comment-12999119 ] Hadoop QA commented on ZOOKEEPER-938: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471140/ZOOKEEPER-938.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/163//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/163//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/163//console This message is automatically generated. > support Kerberos Authentication > --- > > Key: ZOOKEEPER-938 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-938 > Project: ZooKeeper > Issue Type: New Feature > Components: java client, server >Reporter: Eugene Koontz >Assignee: Eugene Koontz > Fix For: 3.4.0 > > Attachments: NIOServerCnxn.patch, ZOOKEEPER-938.patch, > ZOOKEEPER-938.patch, jaas.conf, sasl.patch > > > Support Keberos authentication of clients. > The following usage would let an admin use Kerberos authentication to assign > ACLs to authenticated clients. > 1. Admin logs into zookeeper (not necessarily through Kerberos however). > 2. Admin decides that a new node called '/mynode' should be owned by the user > 'zkclient' and have full permissions on this. > 3. Admin does: zk> create /mynode content kerb:zkcli...@foofers.org:x:cdrwa > (note: for now, the dummy ':x' is a placeholder for the password, and is > required by the zk command parser. The user's actual password is not stored > within Zookeeper; simply put 'x' there.) > 4. User 'zkclient' logins to kerberos using the command line utility 'kinit'. > 5. User connects to zookeeper server using a Kerberos-enabled version of > zkClient (ZookeeperMain). > 6. Behind the scenes, the client and server exchange authentication > information. User is now authenticated as 'zkclient'. > 7. User accesses /mynode with permissions 'cdrwa'. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-850) Switch from log4j to slf4j
[ https://issues.apache.org/jira/browse/ZOOKEEPER-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999124#comment-12999124 ] Hadoop QA commented on ZOOKEEPER-850: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12465621/ZOOKEEPER-850.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 249 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/167//console This message is automatically generated. > Switch from log4j to slf4j > -- > > Key: ZOOKEEPER-850 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-850 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.3.1 >Reporter: Olaf Krische >Assignee: Olaf Krische > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-3.3.1-log4j-slf4j-20101031.patch.bz2, > ZOOKEEPER-3.4.0-log4j-slf4j-20101102.patch.bz2, ZOOKEEPER-850.patch, > ZOOKEEPER-850.patch, ZOOKEEPER-850.patch > > > Hello, > i would like to see slf4j integrated into the zookeeper instead of relying > explicitly on log4j. > slf4j is an abstract logging framework. There are adapters from slf4j to many > logger implementations, one of them is log4j. > The decision which log engine to use i dont like to make so early. > This would help me to embed zookeeper in my own applications (which use a > different logger implemenation, but slf4j is the basis) > What do you think? > (as i can see, those slf4j request flood all other projects on apache as well > :-) > Maybe for 3.4 or 4.0? > I can offer a patchset, i have experience in such an migration already. :-) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-935) Concurrent primitives library - shared lock
[ https://issues.apache.org/jira/browse/ZOOKEEPER-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999123#comment-12999123 ] Hadoop QA commented on ZOOKEEPER-935: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459903/ZOOKEEPER-935.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/164//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/164//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/164//console This message is automatically generated. > Concurrent primitives library - shared lock > --- > > Key: ZOOKEEPER-935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-935 > Project: ZooKeeper > Issue Type: Improvement > Components: recipes > Environment: Debian squeeze > JDK 1.6.x > zookeeper trunk >Reporter: ChiaHung Lin >Assignee: ChiaHung Lin >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-935.patch > > > I create this jira to add sharedock function. The function follows recipes at > http://hadoop.apache.org/zookeeper/docs/r3.1.2/recipes.html#Shared+Locks -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-896) Improve C client to support dynamic authentication schemes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999128#comment-12999128 ] Hadoop QA commented on ZOOKEEPER-896: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12466338/ZOOKEEPER-896.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/166//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/166//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/166//console This message is automatically generated. > Improve C client to support dynamic authentication schemes > -- > > Key: ZOOKEEPER-896 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-896 > Project: ZooKeeper > Issue Type: Improvement > Components: c client >Affects Versions: 3.3.2 >Reporter: Botond Hejj >Assignee: Botond Hejj > Fix For: 3.4.0 > > Attachments: NIOServerCnxn.patch, ZOOKEEPER-896.patch, > ZOOKEEPER-896.patch, ZOOKEEPER-896.patch > > > When we started exploring zookeeper for our requirements we found the > authentication mechanism is not flexible enough. > We want to use kerberos for authentication but using the current API we ran > into a few problems. The idea is that we get a kerberos token on the client > side and than send that token to the server with a kerberos scheme. A server > side authentication plugin can use that token to authenticate the client and > also use the token for authorization. > We ran into two problems with this approach: > 1. A different kerberos token is needed for each different server that client > can connect to since kerberos uses mutual authentication. That means when the > client acquires this kerberos token it has to know which server it connects > to and generate the token according to that. The client currently can't > generate a token for a specific server. The token stored in the auth_info is > used for all the servers. > 2. The kerberos token might have an expiry time so if the client loses the > connection to the server and than it tries to reconnect it should acquire a > new token. That is not possible currently since the token is stored in > auth_info and reused for every connection. > The problem can be solved if we allow the client to register a callback for > authentication instead a static token. This can be a callback with an > argument which passes the current host string. The zookeeper client code > could call this callback before it sends the authentication info to the > server to get a fresh server specific token. > This would solve our problem with the kerberos authentication and also could > be used for other more dynamic authentication schemes. > The solution could be generalization also for the java client as well. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-837) cyclic dependency ClientCnxn, ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999137#comment-12999137 ] Hadoop QA commented on ZOOKEEPER-837: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471745/ZOOKEEPER-837.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/168//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/168//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/168//console This message is automatically generated. > cyclic dependency ClientCnxn, ZooKeeper > --- > > Key: ZOOKEEPER-837 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-837 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.3.1 >Reporter: Patrick Datko >Assignee: Thomas Koch > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-837.patch, ZOOKEEPER-837.patch, > ZOOKEEPER-837.patch > > > ZooKeeper instantiates ClientCnxn in its ctor with this and therefor builds a > cyclic dependency graph between both objects. This means, you can't have the > one without the other. So why did you bother do make them to separate classes > in the first place? > ClientCnxn accesses ZooKeeper.state. State should rather be a property of > ClientCnxn. And ClientCnxn accesses zooKeeper.get???Watches() in its method > primeConnection(). I've not yet checked, how this dependency should be > resolved better. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-781) provide a generalized "connection strategy" for ZooKeeper clients
[ https://issues.apache.org/jira/browse/ZOOKEEPER-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999142#comment-12999142 ] Hadoop QA commented on ZOOKEEPER-781: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471092/ZOOKEEPER-781.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/170//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/170//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/170//console This message is automatically generated. > provide a generalized "connection strategy" for ZooKeeper clients > - > > Key: ZOOKEEPER-781 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-781 > Project: ZooKeeper > Issue Type: New Feature > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Qian Ye > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-781.patch, ZOOKEEPER-781.patch, > ZOOKEEPER-781.patch > > > A connection strategy allows control over the way that ZooKeeper clients (we > would implement this for both c and java apis) connect to a serving ensemble. > Today we have two strategies, randomized round robin (default) and ordered > round robin, both of which are hard coded into the client implementation. We > would generalize this interface and allow users to create their own. > See this page for more detail: > http://wiki.apache.org/hadoop/ZooKeeper/ConnectionStrategy -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-784) server-side functionality for read-only mode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999143#comment-12999143 ] Hadoop QA commented on ZOOKEEPER-784: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470236/ZOOKEEPER-784.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/169//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/169//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/169//console This message is automatically generated. > server-side functionality for read-only mode > > > Key: ZOOKEEPER-784 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-784 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Sergey Doroshenko >Assignee: Sergey Doroshenko > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, > ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, > ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, > ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, > ZOOKEEPER-784.patch > > > As per http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode , create > ReadOnlyZooKeeperServer which comes into play when peer is partitioned. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999144#comment-12999144 ] Hadoop QA commented on ZOOKEEPER-767: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12457928/ZOOKEEPER-767.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/171//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/171//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/171//console This message is automatically generated. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: ZooKeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-702) GSoC 2010: Failure Detector Model
[ https://issues.apache.org/jira/browse/ZOOKEEPER-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999148#comment-12999148 ] Hadoop QA commented on ZOOKEEPER-702: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12469882/ZOOKEEPER-702.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 72 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/172//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/172//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/172//console This message is automatically generated. > GSoC 2010: Failure Detector Model > - > > Key: ZOOKEEPER-702 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-702 > Project: ZooKeeper > Issue Type: Wish >Reporter: Henry Robinson >Assignee: Abmar Barros > Labels: gsoc, mentor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-702-code.patch, ZOOKEEPER-702-doc.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > bertier-pseudo.txt, bertier-pseudo.txt, chen-pseudo.txt, chen-pseudo.txt, > phiaccrual-pseudo.txt, phiaccrual-pseudo.txt > > > Failure Detector Module > Possible Mentor > Henry Robinson (henry at apache dot org) > Requirements > Java, some distributed systems knowledge, comfort implementing distributed > systems protocols > Description > ZooKeeper servers detects the failure of other servers and clients by > counting the number of 'ticks' for which it doesn't get a heartbeat from > other machines. This is the 'timeout' method of failure detection and works > very well; however it is possible that it is too aggressive and not easily > tuned for some more unusual ZooKeeper installations (such as in a wide-area > network, or even in a mobile ad-hoc network). > This project would abstract the notion of failure detection to a dedicated > Java module, and implement several failure detectors to compare and contrast > their appropriateness for ZooKeeper. For example, Apache Cassandra uses a > phi-accrual failure detector (http://ddsg.jaist.ac.jp/pub/HDY+04.pdf) which > is much more tunable and has some very interesting properties. This is a > great project if you are interested in distributed algorithms, or want to > help re-factor some of ZooKeeper's internal code. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-850) Switch from log4j to slf4j
[ https://issues.apache.org/jira/browse/ZOOKEEPER-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999168#comment-12999168 ] Olaf Krische commented on ZOOKEEPER-850: Michi, i am currently kind of flooded with other stuff. Maybe on a weekend i will try to create a new patch again. > Switch from log4j to slf4j > -- > > Key: ZOOKEEPER-850 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-850 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.3.1 >Reporter: Olaf Krische >Assignee: Olaf Krische > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-3.3.1-log4j-slf4j-20101031.patch.bz2, > ZOOKEEPER-3.4.0-log4j-slf4j-20101102.patch.bz2, ZOOKEEPER-850.patch, > ZOOKEEPER-850.patch, ZOOKEEPER-850.patch > > > Hello, > i would like to see slf4j integrated into the zookeeper instead of relying > explicitly on log4j. > slf4j is an abstract logging framework. There are adapters from slf4j to many > logger implementations, one of them is log4j. > The decision which log engine to use i dont like to make so early. > This would help me to embed zookeeper in my own applications (which use a > different logger implemenation, but slf4j is the basis) > What do you think? > (as i can see, those slf4j request flood all other projects on apache as well > :-) > Maybe for 3.4 or 4.0? > I can offer a patchset, i have experience in such an migration already. :-) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-702) GSoC 2010: Failure Detector Model
[ https://issues.apache.org/jira/browse/ZOOKEEPER-702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abmar Barros updated ZOOKEEPER-702: --- Attachment: ZOOKEEPER-702.patch * Updated patch with trunk * Added the stddev as a metric for the timeout estimation (which was removed in the last patch). * Remove ping interval update when timeout was updated in the adaptive mechanisms. > GSoC 2010: Failure Detector Model > - > > Key: ZOOKEEPER-702 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-702 > Project: ZooKeeper > Issue Type: Wish >Reporter: Henry Robinson >Assignee: Abmar Barros > Labels: gsoc, mentor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-702-code.patch, ZOOKEEPER-702-doc.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, bertier-pseudo.txt, bertier-pseudo.txt, chen-pseudo.txt, > chen-pseudo.txt, phiaccrual-pseudo.txt, phiaccrual-pseudo.txt > > > Failure Detector Module > Possible Mentor > Henry Robinson (henry at apache dot org) > Requirements > Java, some distributed systems knowledge, comfort implementing distributed > systems protocols > Description > ZooKeeper servers detects the failure of other servers and clients by > counting the number of 'ticks' for which it doesn't get a heartbeat from > other machines. This is the 'timeout' method of failure detection and works > very well; however it is possible that it is too aggressive and not easily > tuned for some more unusual ZooKeeper installations (such as in a wide-area > network, or even in a mobile ad-hoc network). > This project would abstract the notion of failure detection to a dedicated > Java module, and implement several failure detectors to compare and contrast > their appropriateness for ZooKeeper. For example, Apache Cassandra uses a > phi-accrual failure detector (http://ddsg.jaist.ac.jp/pub/HDY+04.pdf) which > is much more tunable and has some very interesting properties. This is a > great project if you are interested in distributed algorithms, or want to > help re-factor some of ZooKeeper's internal code. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-848) Implement the Failure Detector module in the C client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999212#comment-12999212 ] Abmar Barros commented on ZOOKEEPER-848: I have been working in a separate C module for this. The code is hosted at https://github.com/abmargb/zk-fdmodule-c As soon as I finish implementing all the mechanisms I'll integrate it with the C client. > Implement the Failure Detector module in the C client > - > > Key: ZOOKEEPER-848 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-848 > Project: ZooKeeper > Issue Type: Improvement > Components: c client >Reporter: Abmar Barros > > The failure detector module > https://issues.apache.org/jira/browse/ZOOKEEPER-702 is only used in the java > client of ZooKeeper, once it reuses the implementation written in Java. The > failure detectors must be written in C and the C client must be refactored to > use them. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-837) cyclic dependency ClientCnxn, ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999239#comment-12999239 ] Thomas Koch commented on ZOOKEEPER-837: --- The last failed Hudson test is in the C code. > cyclic dependency ClientCnxn, ZooKeeper > --- > > Key: ZOOKEEPER-837 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-837 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.3.1 >Reporter: Patrick Datko >Assignee: Thomas Koch > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-837.patch, ZOOKEEPER-837.patch, > ZOOKEEPER-837.patch > > > ZooKeeper instantiates ClientCnxn in its ctor with this and therefor builds a > cyclic dependency graph between both objects. This means, you can't have the > one without the other. So why did you bother do make them to separate classes > in the first place? > ClientCnxn accesses ZooKeeper.state. State should rather be a property of > ClientCnxn. And ClientCnxn accesses zooKeeper.get???Watches() in its method > primeConnection(). I've not yet checked, how this dependency should be > resolved better. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)
On Wed, Feb 23, 2011 at 3:21 AM, Flavio Junqueira wrote: > The problem is that there is a path "zookeeper-3.3.3/contrib/bookkeeper" > containing build.xml and source code. If you try to run from there, it will > fail. I'm actually wondering why we have the source code both under contrib/ > and under src/contrib/. The folder structure under contrib/ is different and > it does look like it is not supposed to compile (hence my confusion), and I > wonder why we need it in the release. > > We inherited that structure from hadoop back when ZK was initially moved to apache (so it's been like this since 3.0.0). If I understand correctly the intent is to have a "src" (src/contrib) and a "dest" (contrib) structure, where dest includes both the source and binary. Notice contrib/bookeeper has a bookeeper.jar in the release artifact. Perhaps we should just have bookeeper.jar in there, and not the source... Another alternative is to just not have contrib at all (the user would be required to compile the bk jar say). Really though I think we should focus on moving to something like maven. Such that we can generate the src/bin/doc for each component and push generated artifacts to the maven repo. At which point this is a non issue. Patrick > On Feb 22, 2011, at 10:34 PM, Patrick Hunt wrote: > > On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira > wrote: > >> I'm not sure why you say it is fine, Pat. If I try to compile with the >> candidate release, ant complains that build-contrib.xml is missing (and it >> is not where it is supposed to be). Compiling from trunk or one of the >> branches works fine, though. >> > > Hi Flavio, can you be more specific? Because it's working fine for me: > > cd zookeeper-3.3.3/src/contrib/bookkeeper > ant jar > ... > jar: > [echo] contrib: bookkeeper > > BUILD SUCCESSFUL > Total time: 2 seconds > > > >> -Flavio >> >> On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote: >> >> I think it's fine - it's in src/contrib not contrib. >> >> On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed >> wrote: >> >> i don't know why build-contrib.xml is missing. pat do you have any ideas? >> >> ant tar should grab it right? >> >> >> ben >> >> >> >> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira > >wrote: >> >> >> Ben, I have a question. Even though the bookkeeper jar is there, >> >> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without >> >> it. Is it supposed to be this way? >> >> >> -Flavio >> >> >> >> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote: >> >> >> (the previous email had the URL slightly incorrect) >> >> >> after much struggle! i've created a candidate build for ZooKeeper 3.3.3. >> >> this is a bug fix >> >> release addressing 13 issues (two of them extremely critical) -- see the >> >> release notes for details. >> >> >> *** Please download, test and VOTE before the >> >> *** vote closes 11pm pacific time, Tuesday, February 22.*** >> >> >> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/ >> >> >> one thing that has not been fixed in this release is that the docs still >> >> reference hadoop. this will be fixed in a future release. >> >> >> should we release this? >> >> >> ben >> >> >> ps - give that this is the first release there is more than likely >> >> something >> >> i missed and given the severity of issues addressed it would be nice to >> >> get >> >> it out quickly. please review ASAP. >> >> >> >> *flavio* >> >> *junqueira* >> >> >> research scientist >> >> >> f...@yahoo-inc.com >> >> direct +34 93-183-8828 >> >> >> avinguda diagonal 177, 8th floor, barcelona, 08018, es >> >> phone (408) 349 3300fax (408) 349 3301 >> >> >> >> >> >> >> *flavio* >> *junqueira* >> >> research scientist >> >> f...@yahoo-inc.com >> direct +34 93-183-8828 >> >> avinguda diagonal 177, 8th floor, barcelona, 08018, es >> phone (408) 349 3300fax (408) 349 3301 >> >> >> >> > > *flavio* > *junqueira* > > research scientist > > f...@yahoo-inc.com > direct +34 93-183-8828 > > avinguda diagonal 177, 8th floor, barcelona, 08018, es > phone (408) 349 3300fax (408) 349 3301 > > >
Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)
See my comments I just sent to Flavio. I agree, if we go with something like maven we should be able to have a source only release artifact, plus a number of binary artifacts (push to maven, a separate binary artifact, etc...). I've proposed maven in the past, but not gotten much interest. Now that addl people are participating in the RM task there may be renewed interest. ;-) Patrick On Wed, Feb 23, 2011 at 4:55 AM, Thomas Koch wrote: > Flavio Junqueira: >> The problem is that there is a path "zookeeper-3.3.3/contrib/ >> bookkeeper" containing build.xml and source code. If you try to run >> from there, it will fail. I'm actually wondering why we have the >> source code both under contrib/ and under src/contrib/. The folder >> structure under contrib/ is different and it does look like it is not >> supposed to compile (hence my confusion), and I wonder why we need it >> in the release. >> >> -Flavio > The code dupliation of contrib and src/contrib is one of the annoyances when > packaging ZooKeeper for Debian. You'd really do me a favor if you'd release a > tarball without this duplication. > (The biggest annoyance is the shipment of binary .jar files in every java > project, not only ZooKeeper. - But things are getting better slowly with > maven.) > > Best regards, > > Thomas Koch, http://www.koch.ro >
[jira] Commented: (ZOOKEEPER-702) GSoC 2010: Failure Detector Model
[ https://issues.apache.org/jira/browse/ZOOKEEPER-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999251#comment-12999251 ] Hadoop QA commented on ZOOKEEPER-702: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471908/ZOOKEEPER-702.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 72 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/173//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/173//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/173//console This message is automatically generated. > GSoC 2010: Failure Detector Model > - > > Key: ZOOKEEPER-702 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-702 > Project: ZooKeeper > Issue Type: Wish >Reporter: Henry Robinson >Assignee: Abmar Barros > Labels: gsoc, mentor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-702-code.patch, ZOOKEEPER-702-doc.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, ZOOKEEPER-702.patch, > ZOOKEEPER-702.patch, bertier-pseudo.txt, bertier-pseudo.txt, chen-pseudo.txt, > chen-pseudo.txt, phiaccrual-pseudo.txt, phiaccrual-pseudo.txt > > > Failure Detector Module > Possible Mentor > Henry Robinson (henry at apache dot org) > Requirements > Java, some distributed systems knowledge, comfort implementing distributed > systems protocols > Description > ZooKeeper servers detects the failure of other servers and clients by > counting the number of 'ticks' for which it doesn't get a heartbeat from > other machines. This is the 'timeout' method of failure detection and works > very well; however it is possible that it is too aggressive and not easily > tuned for some more unusual ZooKeeper installations (such as in a wide-area > network, or even in a mobile ad-hoc network). > This project would abstract the notion of failure detection to a dedicated > Java module, and implement several failure detectors to compare and contrast > their appropriateness for ZooKeeper. For example, Apache Cassandra uses a > phi-accrual failure detector (http://ddsg.jaist.ac.jp/pub/HDY+04.pdf) which > is much more tunable and has some very interesting properties. This is a > great project if you are interested in distributed algorithms, or want to > help re-factor some of ZooKeeper's internal code. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
