[jira] [Commented] (ZOOKEEPER-1136) NEW_LEADER should be queued not sent to match the Zab 1.0 protocol on the twiki

2011-08-20 Thread Benjamin Reed (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088295#comment-13088295
 ] 

Benjamin Reed commented on ZOOKEEPER-1136:
--

1. yes, i'll put a comment to that effect in the patch
2. it is only reformatting. the previous patch was checked in with tabs
3. yes, we should add a test. let me see what i can do.

> NEW_LEADER should be queued not sent to match the Zab 1.0 protocol on the 
> twiki
> ---
>
> Key: ZOOKEEPER-1136
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1136
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Benjamin Reed
>Assignee: Benjamin Reed
>Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1136.patch, ZOOKEEPER-1136.patch
>
>
> the NEW_LEADER message was sent at the beginning of the sync phase in Zab 
> pre1.0, but it must be at the end in Zab 1.0. if the protocol is 1.0 or 
> greater we need to queue rather than send the packet.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1152) Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer

2011-08-20 Thread Benjamin Reed (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088292#comment-13088292
 ] 

Benjamin Reed commented on ZOOKEEPER-1152:
--

+1 looks good camille. committing now.

> Exceptions thrown from handleAuthentication can cause buffer corruption 
> issues in NIOServer
> ---
>
> Key: ZOOKEEPER-1152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1152
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.3, 3.4.0
>Reporter: Camille Fournier
>Assignee: Camille Fournier
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1152.patch
>
>
> Exceptions thrown by an AuthenticationProvider's handleAuthentication method 
> will not be caught, and can cause the buffers in the NIOServer to not read 
> requests fully or properly. Any exceptions thrown here should be caught and 
> treated as auth failure. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1152) Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer

2011-08-20 Thread Mahadev konar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-1152:
-

Fix Version/s: 3.4.0

> Exceptions thrown from handleAuthentication can cause buffer corruption 
> issues in NIOServer
> ---
>
> Key: ZOOKEEPER-1152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1152
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.3, 3.4.0
>Reporter: Camille Fournier
>Assignee: Camille Fournier
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1152.patch
>
>
> Exceptions thrown by an AuthenticationProvider's handleAuthentication method 
> will not be caught, and can cause the buffers in the NIOServer to not read 
> requests fully or properly. Any exceptions thrown here should be caught and 
> treated as auth failure. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1152) Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer

2011-08-20 Thread Camille Fournier (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088238#comment-13088238
 ] 

Camille Fournier commented on ZOOKEEPER-1152:
-

Can someone please take a look at this? It would be nice to get this into 3.4 
since it is a rather nasty thing to deal with.

> Exceptions thrown from handleAuthentication can cause buffer corruption 
> issues in NIOServer
> ---
>
> Key: ZOOKEEPER-1152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1152
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.3, 3.4.0
>Reporter: Camille Fournier
>Assignee: Camille Fournier
> Attachments: ZOOKEEPER-1152.patch
>
>
> Exceptions thrown by an AuthenticationProvider's handleAuthentication method 
> will not be caught, and can cause the buffers in the NIOServer to not read 
> requests fully or properly. Any exceptions thrown here should be caught and 
> treated as auth failure. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1159) ClientCnxn does not propagate session expiration indication

2011-08-20 Thread Mahadev konar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-1159:
-

 Priority: Blocker  (was: Major)
Fix Version/s: 3.4.0

> ClientCnxn does not propagate session expiration indication
> ---
>
> Key: ZOOKEEPER-1159
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1159
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 3.4.0
>
>
> ClientCnxn does not always propagate session expiration indication up to 
> clients. If a reconnection attempt fails because the session has since 
> expired, the KeeperCode is still Disconnected, but shouldn't it be set to 
> Expired? Perhaps like so:
> {code}
> --- a/src/java/main/org/apache/zookeeper/ClientCnxn.java
> +++ b/src/java/main/org/apache/zookeeper/ClientCnxn.java
> @@ -1160,6 +1160,7 @@ public class ClientCnxn {
>  clientCnxnSocket.doTransport(to, pendingQueue, 
> outgoingQueue);
>  
>  } catch (Exception e) {
> +Event.KeeperState eventState = 
> Event.KeeperState.Disconnected;
>  if (closing) {
>  if (LOG.isDebugEnabled()) {
>  // closing so this is expected
> @@ -1172,6 +1173,7 @@ public class ClientCnxn {
>  // this is ugly, you have a better way speak up
>  if (e instanceof SessionExpiredException) {
>  LOG.info(e.getMessage() + ", closing socket 
> connection");
> +eventState = Event.KeeperState.Expired;
>  } else if (e instanceof SessionTimeoutException) {
>  LOG.info(e.getMessage() + RETRY_CONN_MSG);
>  } else if (e instanceof EndOfStreamException) {
> @@ -1191,7 +1193,7 @@ public class ClientCnxn {
>  if (state.isAlive()) {
>  eventThread.queueEvent(new WatchedEvent(
>  Event.EventType.None,
> -Event.KeeperState.Disconnected,
> +eventState,
>  null));
>  }
>  clientCnxnSocket.updateNow();
> {code}
> This affects HBase. HBase master and region server processes will shut down 
> by design if their session has expired, but will attempt to reconnect if they 
> think they have been disconnected. The above prevents proper termination.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (ZOOKEEPER-1159) ClientCnxn does not propagate session expiration indication

2011-08-20 Thread Andrew Purtell (JIRA) 
ClientCnxn does not propagate session expiration indication
---

 Key: ZOOKEEPER-1159
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1159
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client
Affects Versions: 3.4.0
Reporter: Andrew Purtell


ClientCnxn does not always propagate session expiration indication up to 
clients. If a reconnection attempt fails because the session has since expired, 
the KeeperCode is still Disconnected, but shouldn't it be set to Expired? 
Perhaps like so:

{code}
--- a/src/java/main/org/apache/zookeeper/ClientCnxn.java
+++ b/src/java/main/org/apache/zookeeper/ClientCnxn.java
@@ -1160,6 +1160,7 @@ public class ClientCnxn {
 clientCnxnSocket.doTransport(to, pendingQueue, 
outgoingQueue);
 
 } catch (Exception e) {
+Event.KeeperState eventState = 
Event.KeeperState.Disconnected;
 if (closing) {
 if (LOG.isDebugEnabled()) {
 // closing so this is expected
@@ -1172,6 +1173,7 @@ public class ClientCnxn {
 // this is ugly, you have a better way speak up
 if (e instanceof SessionExpiredException) {
 LOG.info(e.getMessage() + ", closing socket 
connection");
+eventState = Event.KeeperState.Expired;
 } else if (e instanceof SessionTimeoutException) {
 LOG.info(e.getMessage() + RETRY_CONN_MSG);
 } else if (e instanceof EndOfStreamException) {
@@ -1191,7 +1193,7 @@ public class ClientCnxn {
 if (state.isAlive()) {
 eventThread.queueEvent(new WatchedEvent(
 Event.EventType.None,
-Event.KeeperState.Disconnected,
+eventState,
 null));
 }
 clientCnxnSocket.updateNow();
{code}

This affects HBase. HBase master and region server processes will shut down by 
design if their session has expired, but will attempt to reconnect if they 
think they have been disconnected. The above prevents proper termination.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: ZooKeeper-trunk - Build # 1270 - Still Failing

2011-08-20 Thread Mahadev Konar 
BTW, I see some similar exceptions  on the Hadoop Common build as
well. Ill check with Giri and see what the issues here.

thanks
mahadev


ERROR: Publisher hudson.plugins.findbugs.FindBugsPublisher aborted due
to exception
hudson.util.IOException2: remote file operation failed:
 at
hudson.remoting.Channel@7742683:hadoop2
   at hudson.FilePath.act(FilePath.java:754)
   at hudson.FilePath.act(FilePath.java:740)
   at 
hudson.plugins.findbugs.FindBugsPublisher.perform(FindBugsPublisher.java:141)
   at 
hudson.plugins.analysis.core.HealthAwarePublisher.perform(HealthAwarePublisher.java:310)
   at hudson.tasks.BuildStepMonitor$2.perform(BuildStepMonitor.java:27)
   at 
hudson.model.AbstractBuild$AbstractRunner.perform(AbstractBuild.java:682)
   at 
hudson.model.AbstractBuild$AbstractRunner.performAllBuildSteps(AbstractBuild.java:657)
   at 
hudson.model.AbstractBuild$AbstractRunner.performAllBuildSteps(AbstractBuild.java:635)
   at hudson.model.Build$RunnerImpl.post2(Build.java:162)
   at hudson.model.AbstractBuild$AbstractRunner.post(AbstractBuild.java:604)
   at hudson.model.Run.run(Run.java:1401)
   at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
   at hudson.model.ResourceController.execute(ResourceController.java:88)
   at hudson.model.Executor.run(Executor.java:230)
Caused by: java.io.IOException: Remote call on hadoop2 failed
   at hudson.remoting.Channel.call(Channel.java:673)
   at hudson.FilePath.act(FilePath.java:747)
   ... 13 more
Caused by: java.lang.ClassNotFoundException: Failed to deserialize the
Callable object. Perhaps you needed to implement DelegatingCallable?
   at hudson.remoting.UserRequest.perform(UserRequest.java:100)
   at hudson.remoting.UserRequest.perform(UserRequest.java:48)
   at hudson.remoting.Request$2.run(Request.java:270)
   at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
   at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
   at java.util.concurrent.FutureTask.run(FutureTask.java:138)
   at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
   at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
   at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.ClassNotFoundException: hudson.plugi

On Fri, Aug 19, 2011 at 9:42 AM, Mahadev Konar  wrote:
> This looks more like a clover/findbugs bug?
>
> mahadev
>
>
> On Fri, Aug 19, 2011 at 6:26 AM, Fournier, Camille F.
>  wrote:
>> Anyone looking at this?
>>
>> C
>>
>>
>> - Original Message -
>> From: Apache Jenkins Server 
>> To: dev@zookeeper.apache.org 
>> Sent: Fri Aug 19 06:54:08 2011
>> Subject: ZooKeeper-trunk - Build # 1270 - Still Failing
>>
>> See https://builds.apache.org/job/ZooKeeper-trunk/1270/
>>
>> ###
>> ## LAST 60 LINES OF THE CONSOLE 
>> ###
>> [...truncated 264136 lines...]
>>        at 
>> hudson.model.AbstractBuild$AbstractRunner.performAllBuildSteps(AbstractBuild.java:635)
>>        at hudson.model.Build$RunnerImpl.post2(Build.java:162)
>>        at 
>> hudson.model.AbstractBuild$AbstractRunner.post(AbstractBuild.java:604)
>>        at hudson.model.Run.run(Run.java:1401)
>>        at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
>>        at hudson.model.ResourceController.execute(ResourceController.java:88)
>>        at hudson.model.Executor.run(Executor.java:230)
>> Caused by: java.io.IOException: Remote call on hadoop8 failed
>>        at hudson.remoting.Channel.call(Channel.java:673)
>>        at hudson.FilePath.act(FilePath.java:747)
>>        ... 13 more
>> Caused by: java.lang.ClassNotFoundException: Failed to deserialize the 
>> Callable object. Perhaps you needed to implement DelegatingCallable?
>>        at hudson.remoting.UserRequest.perform(UserRequest.java:100)
>>        at hudson.remoting.UserRequest.perform(UserRequest.java:48)
>>        at hudson.remoting.Request$2.run(Request.java:270)
>>        at 
>> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
>>        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
>>        at java.util.concurrent.FutureTask.run(FutureTask.java:138)
>>        at 
>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>>        at 
>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>>        at java.lang.Thread.run(Thread.java:662)
>> Caused by: java.lang.ClassNotFoundException: 
>> hudson.plugins.findbugs.parser.FindBugsParser
>>        at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
>>        at java.security.AccessController.doPrivileged(Native Method)
>>        at java.net.URLClassLoader.findClass(URLClassLoader.java:19

ZooKeeper-trunk - Build # 1271 - Still Failing

2011-08-20 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper-trunk/1271/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 176372 lines...]
at 
hudson.model.AbstractBuild$AbstractRunner.perform(AbstractBuild.java:682)
at 
hudson.model.AbstractBuild$AbstractRunner.performAllBuildSteps(AbstractBuild.java:657)
at 
hudson.model.AbstractBuild$AbstractRunner.performAllBuildSteps(AbstractBuild.java:635)
at hudson.model.Build$RunnerImpl.post2(Build.java:162)
at 
hudson.model.AbstractBuild$AbstractRunner.post(AbstractBuild.java:604)
at hudson.model.Run.run(Run.java:1401)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:230)
Caused by: java.io.IOException: Remote call on hadoop8 failed
at hudson.remoting.Channel.call(Channel.java:673)
at hudson.FilePath.act(FilePath.java:747)
... 13 more
Caused by: java.lang.ClassNotFoundException: Failed to deserialize the Callable 
object. Perhaps you needed to implement DelegatingCallable?
at hudson.remoting.UserRequest.perform(UserRequest.java:100)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:270)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.ClassNotFoundException: 
hudson.plugins.findbugs.parser.FindBugsParser
at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:247)
at java.io.ObjectInputStream.resolveClass(ObjectInputStream.java:603)
at 
hudson.remoting.ObjectInputStreamEx.resolveClass(ObjectInputStreamEx.java:50)
at 
java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1574)
at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1495)
at 
java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1731)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1328)
at 
java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1946)
at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1870)
at 
java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1752)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1328)
at 
java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1946)
at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1870)
at 
java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1752)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1328)
at java.io.ObjectInputStream.readObject(ObjectInputStream.java:350)
at hudson.remoting.UserRequest.deserialize(UserRequest.java:182)
at hudson.remoting.UserRequest.perform(UserRequest.java:98)
... 8 more
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Publishing Clover coverage report...
No Clover report will be published due to a Build Failure
Recording test results
Publishing Javadoc
Recording fingerprints
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed