[jira] [Commented] (ZOOKEEPER-1355) Add zk.updateServerList(newServerList)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243032#comment-13243032 ] Marshall McMullen commented on ZOOKEEPER-1355: -- I posted this latest patch on review board: https://reviews.apache.org/r/4596/ > Add zk.updateServerList(newServerList) > --- > > Key: ZOOKEEPER-1355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1355 > Project: ZooKeeper > Issue Type: New Feature > Components: java client >Reporter: Alexander Shraer >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1355-ver10-1.patch, > ZOOKEEPER-1355-ver10-2.patch, ZOOKEEPER-1355-ver10-3.patch, > ZOOKEEPER-1355-ver10-4.patch, ZOOKEEPER-1355-ver10-4.patch, > ZOOKEEPER-1355-ver10.patch, ZOOKEEPER-1355-ver11-1.patch, > ZOOKEEPER-1355-ver11.patch, ZOOKEEPER-1355-ver2.patch, > ZOOKEEPER-1355-ver4.patch, ZOOKEEPER-1355-ver5.patch, > ZOOKEEPER-1355-ver6.patch, ZOOKEEPER-1355-ver7.patch, > ZOOKEEPER-1355-ver8.patch, ZOOKEEPER-1355-ver9-1.patch, > ZOOKEEPER-1355-ver9.patch, ZOOKEEPER=1355-ver3.patch, > ZOOOKEEPER-1355-test.patch, ZOOOKEEPER-1355-ver1.patch, > ZOOOKEEPER-1355.patch, loadbalancing-more-details.pdf, loadbalancing.pdf > > > When the set of servers changes, we would like to update the server list > stored by clients without restarting the clients. > Moreover, assuming that the number of clients per server is the same (in > expectation) in the old configuration (as guaranteed by the current list > shuffling for example), we would like to re-balance client connections across > the new set of servers in a way that a) the number of clients per server is > the same for all servers (in expectation) and b) there is no > excessive/unnecessary client migration. > It is simple to achieve (a) without (b) - just re-shuffle the new list of > servers at every client. But this would create unnecessary migration, which > we'd like to avoid. > We propose a simple probabilistic migration scheme that achieves (a) and (b) > - each client locally decides whether and where to migrate when the list of > servers changes. The attached document describes the scheme and shows an > evaluation of it in Zookeeper. We also implemented re-balancing through a > consistent-hashing scheme and show a comparison. We derived the probabilistic > migration rules from a simple formula that we can also provide, if someone's > interested in the proof. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: Add support to dynamically change the list of servers clients will connect to (e.g. for rolling restart or dynamic zookeeper)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4596/ --- (Updated 2012-03-31 05:42:42.527029) Review request for zookeeper. Changes --- Changed title. Summary (updated) --- This is a patch for ZOOKEEEPER-1355 (https://issues.apache.org/jira/browse/ZOOKEEPER-1355) to allow changing the list of servers the clients will connect to dynamically as needed. E.g. to support rolling restart or future support for dynamic zookeeper (ZOOKEEPER-107). >From ZOOKEEPER-1355: When the set of servers changes, we would like to update the server list stored by clients without restarting the clients. Moreover, assuming that the number of clients per server is the same (in expectation) in the old configuration (as guaranteed by the current list shuffling for example), we would like to re-balance client connections across the new set of servers in a way that a) the number of clients per server is the same for all servers (in expectation) and b) there is no excessive/unnecessary client migration. It is simple to achieve (a) without (b) - just re-shuffle the new list of servers at every client. But this would create unnecessary migration, which we'd like to avoid. We propose a simple probabilistic migration scheme that achieves (a) and (b) - each client locally decides whether and where to migrate when the list of servers changes. The attached document describes the scheme and shows an evaluation of it in Zookeeper. We also implemented re-balancing through a consistent-hashing scheme and show a comparison. We derived the probabilistic migration rules from a simple formula that we can also provide, if someone's interested in the proof. Diffs - ./src/c/src/addrvec.c PRE-CREATION ./src/c/src/addrvec.h PRE-CREATION ./src/c/Makefile.am 1307721 ./src/c/include/zookeeper.h 1307721 ./src/c/src/hashtable/hashtable_itr.h 1307721 ./src/c/src/mt_adaptor.c 1307721 ./src/c/src/st_adaptor.c 1307721 ./src/c/src/zk_adaptor.h 1307721 ./src/c/src/zookeeper.c 1307721 ./src/c/tests/TestReconfig.cc PRE-CREATION ./src/c/tests/TestZookeeperClose.cc 1307721 ./src/c/tests/TestZookeeperInit.cc 1307721 ./src/c/tests/ZKMocks.cc 1307721 ./src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 1307721 ./src/java/main/org/apache/zookeeper/ZooKeeper.java 1307721 ./src/java/main/org/apache/zookeeper/client/HostProvider.java 1307721 ./src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 1307721 ./src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1307721 ./src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java 1307721 Diff: https://reviews.apache.org/r/4596/diff Testing --- Lots of included unit tests (e.g. TestReconfig.c on C side and StaticHostProviderTest.java on the java side). Thanks, Marshall
Review Request: Add support for dynamically changing the list of servers the clients will connect to support rolling restart or future support for dynamic zookeeper
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4596/ --- Review request for zookeeper. Summary --- This is a patch for ZOOKEEEPER-1355 (https://issues.apache.org/jira/browse/ZOOKEEPER-1355) to allow changing the list of servers the clients will connect to dynamically as needed. E.g. to support rolling restart or future support for dynamic zookeeper (ZOOKEEPER-107). >From ZOOKEEPER-1355: When the set of servers changes, we would like to update the server list stored by clients without restarting the clients. Moreover, assuming that the number of clients per server is the same (in expectation) in the old configuration (as guaranteed by the current list shuffling for example), we would like to re-balance client connections across the new set of servers in a way that a) the number of clients per server is the same for all servers (in expectation) and b) there is no excessive/unnecessary client migration. It is simple to achieve (a) without (b) - just re-shuffle the new list of servers at every client. But this would create unnecessary migration, which we'd like to avoid. We propose a simple probabilistic migration scheme that achieves (a) and (b) - each client locally decides whether and where to migrate when the list of servers changes. The attached document describes the scheme and shows an evaluation of it in Zookeeper. We also implemented re-balancing through a consistent-hashing scheme and show a comparison. We derived the probabilistic migration rules from a simple formula that we can also provide, if someone's interested in the proof. Diffs - ./src/c/src/addrvec.c PRE-CREATION ./src/c/src/addrvec.h PRE-CREATION ./src/c/Makefile.am 1307721 ./src/c/include/zookeeper.h 1307721 ./src/c/src/hashtable/hashtable_itr.h 1307721 ./src/c/src/mt_adaptor.c 1307721 ./src/c/src/st_adaptor.c 1307721 ./src/c/src/zk_adaptor.h 1307721 ./src/c/src/zookeeper.c 1307721 ./src/c/tests/TestReconfig.cc PRE-CREATION ./src/c/tests/TestZookeeperClose.cc 1307721 ./src/c/tests/TestZookeeperInit.cc 1307721 ./src/c/tests/ZKMocks.cc 1307721 ./src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 1307721 ./src/java/main/org/apache/zookeeper/ZooKeeper.java 1307721 ./src/java/main/org/apache/zookeeper/client/HostProvider.java 1307721 ./src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 1307721 ./src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1307721 ./src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java 1307721 Diff: https://reviews.apache.org/r/4596/diff Testing --- Lots of included unit tests (e.g. TestReconfig.c on C side and StaticHostProviderTest.java on the java side). Thanks, Marshall
[jira] [Commented] (ZOOKEEPER-1355) Add zk.updateServerList(newServerList)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243029#comment-13243029 ] Hadoop QA commented on ZOOKEEPER-1355: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520766/ZOOKEEPER-1355-ver11-1.patch against trunk revision 1307644. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 34 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1025//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1025//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1025//console This message is automatically generated. > Add zk.updateServerList(newServerList) > --- > > Key: ZOOKEEPER-1355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1355 > Project: ZooKeeper > Issue Type: New Feature > Components: java client >Reporter: Alexander Shraer >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1355-ver10-1.patch, > ZOOKEEPER-1355-ver10-2.patch, ZOOKEEPER-1355-ver10-3.patch, > ZOOKEEPER-1355-ver10-4.patch, ZOOKEEPER-1355-ver10-4.patch, > ZOOKEEPER-1355-ver10.patch, ZOOKEEPER-1355-ver11-1.patch, > ZOOKEEPER-1355-ver11.patch, ZOOKEEPER-1355-ver2.patch, > ZOOKEEPER-1355-ver4.patch, ZOOKEEPER-1355-ver5.patch, > ZOOKEEPER-1355-ver6.patch, ZOOKEEPER-1355-ver7.patch, > ZOOKEEPER-1355-ver8.patch, ZOOKEEPER-1355-ver9-1.patch, > ZOOKEEPER-1355-ver9.patch, ZOOKEEPER=1355-ver3.patch, > ZOOOKEEPER-1355-test.patch, ZOOOKEEPER-1355-ver1.patch, > ZOOOKEEPER-1355.patch, loadbalancing-more-details.pdf, loadbalancing.pdf > > > When the set of servers changes, we would like to update the server list > stored by clients without restarting the clients. > Moreover, assuming that the number of clients per server is the same (in > expectation) in the old configuration (as guaranteed by the current list > shuffling for example), we would like to re-balance client connections across > the new set of servers in a way that a) the number of clients per server is > the same for all servers (in expectation) and b) there is no > excessive/unnecessary client migration. > It is simple to achieve (a) without (b) - just re-shuffle the new list of > servers at every client. But this would create unnecessary migration, which > we'd like to avoid. > We propose a simple probabilistic migration scheme that achieves (a) and (b) > - each client locally decides whether and where to migrate when the list of > servers changes. The attached document describes the scheme and shows an > evaluation of it in Zookeeper. We also implemented re-balancing through a > consistent-hashing scheme and show a comparison. We derived the probabilistic > migration rules from a simple formula that we can also provide, if someone's > interested in the proof. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-1355 PreCommit Build #1025
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1355 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1025/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 185982 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12520766/ZOOKEEPER-1355-ver11-1.patch [exec] against trunk revision 1307644. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 34 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1025//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1025//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1025//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] UabtYrrPi0 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 27 minutes 54 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1355 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Updated] (ZOOKEEPER-1355) Add zk.updateServerList(newServerList)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marshall McMullen updated ZOOKEEPER-1355: - Attachment: ZOOKEEPER-1355-ver11-1.patch Minor bug fix for count_hosts in case an empty string is passed in. > Add zk.updateServerList(newServerList) > --- > > Key: ZOOKEEPER-1355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1355 > Project: ZooKeeper > Issue Type: New Feature > Components: java client >Reporter: Alexander Shraer >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1355-ver10-1.patch, > ZOOKEEPER-1355-ver10-2.patch, ZOOKEEPER-1355-ver10-3.patch, > ZOOKEEPER-1355-ver10-4.patch, ZOOKEEPER-1355-ver10-4.patch, > ZOOKEEPER-1355-ver10.patch, ZOOKEEPER-1355-ver11-1.patch, > ZOOKEEPER-1355-ver11.patch, ZOOKEEPER-1355-ver2.patch, > ZOOKEEPER-1355-ver4.patch, ZOOKEEPER-1355-ver5.patch, > ZOOKEEPER-1355-ver6.patch, ZOOKEEPER-1355-ver7.patch, > ZOOKEEPER-1355-ver8.patch, ZOOKEEPER-1355-ver9-1.patch, > ZOOKEEPER-1355-ver9.patch, ZOOKEEPER=1355-ver3.patch, > ZOOOKEEPER-1355-test.patch, ZOOOKEEPER-1355-ver1.patch, > ZOOOKEEPER-1355.patch, loadbalancing-more-details.pdf, loadbalancing.pdf > > > When the set of servers changes, we would like to update the server list > stored by clients without restarting the clients. > Moreover, assuming that the number of clients per server is the same (in > expectation) in the old configuration (as guaranteed by the current list > shuffling for example), we would like to re-balance client connections across > the new set of servers in a way that a) the number of clients per server is > the same for all servers (in expectation) and b) there is no > excessive/unnecessary client migration. > It is simple to achieve (a) without (b) - just re-shuffle the new list of > servers at every client. But this would create unnecessary migration, which > we'd like to avoid. > We propose a simple probabilistic migration scheme that achieves (a) and (b) > - each client locally decides whether and where to migrate when the list of > servers changes. The attached document describes the scheme and shows an > evaluation of it in Zookeeper. We also implemented re-balancing through a > consistent-hashing scheme and show a comparison. We derived the probabilistic > migration rules from a simple formula that we can also provide, if someone's > interested in the proof. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1355) Add zk.updateServerList(newServerList)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marshall McMullen updated ZOOKEEPER-1355: - Attachment: (was: ZOOKEEPER-1355-ver11-1.patch) > Add zk.updateServerList(newServerList) > --- > > Key: ZOOKEEPER-1355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1355 > Project: ZooKeeper > Issue Type: New Feature > Components: java client >Reporter: Alexander Shraer >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1355-ver10-1.patch, > ZOOKEEPER-1355-ver10-2.patch, ZOOKEEPER-1355-ver10-3.patch, > ZOOKEEPER-1355-ver10-4.patch, ZOOKEEPER-1355-ver10-4.patch, > ZOOKEEPER-1355-ver10.patch, ZOOKEEPER-1355-ver11-1.patch, > ZOOKEEPER-1355-ver11.patch, ZOOKEEPER-1355-ver2.patch, > ZOOKEEPER-1355-ver4.patch, ZOOKEEPER-1355-ver5.patch, > ZOOKEEPER-1355-ver6.patch, ZOOKEEPER-1355-ver7.patch, > ZOOKEEPER-1355-ver8.patch, ZOOKEEPER-1355-ver9-1.patch, > ZOOKEEPER-1355-ver9.patch, ZOOKEEPER=1355-ver3.patch, > ZOOOKEEPER-1355-test.patch, ZOOOKEEPER-1355-ver1.patch, > ZOOOKEEPER-1355.patch, loadbalancing-more-details.pdf, loadbalancing.pdf > > > When the set of servers changes, we would like to update the server list > stored by clients without restarting the clients. > Moreover, assuming that the number of clients per server is the same (in > expectation) in the old configuration (as guaranteed by the current list > shuffling for example), we would like to re-balance client connections across > the new set of servers in a way that a) the number of clients per server is > the same for all servers (in expectation) and b) there is no > excessive/unnecessary client migration. > It is simple to achieve (a) without (b) - just re-shuffle the new list of > servers at every client. But this would create unnecessary migration, which > we'd like to avoid. > We propose a simple probabilistic migration scheme that achieves (a) and (b) > - each client locally decides whether and where to migrate when the list of > servers changes. The attached document describes the scheme and shows an > evaluation of it in Zookeeper. We also implemented re-balancing through a > consistent-hashing scheme and show a comparison. We derived the probabilistic > migration rules from a simple formula that we can also provide, if someone's > interested in the proof. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1355) Add zk.updateServerList(newServerList)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marshall McMullen updated ZOOKEEPER-1355: - Attachment: ZOOKEEPER-1355-ver11-1.patch Minor bugfix in count_hosts in case an empty string is passed in. > Add zk.updateServerList(newServerList) > --- > > Key: ZOOKEEPER-1355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1355 > Project: ZooKeeper > Issue Type: New Feature > Components: java client >Reporter: Alexander Shraer >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1355-ver10-1.patch, > ZOOKEEPER-1355-ver10-2.patch, ZOOKEEPER-1355-ver10-3.patch, > ZOOKEEPER-1355-ver10-4.patch, ZOOKEEPER-1355-ver10-4.patch, > ZOOKEEPER-1355-ver10.patch, ZOOKEEPER-1355-ver11-1.patch, > ZOOKEEPER-1355-ver11.patch, ZOOKEEPER-1355-ver2.patch, > ZOOKEEPER-1355-ver4.patch, ZOOKEEPER-1355-ver5.patch, > ZOOKEEPER-1355-ver6.patch, ZOOKEEPER-1355-ver7.patch, > ZOOKEEPER-1355-ver8.patch, ZOOKEEPER-1355-ver9-1.patch, > ZOOKEEPER-1355-ver9.patch, ZOOKEEPER=1355-ver3.patch, > ZOOOKEEPER-1355-test.patch, ZOOOKEEPER-1355-ver1.patch, > ZOOOKEEPER-1355.patch, loadbalancing-more-details.pdf, loadbalancing.pdf > > > When the set of servers changes, we would like to update the server list > stored by clients without restarting the clients. > Moreover, assuming that the number of clients per server is the same (in > expectation) in the old configuration (as guaranteed by the current list > shuffling for example), we would like to re-balance client connections across > the new set of servers in a way that a) the number of clients per server is > the same for all servers (in expectation) and b) there is no > excessive/unnecessary client migration. > It is simple to achieve (a) without (b) - just re-shuffle the new list of > servers at every client. But this would create unnecessary migration, which > we'd like to avoid. > We propose a simple probabilistic migration scheme that achieves (a) and (b) > - each client locally decides whether and where to migrate when the list of > servers changes. The attached document describes the scheme and shows an > evaluation of it in Zookeeper. We also implemented re-balancing through a > consistent-hashing scheme and show a comparison. We derived the probabilistic > migration rules from a simple formula that we can also provide, if someone's > interested in the proof. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise updated ZOOKEEPER-1437: Fix Version/s: 3.4.4 > Client uses session before SASL authentication complete > --- > > Key: ZOOKEEPER-1437 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.3 >Reporter: Thomas Weise >Assignee: Eugene Koontz > Fix For: 3.4.4, 3.5.0 > > Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, > ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch > > > Found issue in the context of hbase region server startup, but can be > reproduced w/ zkCli alone. > getData may occur prior to SaslAuthenticated and fail with NoAuth. This is > not expected behavior when the client is configured to use SASL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242910#comment-13242910 ] Thomas Weise commented on ZOOKEEPER-1437: - Thanks Eugene, the last patch did it! Login synchronization works (NoAuth failures in HBase are gone and no processes hanging). I have not done any negative testing though. Nice to see secure ZK working with HBase! I have applied the patch to 3.4.x and adding it as fix version. > Client uses session before SASL authentication complete > --- > > Key: ZOOKEEPER-1437 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.3 >Reporter: Thomas Weise >Assignee: Eugene Koontz > Fix For: 3.4.4, 3.5.0 > > Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, > ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch > > > Found issue in the context of hbase region server startup, but can be > reproduced w/ zkCli alone. > getData may occur prior to SaslAuthenticated and fail with NoAuth. This is > not expected behavior when the client is configured to use SASL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242904#comment-13242904 ] Hadoop QA commented on ZOOKEEPER-1437: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520699/ZOOKEEPER-1437.patch against trunk revision 1307644. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 19 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1024//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1024//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1024//console This message is automatically generated. > Client uses session before SASL authentication complete > --- > > Key: ZOOKEEPER-1437 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.3 >Reporter: Thomas Weise >Assignee: Eugene Koontz > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, > ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch > > > Found issue in the context of hbase region server startup, but can be > reproduced w/ zkCli alone. > getData may occur prior to SaslAuthenticated and fail with NoAuth. This is > not expected behavior when the client is configured to use SASL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-1437 PreCommit Build #1024
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1024/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 185632 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12520699/ZOOKEEPER-1437.patch [exec] against trunk revision 1307644. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 19 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1024//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1024//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1024//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 6rBB4pqCq8 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 27 minutes 2 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1437 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242881#comment-13242881 ] Eugene Koontz commented on ZOOKEEPER-1437: -- Thanks Thomas for your testing. Can you please try the latest patch and see if it the client doesn't hang anymore? -Eugene > Client uses session before SASL authentication complete > --- > > Key: ZOOKEEPER-1437 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.3 >Reporter: Thomas Weise >Assignee: Eugene Koontz > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, > ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch > > > Found issue in the context of hbase region server startup, but can be > reproduced w/ zkCli alone. > getData may occur prior to SaslAuthenticated and fail with NoAuth. This is > not expected behavior when the client is configured to use SASL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Koontz updated ZOOKEEPER-1437: - Attachment: ZOOKEEPER-1437.patch Fixes two bugs in the last patch: -authSync synchronization object was being created twice -authResultNotify() was not being called in one SASL failure mode > Client uses session before SASL authentication complete > --- > > Key: ZOOKEEPER-1437 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.3 >Reporter: Thomas Weise >Assignee: Eugene Koontz > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, > ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch > > > Found issue in the context of hbase region server startup, but can be > reproduced w/ zkCli alone. > getData may occur prior to SaslAuthenticated and fail with NoAuth. This is > not expected behavior when the client is configured to use SASL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242852#comment-13242852
]
Thomas Weise commented on ZOOKEEPER-1437:
-
I see this consistently happening in the hbase client also:
{code}
"main" prio=10 tid=0x08061000 nid=0x5af6 in Object.wait() [0xf741c000]
java.lang.Thread.State: WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0xf2674320> (a java.lang.Object)
at java.lang.Object.wait(Object.java:485)
at
org.apache.zookeeper.ClientCnxn.waitForAuthenticationIfNecessary(ClientCnxn.java:1344)
- locked <0xf2674320> (a java.lang.Object)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1355)
at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1031)
at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:154)
at
org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:226)
at
org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.start(ZooKeeperNodeTracker.java:76)
- locked <0xf2675948> (a
org.apache.hadoop.hbase.zookeeper.RootRegionTracker)
at
org.apache.hadoop.hbase.catalog.CatalogTracker.start(CatalogTracker.java:233)
at
org.apache.hadoop.hbase.client.HBaseAdmin.getCatalogTracker(HBaseAdmin.java:143)
- locked <0xf3f76370> (a org.apache.hadoop.hbase.client.HBaseAdmin)
at
org.apache.hadoop.hbase.client.HBaseAdmin.tableExists(HBaseAdmin.java:200)
{code}
Authentication succeeds on the server but the client waits forever.
> Client uses session before SASL authentication complete
> ---
>
> Key: ZOOKEEPER-1437
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.4.3
>Reporter: Thomas Weise
>Assignee: Eugene Koontz
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch
>
>
> Found issue in the context of hbase region server startup, but can be
> reproduced w/ zkCli alone.
> getData may occur prior to SaslAuthenticated and fail with NoAuth. This is
> not expected behavior when the client is configured to use SASL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242784#comment-13242784
]
Thomas Weise commented on ZOOKEEPER-1437:
-
With the patch HBase region server will hang (similar problem in HBase shell,
updated only the zookeeper client, no change to server):
{code}
"regionserver60020" prio=10 tid=0x0846ac00 nid=0x6032 in Object.wait()
[0xaf2ad000]
java.lang.Thread.State: WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0xdf5c1e30> (a java.lang.Object)
at java.lang.Object.wait(Object.java:485)
at
org.apache.zookeeper.ClientCnxn.waitForAuthenticationIfNecessary(ClientCnxn.java:1344)
- locked <0xdf5c1e30> (a java.lang.Object)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1355)
at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1031)
at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:154)
at
org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:226)
at
org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.start(ZooKeeperNodeTracker.java:76)
- locked <0xdf5c38e8> (a org.apache.hadoop.hbase.MasterAddressTracker)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.setupZookeeperTrackers(HConnectionManager.java:580)
- locked <0xdf5b8120> (a
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.(HConnectionManager.java:569)
at
org.apache.hadoop.hbase.client.HConnectionManager.getConnection(HConnectionManager.java:186)
- locked <0xe064fa10> (a
org.apache.hadoop.hbase.client.HConnectionManager$1)
at
org.apache.hadoop.hbase.catalog.CatalogTracker.(CatalogTracker.java:178)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.initializeZooKeeper(HRegionServer.java:565)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:524)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:625)
at java.lang.Thread.run(Thread.java:619)
{code}
> Client uses session before SASL authentication complete
> ---
>
> Key: ZOOKEEPER-1437
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.4.3
>Reporter: Thomas Weise
>Assignee: Eugene Koontz
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch
>
>
> Found issue in the context of hbase region server startup, but can be
> reproduced w/ zkCli alone.
> getData may occur prior to SaslAuthenticated and fail with NoAuth. This is
> not expected behavior when the client is configured to use SASL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242778#comment-13242778 ] Hadoop QA commented on ZOOKEEPER-1437: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520671/ZOOKEEPER-1437.patch against trunk revision 1307191. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 19 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1023//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1023//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1023//console This message is automatically generated. > Client uses session before SASL authentication complete > --- > > Key: ZOOKEEPER-1437 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.3 >Reporter: Thomas Weise >Assignee: Eugene Koontz > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, > ZOOKEEPER-1437.patch > > > Found issue in the context of hbase region server startup, but can be > reproduced w/ zkCli alone. > getData may occur prior to SaslAuthenticated and fail with NoAuth. This is > not expected behavior when the client is configured to use SASL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-1437 PreCommit Build #1023
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1023/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 185285 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12520671/ZOOKEEPER-1437.patch [exec] against trunk revision 1307191. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 19 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1023//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1023//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1023//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] C3HEu3JoTM logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 26 minutes 59 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1437 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Updated] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Koontz updated ZOOKEEPER-1437: - Attachment: ZOOKEEPER-1437.patch Fixes the two Findbugs warnings reported by last patch. > Client uses session before SASL authentication complete > --- > > Key: ZOOKEEPER-1437 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.3 >Reporter: Thomas Weise >Assignee: Eugene Koontz > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, > ZOOKEEPER-1437.patch > > > Found issue in the context of hbase region server startup, but can be > reproduced w/ zkCli alone. > getData may occur prior to SaslAuthenticated and fail with NoAuth. This is > not expected behavior when the client is configured to use SASL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242619#comment-13242619 ] Hadoop QA commented on ZOOKEEPER-1437: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520635/ZOOKEEPER-1437.patch against trunk revision 1307191. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 19 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1022//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1022//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1022//console This message is automatically generated. > Client uses session before SASL authentication complete > --- > > Key: ZOOKEEPER-1437 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.3 >Reporter: Thomas Weise >Assignee: Eugene Koontz > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch > > > Found issue in the context of hbase region server startup, but can be > reproduced w/ zkCli alone. > getData may occur prior to SaslAuthenticated and fail with NoAuth. This is > not expected behavior when the client is configured to use SASL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-1437 PreCommit Build #1022
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1022/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 186843 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12520635/ZOOKEEPER-1437.patch [exec] against trunk revision 1307191. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 19 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1022//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1022//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1022//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 5kV0GuevRE logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1568: exec returned: 1 Total time: 26 minutes 56 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1437 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242612#comment-13242612 ] Hadoop QA commented on ZOOKEEPER-1407: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520633/1407-v5.txt against trunk revision 1307191. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1021//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1021//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1021//console This message is automatically generated. > Support GetData and GetChildren in Multi > > > Key: ZOOKEEPER-1407 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Zhihong Yu > Fix For: 3.5.0 > > Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt, > 1407.txt > > > There is use case where GetData and GetChildren would participate in Multi. > We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-1407 PreCommit Build #1021
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1021/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 185001 lines...] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12520633/1407-v5.txt [exec] against trunk revision 1307191. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1021//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1021//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1021//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 226N919VCq logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1568: exec returned: 2 Total time: 26 minutes 14 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1407 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242596#comment-13242596 ] Thomas Weise commented on ZOOKEEPER-1437: - Hi Eugene, Thanks for looking into it, I will test the patch later today. Can we get this fixed for 3.4.x? > Client uses session before SASL authentication complete > --- > > Key: ZOOKEEPER-1437 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.3 >Reporter: Thomas Weise >Assignee: Eugene Koontz > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch > > > Found issue in the context of hbase region server startup, but can be > reproduced w/ zkCli alone. > getData may occur prior to SaslAuthenticated and fail with NoAuth. This is > not expected behavior when the client is configured to use SASL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1437) Client uses session before SASL authentication complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Koontz updated ZOOKEEPER-1437: - Attachment: ZOOKEEPER-1437.patch Passes test-core-java. > Client uses session before SASL authentication complete > --- > > Key: ZOOKEEPER-1437 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.3 >Reporter: Thomas Weise >Assignee: Eugene Koontz > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch > > > Found issue in the context of hbase region server startup, but can be > reproduced w/ zkCli alone. > getData may occur prior to SaslAuthenticated and fail with NoAuth. This is > not expected behavior when the client is configured to use SASL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated ZOOKEEPER-1407: -- Attachment: 1407-v5.txt > Support GetData and GetChildren in Multi > > > Key: ZOOKEEPER-1407 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Zhihong Yu > Fix For: 3.5.0 > > Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt, > 1407.txt > > > There is use case where GetData and GetChildren would participate in Multi. > We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242578#comment-13242578
]
Zhihong Yu commented on ZOOKEEPER-1407:
---
With 1407-v5.txt, I see the following in test output:
{code}
2012-03-30 10:31:56,090 [myid:] - WARN
[main-SendThread(localhost:11221):ClientCnxn$SendThread@1061] - Session
0x13664a9dee20001 for server localhost/127.0.0.1:11221, unexpected error,
closing socket connection and attempting reconnect
java.io.IOException: Invalid type 256 in MultiResponse
at org.apache.zookeeper.MultiResponse.deserialize(MultiResponse.java:135)
at
org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:812)
at org.apache.zookeeper.ClientCnxnSocketNIO.doIO(ClientCnxnSocketNIO.java:94)
at
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:287)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1039)
{code}
> Support GetData and GetChildren in Multi
>
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt,
> 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1433) improve ZxidRolloverTest (test seems flakey)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242258#comment-13242258
]
Hudson commented on ZOOKEEPER-1433:
---
Integrated in ZooKeeper-trunk #1512 (See
[https://builds.apache.org/job/ZooKeeper-trunk/1512/])
ZOOKEEPER-1433. improve ZxidRolloverTest (test seems flakey) (phunt via
henryr) (Revision 1307191)
Result = SUCCESS
henry : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307191
Files :
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/ZxidRolloverTest.java
> improve ZxidRolloverTest (test seems flakey)
>
>
> Key: ZOOKEEPER-1433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1433
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
>Affects Versions: 3.3.5
>Reporter: Wing Yew Poon
>Assignee: Patrick Hunt
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1433.patch, ZOOKEEPER-1433_test.out
>
>
> In our jenkins job to run the ZooKeeper unit tests,
> org.apache.zookeeper.server.ZxidRolloverTest sometimes fails.
> E.g.,
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode
> = ConnectionLoss for /foo0
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:815)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:843)
> at
> org.apache.zookeeper.server.ZxidRolloverTest.checkNodes(ZxidRolloverTest.java:154)
> at
> org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart(ZxidRolloverTest.java:211)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
ZooKeeper_branch33_solaris - Build # 145 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch33_solaris/145/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 96750 lines...] [junit] 2012-03-30 07:01:58,922 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test3233405885421406982.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test3233405885421406982.junit.dir/version-2 [junit] 2012-03-30 07:01:58,922 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2012-03-30 07:01:58,923 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test3233405885421406982.junit.dir/version-2/snapshot.0 [junit] 2012-03-30 07:01:58,926 - INFO [main:FileTxnSnapLog@254] - Snapshotting: b [junit] 2012-03-30 07:01:58,927 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2012-03-30 07:01:58,928 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:47433 [junit] 2012-03-30 07:01:58,928 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:47433 [junit] 2012-03-30 07:01:58,929 - INFO [Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2012-03-30 07:01:58,929 - INFO [Thread-4:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:47433 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] 2012-03-30 07:01:58,931 - INFO [main:ClientBase@389] - STOPPING server [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2012-03-30 07:01:58,931 - INFO [ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop! [junit] 2012-03-30 07:01:58,931 - INFO [SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited! [junit] 2012-03-30 07:01:58,932 - INFO [main:FinalRequestProcessor@370] - shutdown of request processor complete [junit] 2012-03-30 07:01:58,932 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] ensureOnly:[] [junit] 2012-03-30 07:01:58,934 - INFO [main:ClientBase@382] - STARTING server [junit] 2012-03-30 07:01:58,934 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test3233405885421406982.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test3233405885421406982.junit.dir/version-2 [junit] 2012-03-30 07:01:58,935 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2012-03-30 07:01:58,936 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test3233405885421406982.junit.dir/version-2/snapshot.b [junit] 2012-03-30 07:01:58,938 - INFO [main:FileTxnSnapLog@254] - Snapshotting: b [junit] 2012-03-30 07:01:58,940 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2012-03-30 07:01:58,941 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:47435 [junit] 2012-03-30 07:01:58,941 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:47435 [junit] 2012-03-30 07:01:58,942 - INFO [Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2012-03-30 07:01:58,942 - INFO [Thread-5:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:47435 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2012-03-30 07:01:58,952 - INFO [main:Clien
