[jira] [Updated] (ZOOKEEPER-1615) minor typos in ZooKeeper Programmer's Guide web page
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Singh updated ZOOKEEPER-1615: Attachment: Chapter 1 Introduction To Alternative Dispute Resolution In Colorado.htm > minor typos in ZooKeeper Programmer's Guide web page > > > Key: ZOOKEEPER-1615 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1615 > Project: ZooKeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.4.5 >Reporter: Evan Zacks >Priority: Trivial > Labels: documentation > Attachments: Chapter 1 Introduction To Alternative Dispute Resolution > In Colorado.htm, ZOOKEEPER-1615.patch > > > There are some minor typos and misspellings in the Programmer's Guide web > page. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-1615 PreCommit Build #1325
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1615 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1325/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 271465 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12563625/ZOOKEEPER-1615.patch [exec] against trunk revision 1427034. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +0 tests included. The patch appears to be a documentation patch that doesn't require tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1325//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1325//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1325//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 4d33f1e4ca58460d4b8636d8a3e27e4e0a3f474c logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 28 minutes 1 second Archiving artifacts Recording test results Description set: ZOOKEEPER-1615 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1615) minor typos in ZooKeeper Programmer's Guide web page
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546806#comment-13546806 ] Hadoop QA commented on ZOOKEEPER-1615: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563625/ZOOKEEPER-1615.patch against trunk revision 1427034. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1325//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1325//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1325//console This message is automatically generated. > minor typos in ZooKeeper Programmer's Guide web page > > > Key: ZOOKEEPER-1615 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1615 > Project: ZooKeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.4.5 >Reporter: Evan Zacks >Priority: Trivial > Labels: documentation > Attachments: Chapter 1 Introduction To Alternative Dispute Resolution > In Colorado.htm, ZOOKEEPER-1615.patch > > > There are some minor typos and misspellings in the Programmer's Guide web > page. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-1324 PreCommit Build #1326
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1324 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1326/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by remote host 127.0.0.1 Building remotely on hadoop9 in workspace /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build Reverting /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk Updating http://svn.apache.org/repos/asf/zookeeper/trunk At revision 1430279 no change for http://svn.apache.org/repos/asf/zookeeper/trunk since the previous build No emails were triggered. [PreCommit-ZOOKEEPER-Build] $ /bin/bash /tmp/hudson1618189021974179168.sh /home/jenkins/tools/java/latest/bin/java Buildfile: build.xml check-for-findbugs: findbugs.check: forrest.check: hudson-test-patch: [exec] [exec] [exec] == [exec] == [exec] Testing patch for ZOOKEEPER-1324. [exec] == [exec] == [exec] [exec] [exec] At revision 1430279. [exec] ZOOKEEPER-1324 is not "Patch Available". Exiting. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 1 second Archiving artifacts ERROR: No artifacts found that match the file pattern "trunk/build/test/findbugs/newPatchFindbugsWarnings.html,trunk/patchprocess/*.txt,trunk/patchprocess/*Warnings.xml,trunk/build/test/test-cppunit/*.txt,trunk/build/tmp/zk.log". Configuration error? ERROR: 'trunk/build/test/findbugs/newPatchFindbugsWarnings.html' doesn't match anything: 'trunk' exists but not 'trunk/build/test/findbugs/newPatchFindbugsWarnings.html' Build step 'Archive the artifacts' changed build result to FAILURE Recording test results Description set: ZOOKEEPER-1324 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Updated] (ZOOKEEPER-1324) Remove Duplicate NEWLEADER packets from the Leader to the Follower.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-1324: Attachment: ZOOKEEPER-1324.patch What about this change? I still need to clean up the patch, so it is not final yet, but the change I'm proposing can be reviewed. > Remove Duplicate NEWLEADER packets from the Leader to the Follower. > --- > > Key: ZOOKEEPER-1324 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324 > Project: ZooKeeper > Issue Type: Bug >Reporter: Mahadev konar >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1324) Remove Duplicate NEWLEADER packets from the Leader to the Follower.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547301#comment-13547301 ] Thawan Kooburat commented on ZOOKEEPER-1324: I understand the fact that you want to treat NEWLEADER like another proposal and reuse existing facility to handle it. However, treating this like a normal proposal also comes with some issues. 1. Currently procesAck() have to a special logic to handle NEWLEADER proposal, it need to start up ZK server 2. We are sending NEWLEADER proposal implicitly as part of sending outstanding proposals to the learners. Now you have to keep adding NEWLEADER back into outstanding proposals whenever a new learner joins the quorum since it is removed whenever NEWLEADER packet is committed. 3. There is no need to for observers to see outstanding proposals. This is minor optimization, but we don't send outstanding proposals to the observer in startForwarding() in our internal branch. If we really want to clean this up, I suggested that we do it another way around. I think queuing NEWLEADER packet into the packet queue explicitly make the code easier to follow. Additional, we may factor out NEWLEADER to use its own method for collecting the votes similar to waitForEpochAck(), so that we don't overload processAck() and outstanding proposals to do multiple things. Let me know what you think > Remove Duplicate NEWLEADER packets from the Leader to the Follower. > --- > > Key: ZOOKEEPER-1324 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324 > Project: ZooKeeper > Issue Type: Bug >Reporter: Mahadev konar >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1324) Remove Duplicate NEWLEADER packets from the Leader to the Follower.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547355#comment-13547355 ] Flavio Junqueira commented on ZOOKEEPER-1324: - Having a different method for collecting the ack and not overloading processAck sounds great. On adding NEWLEADER to the packet queue, I need a confirmation to make sure I understand your proposal. I think you're suggesting that we replace adding a new leader proposal to outstandingProposals in #lead() with a barrier method that waits for enough acks to return, but we keep adding NEWLEADER to the queue in LearnerHandler as we have today. > Remove Duplicate NEWLEADER packets from the Leader to the Follower. > --- > > Key: ZOOKEEPER-1324 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324 > Project: ZooKeeper > Issue Type: Bug >Reporter: Mahadev konar >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (ZOOKEEPER-1616) time calculations should use a monotonic clock
Todd Lipcon created ZOOKEEPER-1616: -- Summary: time calculations should use a monotonic clock Key: ZOOKEEPER-1616 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1616 Project: ZooKeeper Issue Type: Bug Reporter: Todd Lipcon We recently had an issue with ZooKeeper sessions acting strangely due to a bad NTP setup on a set of hosts. Looking at the code, ZK seems to use System.currentTimeMillis to measure durations or intervals in many places. This is bad since that time can move backwards or skip ahead by several minutes. Instead, it should use System.nanoTime (or a wrapper such as Guava's Stopwatch class) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1616) time calculations should use a monotonic clock
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547589#comment-13547589
]
liang xie commented on ZOOKEEPER-1616:
--
Cl, [~tlipcon]
One thing need to explain is that the implement of currentTimeMillis&nanoTime
is affected by lower OS version as well，so the good proposal will benefit newer
OS only. Here is the code snappiet from hs20 just for reference :
{code}
jlong os::javaTimeNanos() {
if (Linux::supports_monotonic_clock()) {
struct timespec tp;
int status = Linux::clock_gettime(CLOCK_MONOTONIC, &tp);
assert(status == 0, "gettime error");
jlong result = jlong(tp.tv_sec) * (1000 * 1000 * 1000) + jlong(tp.tv_nsec);
return result;
} else {
timeval time;
int status = gettimeofday(&time, NULL);
assert(status != -1, "linux error");
jlong usecs = jlong(time.tv_sec) * (1000 * 1000) + jlong(time.tv_usec);
return 1000 * usecs;
}
}
jlong os::javaTimeMillis() {
timeval time;
int status = gettimeofday(&time, NULL);
assert(status != -1, "linux error");
return jlong(time.tv_sec) * 1000 + jlong(time.tv_usec / 1000);
}
{code}
> time calculations should use a monotonic clock
> --
>
> Key: ZOOKEEPER-1616
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1616
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Todd Lipcon
>
> We recently had an issue with ZooKeeper sessions acting strangely due to a
> bad NTP setup on a set of hosts. Looking at the code, ZK seems to use
> System.currentTimeMillis to measure durations or intervals in many places.
> This is bad since that time can move backwards or skip ahead by several
> minutes. Instead, it should use System.nanoTime (or a wrapper such as Guava's
> Stopwatch class)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated ZOOKEEPER-1423: -- Attachment: ZOOKEEPER-1423.patch Hi folks, I am sending a *first* version of a patch to address this issue. I am aware that it should probably be rewritten to be in sync with ZOOKEEPER-1346, but I hope you have time to evaluate it and see if it's okay to include in 3.5. Any suggestion/correction is welcome. Cheers, E. > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Reporter: Patrick Hunt > Labels: newbie > Attachments: ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1616) time calculations should use a monotonic clock
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547649#comment-13547649 ] Ted Dunning commented on ZOOKEEPER-1616: Uh... I thought we patched this ages ago. See ZOOKEEPER-1366 > time calculations should use a monotonic clock > -- > > Key: ZOOKEEPER-1616 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1616 > Project: ZooKeeper > Issue Type: Bug >Reporter: Todd Lipcon > > We recently had an issue with ZooKeeper sessions acting strangely due to a > bad NTP setup on a set of hosts. Looking at the code, ZK seems to use > System.currentTimeMillis to measure durations or intervals in many places. > This is bad since that time can move backwards or skip ahead by several > minutes. Instead, it should use System.nanoTime (or a wrapper such as Guava's > Stopwatch class) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1616) time calculations should use a monotonic clock
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547651#comment-13547651 ] Ted Dunning commented on ZOOKEEPER-1616: Todd, Can you fill in the versions for which you observed this problem? > time calculations should use a monotonic clock > -- > > Key: ZOOKEEPER-1616 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1616 > Project: ZooKeeper > Issue Type: Bug >Reporter: Todd Lipcon > > We recently had an issue with ZooKeeper sessions acting strangely due to a > bad NTP setup on a set of hosts. Looking at the code, ZK seems to use > System.currentTimeMillis to measure durations or intervals in many places. > This is bad since that time can move backwards or skip ahead by several > minutes. Instead, it should use System.nanoTime (or a wrapper such as Guava's > Stopwatch class) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated ZOOKEEPER-1423: -- Attachment: ZOOKEEPER-1423.patch > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Reporter: Patrick Hunt > Labels: newbie > Attachments: ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated ZOOKEEPER-1423: -- Attachment: (was: ZOOKEEPER-1423.patch) > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Reporter: Patrick Hunt > Labels: newbie > Attachments: ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1615) minor typos in ZooKeeper Programmer's Guide web page
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Singh updated ZOOKEEPER-1615: Attachment: (was: Chapter 1 Introduction To Alternative Dispute Resolution In Colorado.htm) > minor typos in ZooKeeper Programmer's Guide web page > > > Key: ZOOKEEPER-1615 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1615 > Project: ZooKeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.4.5 >Reporter: Evan Zacks >Priority: Trivial > Labels: documentation > Attachments: ZOOKEEPER-1615.patch > > > There are some minor typos and misspellings in the Programmer's Guide web > page. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1616) time calculations should use a monotonic clock
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547731#comment-13547731 ] Marshall McMullen commented on ZOOKEEPER-1616: -- Ted, ZOOKEEPER-1366 was never committed. > time calculations should use a monotonic clock > -- > > Key: ZOOKEEPER-1616 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1616 > Project: ZooKeeper > Issue Type: Bug >Reporter: Todd Lipcon > > We recently had an issue with ZooKeeper sessions acting strangely due to a > bad NTP setup on a set of hosts. Looking at the code, ZK seems to use > System.currentTimeMillis to measure durations or intervals in many places. > This is bad since that time can move backwards or skip ahead by several > minutes. Instead, it should use System.nanoTime (or a wrapper such as Guava's > Stopwatch class) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
