[jira] [Updated] (ZOOKEEPER-1696) Fail to run zookeeper client on Weblogic application server
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeffrey Zhong updated ZOOKEEPER-1696:
-
Attachment: zookeeper-1696.patch
Since there is no reliable way to determine if SASL setting is set, the patch
catches RuntimeException to see if SASL setting is configured. Please let me
know if there is any better way.
> Fail to run zookeeper client on Weblogic application server
> ---
>
> Key: ZOOKEEPER-1696
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1696
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.4.5
> Environment: Java version: jdk170_06
> WebLogic Server Version: 10.3.6.0
>Reporter: Dmitry Konstantinov
>Priority: Critical
> Attachments: zookeeper-1696.patch
>
>
> The problem in details is described here:
> http://comments.gmane.org/gmane.comp.java.zookeeper.user/2897
> The provided link also contains a reference to fix implementation.
> {noformat}
>
> <[ACTIVE] ExecuteThread: '2' for queue:
> 'weblogic.kernel.Default (devapp090:2182)> <> <> <1366794208810>
> null, unexpected error, closing socket connection and attempting reconnect
> java.lang.IllegalArgumentException: No Configuration was registered that can
> handle the configuration named Client
> at
> com.bea.common.security.jdkutils.JAASConfiguration.getAppConfigurationEntry(JAASConfiguration.java:130)
> at
> org.apache.zookeeper.client.ZooKeeperSaslClient.(ZooKeeperSaslClient.java:97)
> at
> org.apache.zookeeper.ClientCnxn$SendThread.startConnect(ClientCnxn.java:943)
> at
> org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:993)
> >
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1607) Read-only Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735392#comment-13735392 ] Hadoop QA commented on ZOOKEEPER-1607: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12597187/0001-RFC-Don-t-tear-down-an-Observer-when-we-lose-connect.patch against trunk revision 1503101. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1532//console This message is automatically generated. > Read-only Observer > -- > > Key: ZOOKEEPER-1607 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1607 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat > Attachments: > 0001-RFC-Don-t-tear-down-an-Observer-when-we-lose-connect.patch > > > This feature reused some of the mechanism already provided by > ReadOnlyZooKeeper (ZOOKEEPER-704) but implemented in a different way > Goal: read-only clients should be able to connect to the observer or continue > to read data from the observer event when there is an outage of underling > quorum. This means that it is possible for the observer to provide 100% read > uptime for read-only local session (ZOOKEEPER-1147) > Implementation: > The observer don't tear down itself when it lose connection with the leader. > It only close the connection associated with non read-only sessions and > global sessions. So the client can try other observer if this is a temporal > failure. > During the outage, the observer switch to read-only mode. All the pending and > future write requests get will get NOT_READONLY error. Read-only state > transition is sent to all session on that observer. The observer only accepts > a new connection from a read-only client. > When the observer is able to reconnect to the leader. It sends state > transition (CONNECTED_STATE) to all current session. If it is able to > synchronize with the leader using DIFF, the steam of txns is sent through the > commit processor instead of applying to the DataTree directly to prevent > raise condition between in-flight read requests (see ZOOKEEPER-1505). The > client will receive watch events correctly and can start issuing write > requests. > However, if the observer is getting the snapshot. It need to drop all the > connection since it cannot fire a watch correctly. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-1607 PreCommit Build #1532
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1607 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1532/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 116 lines...] [exec] patching file b/src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java [exec] Hunk #1 FAILED at 86. [exec] Hunk #2 FAILED at 110. [exec] 2 out of 2 hunks FAILED -- saving rejects to file b/src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java.rej [exec] patching file b/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java [exec] Hunk #1 FAILED at 754. [exec] Hunk #2 FAILED at 931. [exec] 2 out of 2 hunks FAILED -- saving rejects to file b/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java.rej [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12597187/0001-RFC-Don-t-tear-down-an-Observer-when-we-lose-connect.patch [exec] against trunk revision 1503101. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1532//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 260ec7d19392af057e8483fdb6899901fb6fe77a logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 59 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1607 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Updated] (ZOOKEEPER-1607) Read-only Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1607: -- Attachment: 0001-RFC-Don-t-tear-down-an-Observer-when-we-lose-connect.patch > Read-only Observer > -- > > Key: ZOOKEEPER-1607 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1607 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat > Attachments: > 0001-RFC-Don-t-tear-down-an-Observer-when-we-lose-connect.patch > > > This feature reused some of the mechanism already provided by > ReadOnlyZooKeeper (ZOOKEEPER-704) but implemented in a different way > Goal: read-only clients should be able to connect to the observer or continue > to read data from the observer event when there is an outage of underling > quorum. This means that it is possible for the observer to provide 100% read > uptime for read-only local session (ZOOKEEPER-1147) > Implementation: > The observer don't tear down itself when it lose connection with the leader. > It only close the connection associated with non read-only sessions and > global sessions. So the client can try other observer if this is a temporal > failure. > During the outage, the observer switch to read-only mode. All the pending and > future write requests get will get NOT_READONLY error. Read-only state > transition is sent to all session on that observer. The observer only accepts > a new connection from a read-only client. > When the observer is able to reconnect to the leader. It sends state > transition (CONNECTED_STATE) to all current session. If it is able to > synchronize with the leader using DIFF, the steam of txns is sent through the > commit processor instead of applying to the DataTree directly to prevent > raise condition between in-flight read requests (see ZOOKEEPER-1505). The > client will receive watch events correctly and can start issuing write > requests. > However, if the observer is getting the snapshot. It need to drop all the > connection since it cannot fire a watch correctly. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-87) Follower does not shut itself down if its too far behind the leader.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735134#comment-13735134 ] Hadoop QA commented on ZOOKEEPER-87: -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12597127/ZOOKEEPER-87_trunk.patch against trunk revision 1503101. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1531//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1531//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1531//console This message is automatically generated. > Follower does not shut itself down if its too far behind the leader. > > > Key: ZOOKEEPER-87 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-87 > Project: ZooKeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.5.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Critical > Labels: patch > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-87_trunk.patch > > > Currently, the follower if lagging behind keeps sending pings to the leader > it will stay alive and will keep getting further and further behind the > leader. The follower should shut itself down if it is not able to keep up to > the leader within some limit so that gurantee of updates can be made to the > clients connected to different servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-87 PreCommit Build #1531
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-87 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1531/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 288922 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12597127/ZOOKEEPER-87_trunk.patch [exec] against trunk revision 1503101. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 4 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1531//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1531//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1531//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 2e65bb983d55b0f60a44450344143befac70f8ab logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 26 minutes 18 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-87 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.server.quorum.Zab1_0Test.testNoPingWithinTxns Error Message: expected:<10> but was:<12> Stack Trace: junit.framework.AssertionFailedError: expected:<10> but was:<12> at org.apache.zookeeper.server.quorum.Zab1_0Test$6.converseWithLeader(Zab1_0Test.java:880) at org.apache.zookeeper.server.quorum.Zab1_0Test.testLeaderConversation(Zab1_0Test.java:365) at org.apache.zookeeper.server.quorum.Zab1_0Test.testNoPingWithinTxns(Zab1_0Test.java:842)
[jira] [Commented] (ZOOKEEPER-87) Follower does not shut itself down if its too far behind the leader.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735080#comment-13735080 ] Germán Blanco commented on ZOOKEEPER-87: I have updated the patch to the current trunk version. Any comments on the proposal? > Follower does not shut itself down if its too far behind the leader. > > > Key: ZOOKEEPER-87 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-87 > Project: ZooKeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.5.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Critical > Labels: patch > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-87_trunk.patch > > > Currently, the follower if lagging behind keeps sending pings to the leader > it will stay alive and will keep getting further and further behind the > leader. The follower should shut itself down if it is not able to keep up to > the leader within some limit so that gurantee of updates can be made to the > clients connected to different servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-87) Follower does not shut itself down if its too far behind the leader.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-87: --- Attachment: ZOOKEEPER-87_trunk.patch > Follower does not shut itself down if its too far behind the leader. > > > Key: ZOOKEEPER-87 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-87 > Project: ZooKeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.5.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Critical > Labels: patch > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-87_trunk.patch > > > Currently, the follower if lagging behind keeps sending pings to the leader > it will stay alive and will keep getting further and further behind the > leader. The follower should shut itself down if it is not able to keep up to > the leader within some limit so that gurantee of updates can be made to the > clients connected to different servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-4680 PreCommit Build #1530
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-4680 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1530/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by remote host 127.0.0.1 Building remotely on hadoop8 in workspace /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build Reverting /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk to depth infinity with ignoreExternals: false Updating http://svn.apache.org/repos/asf/zookeeper/trunk at revision '2013-08-09T17:52:01.489 +' At revision 1512418 no change for http://svn.apache.org/repos/asf/zookeeper/trunk since the previous build No emails were triggered. [PreCommit-ZOOKEEPER-Build] $ /bin/bash /tmp/hudson1235675386137714459.sh /home/jenkins/tools/java/latest/bin/java Buildfile: build.xml check-for-findbugs: findbugs.check: forrest.check: hudson-test-patch: [exec] [exec] [exec] == [exec] == [exec] Testing patch for ZOOKEEPER-4680. [exec] == [exec] == [exec] [exec] [exec] At revision 1512418. [exec] ZOOKEEPER-4680 is not "Patch Available". Exiting. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 2 seconds Archiving artifacts ERROR: No artifacts found that match the file pattern "trunk/build/test/findbugs/newPatchFindbugsWarnings.html,trunk/patchprocess/*.txt,trunk/patchprocess/*Warnings.xml,trunk/build/test/test-cppunit/*.txt,trunk/build/tmp/zk.log". Configuration error? ERROR: ?trunk/build/test/findbugs/newPatchFindbugsWarnings.html? doesn?t match anything: ?trunk? exists but not ?trunk/build/test/findbugs/newPatchFindbugsWarnings.html? Build step 'Archive the artifacts' changed build result to FAILURE Recording test results Description set: ZOOKEEPER-4680 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Updated] (ZOOKEEPER-87) Follower does not shut itself down if its too far behind the leader.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-87: --- Attachment: (was: ZOOKEEPER-87.patch) > Follower does not shut itself down if its too far behind the leader. > > > Key: ZOOKEEPER-87 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-87 > Project: ZooKeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.5.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Critical > Labels: patch > Fix For: 3.5.0 > > > Currently, the follower if lagging behind keeps sending pings to the leader > it will stay alive and will keep getting further and further behind the > leader. The follower should shut itself down if it is not able to keep up to > the leader within some limit so that gurantee of updates can be made to the > clients connected to different servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-87) Follower does not shut itself down if its too far behind the leader.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-87: --- Attachment: (was: ZOOKEEPER-87.patch) > Follower does not shut itself down if its too far behind the leader. > > > Key: ZOOKEEPER-87 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-87 > Project: ZooKeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.5.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Critical > Labels: patch > Fix For: 3.5.0 > > > Currently, the follower if lagging behind keeps sending pings to the leader > it will stay alive and will keep getting further and further behind the > leader. The follower should shut itself down if it is not able to keep up to > the leader within some limit so that gurantee of updates can be made to the > clients connected to different servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
ZooKeeper-trunk-WinVS2008 - Build # 980 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/980/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 516 lines...] .\src\cli.c(402): error C2065: 'p' : undeclared identifier .\src\cli.c(403): error C2065: 'p' : undeclared identifier .\src\cli.c(404): error C2065: 'p' : undeclared identifier .\src\cli.c(405): error C2065: 'mode' : undeclared identifier .\src\cli.c(405): error C2065: 'p' : undeclared identifier .\src\cli.c(406): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(409): error C2065: 'mode' : undeclared identifier .\src\cli.c(410): error C2275: 'FILE' : illegal use of this type as an expression .\src\cli.c(410): error C2065: 'fp' : undeclared identifier .\src\cli.c(410): error C2065: 'p' : undeclared identifier .\src\cli.c(411): error C2065: 'fp' : undeclared identifier .\src\cli.c(412): error C2065: 'p' : undeclared identifier .\src\cli.c(413): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(416): error C2065: 'fp' : undeclared identifier .\src\cli.c(417): error C2065: 'members_size' : undeclared identifier .\src\cli.c(417): error C2065: 'fp' : undeclared identifier .\src\cli.c(418): error C2065: 'fp' : undeclared identifier .\src\cli.c(419): error C2065: 'members' : undeclared identifier .\src\cli.c(419): error C2065: 'members_size' : undeclared identifier .\src\cli.c(420): error C2065: 'members' : undeclared identifier .\src\cli.c(422): error C2065: 'p' : undeclared identifier .\src\cli.c(423): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(424): error C2065: 'fp' : undeclared identifier .\src\cli.c(434): error C2065: 'members' : undeclared identifier .\src\cli.c(434): error C2065: 'members_size' : undeclared identifier .\src\cli.c(434): error C2065: 'fp' : undeclared identifier .\src\cli.c(435): error C2065: 'p' : undeclared identifier .\src\cli.c(436): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(437): error C2065: 'fp' : undeclared identifier .\src\cli.c(440): error C2065: 'fp' : undeclared identifier .\src\cli.c(441): error C2065: 'p' : undeclared identifier .\src\cli.c(442): error C2065: 'p' : undeclared identifier .\src\cli.c(443): error C2065: 'version' : undeclared identifier .\src\cli.c(443): error C2065: 'p' : undeclared identifier .\src\cli.c(444): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(447): error C2065: 'version' : undeclared identifier .\src\cli.c(447): error C2065: 'p' : undeclared identifier .\src\cli.c(448): error C2065: 'version' : undeclared identifier .\src\cli.c(449): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(453): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(456): error C2065: 'p' : undeclared identifier .\src\cli.c(458): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(460): error C2065: 'joining' : undeclared identifier .\src\cli.c(460): error C2065: 'leaving' : undeclared identifier .\src\cli.c(460): error C2065: 'members' : undeclared identifier .\src\cli.c(460): error C2065: 'version' : undeclared identifier .\src\cli.c(461): error C2065: 'joining' : undeclared identifier .\src\cli.c(462): error C2065: 'leaving' : undeclared identifier .\src\cli.c(463): error C2065: 'members' : undeclared identifier 104 Warning(s) 102 Error(s) Time Elapsed 00:00:08.36 f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008>exit 1 Build step 'Execute Windows batch command' marked build as failure Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Updated] (ZOOKEEPER-1739) thread safe bug in FastLeaderElection: instance of WorkerSender is not safe published, WorkerSender thread may see that WorkerSender.manager is the default value null
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Junqueira updated ZOOKEEPER-1739:
Assignee: qingjie qiao
> thread safe bug in FastLeaderElection: instance of WorkerSender is not safe
> published, WorkerSender thread may see that WorkerSender.manager is the
> default value null
> --
>
> Key: ZOOKEEPER-1739
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1739
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
>Affects Versions: 3.4.5
>Reporter: qingjie qiao
>Assignee: qingjie qiao
>Priority: Minor
>
> I am reading the trunk source code recently and find a thread-safe problem,
> but i'm not quite sure.
> in FastLeaderElection:
> {code}
> class WorkerSender implements Runnable {
> volatile boolean stop;
> QuorumCnxManager manager;
> WorkerSender(QuorumCnxManager manager){
> this.stop = false;
> this.manager = manager;
> }
> public void run() {
> ...
> }
> }
> ...
> Messenger(QuorumCnxManager manager) {
> this.ws = new WorkerSender(manager);
> Thread t = new Thread(this.ws,
> "WorkerSender[myid=" + self.getId() + "]");
> t.setDaemon(true);
> t.start();
> this.wr = new WorkerReceiver(manager);
> t = new Thread(this.wr,
> "WorkerReceiver[myid=" + self.getId() + "]");
> t.setDaemon(true);
> t.start();
> }
> ...
> {code}
> The instance of WorkerSender is constructed in main thread, and its field
> manager is assigned , and it is used in another thread. The later thread may
> see that WorkerSender.manager is the default value null. The solution may be:
> (1) change
> {code}
> WorkerSender(QuorumCnxManager manager){
> this.stop = false;
> this.manager = manager;
> }
> {code}
> to
> {code}
> WorkerSender(QuorumCnxManager manager){
> this.manager = manager;
> this.stop = false;
> }
> {code}
> or(2)
> change
> {code}
> QuorumCnxManager manager;
> {code}
> to
> {code}
> final QuorumCnxManager manager;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1739) thread safe bug in FastLeaderElection: instance of WorkerSender is not safe published, WorkerSender thread may see that WorkerSender.manager is the default value nu
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734659#comment-13734659
]
Flavio Junqueira commented on ZOOKEEPER-1739:
-
I'm a bit behind with my reviews, but this change seems trivial. Could you
propose a patch, [~qiaoqingjie]?
> thread safe bug in FastLeaderElection: instance of WorkerSender is not safe
> published, WorkerSender thread may see that WorkerSender.manager is the
> default value null
> --
>
> Key: ZOOKEEPER-1739
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1739
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
>Affects Versions: 3.4.5
>Reporter: qingjie qiao
>Priority: Minor
>
> I am reading the trunk source code recently and find a thread-safe problem,
> but i'm not quite sure.
> in FastLeaderElection:
> {code}
> class WorkerSender implements Runnable {
> volatile boolean stop;
> QuorumCnxManager manager;
> WorkerSender(QuorumCnxManager manager){
> this.stop = false;
> this.manager = manager;
> }
> public void run() {
> ...
> }
> }
> ...
> Messenger(QuorumCnxManager manager) {
> this.ws = new WorkerSender(manager);
> Thread t = new Thread(this.ws,
> "WorkerSender[myid=" + self.getId() + "]");
> t.setDaemon(true);
> t.start();
> this.wr = new WorkerReceiver(manager);
> t = new Thread(this.wr,
> "WorkerReceiver[myid=" + self.getId() + "]");
> t.setDaemon(true);
> t.start();
> }
> ...
> {code}
> The instance of WorkerSender is constructed in main thread, and its field
> manager is assigned , and it is used in another thread. The later thread may
> see that WorkerSender.manager is the default value null. The solution may be:
> (1) change
> {code}
> WorkerSender(QuorumCnxManager manager){
> this.stop = false;
> this.manager = manager;
> }
> {code}
> to
> {code}
> WorkerSender(QuorumCnxManager manager){
> this.manager = manager;
> this.stop = false;
> }
> {code}
> or(2)
> change
> {code}
> QuorumCnxManager manager;
> {code}
> to
> {code}
> final QuorumCnxManager manager;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1739) thread safe bug in FastLeaderElection: instance of WorkerSender is not safe published, WorkerSender thread may see that WorkerSender.manager is the default value null
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Junqueira updated ZOOKEEPER-1739:
Description:
I am reading the trunk source code recently and find a thread-safe problem, but
i'm not quite sure.
in FastLeaderElection:
{code}
class WorkerSender implements Runnable {
volatile boolean stop;
QuorumCnxManager manager;
WorkerSender(QuorumCnxManager manager){
this.stop = false;
this.manager = manager;
}
public void run() {
...
}
}
...
Messenger(QuorumCnxManager manager) {
this.ws = new WorkerSender(manager);
Thread t = new Thread(this.ws,
"WorkerSender[myid=" + self.getId() + "]");
t.setDaemon(true);
t.start();
this.wr = new WorkerReceiver(manager);
t = new Thread(this.wr,
"WorkerReceiver[myid=" + self.getId() + "]");
t.setDaemon(true);
t.start();
}
...
{code}
The instance of WorkerSender is constructed in main thread, and its field
manager is assigned , and it is used in another thread. The later thread may
see that WorkerSender.manager is the default value null. The solution may be:
(1) change
{code}
WorkerSender(QuorumCnxManager manager){
this.stop = false;
this.manager = manager;
}
{code}
to
{code}
WorkerSender(QuorumCnxManager manager){
this.manager = manager;
this.stop = false;
}
{code}
or(2)
change
{code}
QuorumCnxManager manager;
{code}
to
{code}
final QuorumCnxManager manager;
{code}
was:
I am reading the trunk source code recently and find a thread-safe problem, but
i'm not quite sure.
in FastLeaderElection:
class WorkerSender implements Runnable {
volatile boolean stop;
QuorumCnxManager manager;
WorkerSender(QuorumCnxManager manager){
this.stop = false;
this.manager = manager;
}
public void run() {
...
}
}
...
Messenger(QuorumCnxManager manager) {
this.ws = new WorkerSender(manager);
Thread t = new Thread(this.ws,
"WorkerSender[myid=" + self.getId() + "]");
t.setDaemon(true);
t.start();
this.wr = new WorkerReceiver(manager);
t = new Thread(this.wr,
"WorkerReceiver[myid=" + self.getId() + "]");
t.setDaemon(true);
t.start();
}
...
The instance of WorkerSender is constructed in main thread, and its field
manager is assigned , and it is used in another thread. The later thread may
see that WorkerSender.manager is the default value null. The solution may be:
(1) change
WorkerSender(QuorumCnxManager manager){
this.stop = false;
this.manager = manager;
}
to
WorkerSender(QuorumCnxManager manager){
this.manager = manager;
this.stop = false;
}
or(2)
change
QuorumCnxManager manager;
to
final QuorumCnxManager manager;
> thread safe bug in FastLeaderElection: instance of WorkerSender is not safe
> published, WorkerSender thread may see that WorkerSender.manager is the
> default value null
> --
>
> Key: ZOOKEEPER-1739
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1739
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
>Affects Versions: 3.4.5
>Reporter: qingjie qiao
>Priority: Minor
>
> I am reading the trunk source code recently and find a thread-safe problem,
> but i'm not quite sure.
> in FastLeaderElection:
> {code}
> class WorkerSender implements Runnable {
> volatile boolean stop;
> QuorumCnxManager manager;
> WorkerSender(QuorumCnxManager manager){
> this.stop = false;
> this.manager = manager;
> }
> public void run() {
> ...
> }
> }
> ...
> Messenger(QuorumCnxManager manager) {
> this.ws = new WorkerSender(manager);
> Thread t = new Thread(this.ws,
> "WorkerSender[myid=" + self.getId() + "]");
> t.setDaemon(true);
> t.start();
> this.wr = new WorkerReceiver(manager);
> t = new Thread(this.wr,
> "WorkerReceiver[myid=" + self.getId() + "]");
> t.setDaemon(true);
> t.start();
> }
> ...
> {code}
> The instance of WorkerSender is constructed in main thread, and its field
> manager is assigned , and it is used in another thread. The later thread may
> see that WorkerSender.manager is the default value null. The solution may be:
> (1) change
> {code}
> WorkerSender(QuorumCnxManager manager){
> this.stop = false;
> this.manager = manager;
> }
> {code}
> to
> {code}
> WorkerSender(QuorumCnxManager manager){
> this.manager = manager;
> this.stop = false;
> }
> {code}
> or(2)
> change
> {code}
> QuorumCnxManager manager;
>
ZooKeeper-trunk-solaris - Build # 636 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/636/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 195769 lines...] [junit] 2013-08-09 09:13:09,729 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2013-08-09 09:13:09,730 [myid:] - INFO [main:ZooKeeperServer@422] - shutting down [junit] 2013-08-09 09:13:09,730 [myid:] - INFO [main:SessionTrackerImpl@180] - Shutting down [junit] 2013-08-09 09:13:09,730 [myid:] - INFO [main:PrepRequestProcessor@929] - Shutting down [junit] 2013-08-09 09:13:09,731 [myid:] - INFO [main:SyncRequestProcessor@175] - Shutting down [junit] 2013-08-09 09:13:09,731 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop! [junit] 2013-08-09 09:13:09,731 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@155] - SyncRequestProcessor exited! [junit] 2013-08-09 09:13:09,731 [myid:] - INFO [main:FinalRequestProcessor@427] - shutdown of request processor complete [junit] 2013-08-09 09:13:09,732 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-08-09 09:13:09,732 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-08-09 09:13:09,733 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-08-09 09:13:09,734 [myid:] - INFO [main:ZooKeeperServer@149] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1163984737578486344.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1163984737578486344.junit.dir/version-2 [junit] 2013-08-09 09:13:09,734 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2013-08-09 09:13:09,735 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-08-09 09:13:09,736 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1163984737578486344.junit.dir/version-2/snapshot.b [junit] 2013-08-09 09:13:09,739 [myid:] - INFO [main:FileTxnSnapLog@297] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1163984737578486344.junit.dir/version-2/snapshot.b [junit] 2013-08-09 09:13:09,740 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-08-09 09:13:09,741 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:33438 [junit] 2013-08-09 09:13:09,742 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@829] - Processing stat command from /127.0.0.1:33438 [junit] 2013-08-09 09:13:09,742 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@678] - Stat command output [junit] 2013-08-09 09:13:09,743 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1000] - Closed socket connection for client /127.0.0.1:33438 (no session established for client) [junit] 2013-08-09 09:13:09,743 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-08-09 09:13:09,744 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-08-09 09:13:09,744 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-08-09 09:13:09,745 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-08-09 09:13:09,745 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-08-09 09:13:09,745 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-08-09 09:13:09,745 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-08-09 09:13:09,806 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down [junit] 2013-08-09 09:13:09,806 [myid:] - INFO [main:ZooKeeper@777] - Session: 0x1406259d459 closed [junit] 2013-08-09 09:13:09,807 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-08-09 09:13:09,807 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$
ZooKeeper-trunk-WinVS2008 - Build # 979 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/979/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 514 lines...] .\src\cli.c(402): error C2065: 'p' : undeclared identifier .\src\cli.c(403): error C2065: 'p' : undeclared identifier .\src\cli.c(404): error C2065: 'p' : undeclared identifier .\src\cli.c(405): error C2065: 'mode' : undeclared identifier .\src\cli.c(405): error C2065: 'p' : undeclared identifier .\src\cli.c(406): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(409): error C2065: 'mode' : undeclared identifier .\src\cli.c(410): error C2275: 'FILE' : illegal use of this type as an expression .\src\cli.c(410): error C2065: 'fp' : undeclared identifier .\src\cli.c(410): error C2065: 'p' : undeclared identifier .\src\cli.c(411): error C2065: 'fp' : undeclared identifier .\src\cli.c(412): error C2065: 'p' : undeclared identifier .\src\cli.c(413): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(416): error C2065: 'fp' : undeclared identifier .\src\cli.c(417): error C2065: 'members_size' : undeclared identifier .\src\cli.c(417): error C2065: 'fp' : undeclared identifier .\src\cli.c(418): error C2065: 'fp' : undeclared identifier .\src\cli.c(419): error C2065: 'members' : undeclared identifier .\src\cli.c(419): error C2065: 'members_size' : undeclared identifier .\src\cli.c(420): error C2065: 'members' : undeclared identifier .\src\cli.c(422): error C2065: 'p' : undeclared identifier .\src\cli.c(423): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(424): error C2065: 'fp' : undeclared identifier .\src\cli.c(434): error C2065: 'members' : undeclared identifier .\src\cli.c(434): error C2065: 'members_size' : undeclared identifier .\src\cli.c(434): error C2065: 'fp' : undeclared identifier .\src\cli.c(435): error C2065: 'p' : undeclared identifier .\src\cli.c(436): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(437): error C2065: 'fp' : undeclared identifier .\src\cli.c(440): error C2065: 'fp' : undeclared identifier .\src\cli.c(441): error C2065: 'p' : undeclared identifier .\src\cli.c(442): error C2065: 'p' : undeclared identifier .\src\cli.c(443): error C2065: 'version' : undeclared identifier .\src\cli.c(443): error C2065: 'p' : undeclared identifier .\src\cli.c(444): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(447): error C2065: 'version' : undeclared identifier .\src\cli.c(447): error C2065: 'p' : undeclared identifier .\src\cli.c(448): error C2065: 'version' : undeclared identifier .\src\cli.c(449): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(453): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(456): error C2065: 'p' : undeclared identifier .\src\cli.c(458): error C2065: 'syntaxError' : undeclared identifier .\src\cli.c(460): error C2065: 'joining' : undeclared identifier .\src\cli.c(460): error C2065: 'leaving' : undeclared identifier .\src\cli.c(460): error C2065: 'members' : undeclared identifier .\src\cli.c(460): error C2065: 'version' : undeclared identifier .\src\cli.c(461): error C2065: 'joining' : undeclared identifier .\src\cli.c(462): error C2065: 'leaving' : undeclared identifier .\src\cli.c(463): error C2065: 'members' : undeclared identifier 104 Warning(s) 102 Error(s) Time Elapsed 00:00:11.15 f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008>exit 1 Build step 'Execute Windows batch command' marked build as failure Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
