[jira] [Commented] (ZOOKEEPER-1096) Leader communication should listen on specified IP, not wildcard address

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765846#comment-13765846
 ] 

Flavio Junqueira commented on ZOOKEEPER-1096:
-

Also, I don't understand this question:

bq. Would it make sense to have the java properties configuration value for 
leader election in 3.5.0?

Could you clarify, German, please?

> Leader communication should listen on specified IP, not wildcard address
> 
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.3, 3.4.0
>Reporter: Jared Cantwell
>Assignee: Jared Cantwell
>Priority: Minor
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1096_branch3.4.patch, ZOOKEEPER-1096.patch, 
> ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication 
> and leader election (and not use the default of listening on all interfaces). 
>  This is similar to the clientPortAddress parameter that was added a year 
> ago.  After reviewing the code, we can't think of a reason why only the port 
> would be used with the wildcard interface, when servers are already 
> connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election 
> algorithms.
> Probably should have an option to toggle this, for backwards compatibility, 
> although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=h2+7gnj_4p28hgcxjh345h...@mail.gmail.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Success: ZOOKEEPER-1657 PreCommit Build #1574

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1657
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1574/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 283195 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12602860/ZOOKEEPER-1657.patch
 [exec]   against trunk revision 1522079.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1574//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1574//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1574//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] ba18844fbac902409ebc9655787bf8847221c45c logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 31 minutes 11 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1657
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1657) Increased CPU usage by unnecessary SASL checks

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765862#comment-13765862
 ] 

Hadoop QA commented on ZOOKEEPER-1657:
--

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12602860/ZOOKEEPER-1657.patch
  against trunk revision 1522079.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1574//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1574//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1574//console

This message is automatically generated.

> Increased CPU usage by unnecessary SASL checks
> --
>
> Key: ZOOKEEPER-1657
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1657
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.5
>Reporter: Gunnar Wagenknecht
>Assignee: Philip K. Warren
>  Labels: performance
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1657.patch, ZOOKEEPER-1657.patch, 
> ZOOKEEPER-1657.patch, ZOOKEEPER-1657.patch, ZOOKEEPER-1657.patch, 
> ZOOKEEPER-1657.patch, zookeeper-hotspot-gone.png, zookeeper-hotspot.png
>
>
> I did some profiling in one of our Java environments and found an interesting 
> footprint in ZooKeeper. The SASL support seems to trigger a lot times on the 
> client although it's not even in use.
> Is there a switch to disable SASL completely?
> The attached screenshot shows a 10-minute profiling session on one of our 
> production Jetty servers. The Jetty server handles ~1k web requests per 
> minute. The average response time per web request is a few milli seconds. The 
> profiling was performed on a machine running for >24h. 
> We noticed a significant CPU increase on our servers when deploying an update 
> from ZooKeeper 3.3.2 to ZooKeeper 3.4.5. Thus, we started investigating. The 
> screenshot shows that only 32% CPU time are spent in Jetty. In contrast, 65% 
> are spend in ZooKeeper. 
> A few notes/thoughts:
> * {{ClientCnxn$SendThread.clientTunneledAuthenticationInProgress}} seems to 
> be the culprit
> * {{javax.security.auth.login.Configuration.getConfiguration}} seems to be 
> called very often?
> * There is quite a bit reflection involved in 
> {{java.security.AccessController.doPrivileged}}
> * No security manager is active in the JVM: I tend to place an if-check in 
> the code before calling {{AccessController.doPrivileged}}. When no SM is 
> installed, the runnable can be called directly which safes cycles.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1747) Zookeeper server fails to start if transaction log file is corrupted

[JIRA]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765496#comment-13765496
 ] 

Germán Blanco commented on ZOOKEEPER-1747:
--

Could this be a duplicate of ZOOKEEPER-1621?

> Zookeeper server fails to start if transaction log file is corrupted
> 
>
> Key: ZOOKEEPER-1747
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1747
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.5
> Environment: Solaris10/x86, Java 1.6
>Reporter: Sergey Maslyakov
>
> On multiple occasions when ZK was not able to write out a transaction log or 
> a snapshot file, the consequent attempt to restart the server fails. Usually 
> it happens when the underlying file system filled up; thus, preventing ZK 
> server from writing out consistent data file.
> Upon start-up, the server reads in the snapshot and the transaction log. If 
> the deserializer fails and throws an exception, server terminates. Please see 
> the stack trace below.
> Server not coming up for whatever reason is often an undesirable condition. 
> It would be nice to have an option to force-ignore parsing errors, 
> especially, in the transaction log. A check sum on the data could be a 
> possible solution to ensure the integrity and "parsability".
> Another robustness enhancement could be via proper handling of the condition 
> when snapshot or transaction log cannot be completely written to disk. 
> Basically, better handling of write errors.
> {noformat}
> 2013-08-28 12:05:30,732 ERROR [ZooKeeperServerMain] Unexpected exception, 
> exiting abnormally
> java.io.EOFException
> at java.io.DataInputStream.readInt(DataInputStream.java:375)
> at 
> org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63)
> at 
> org.apache.zookeeper.server.persistence.FileHeader.deserialize(FileHeader.java:64)
> at 
> org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.inStreamCreated(FileTxnLog.java:558)
> at 
> org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.createInputArchive(FileTxnLog.java:577)
> at 
> org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.goToNextLog(FileTxnLog.java:543)
> at 
> org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next(FileTxnLog.java:625)
> at 
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:160)
> at 
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223)
> at 
> org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:250)
> at 
> org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:383)
> at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFactory.java:122)
> at 
> org.apache.zookeeper.server.ZooKeeperServerMain.runFromConfig(ZooKeeperServerMain.java:112)
> at 
> org.apache.zookeeper.server.ZooKeeperServerMain.initializeAndRun(ZooKeeperServerMain.java:86)
> at 
> org.apache.zookeeper.server.ZooKeeperServerMain.main(ZooKeeperServerMain.java:52)
> at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:129)
> at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:78)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1096) Leader communication should listen on specified IP, not wildcard address

[JIRA]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766283#comment-13766283
 ] 

Germán Blanco commented on ZOOKEEPER-1096:
--

Thanks a lot for your comments Flavio!
bq. 1. Please add documentation.
I will as soon as I learn how to do it. If you could please point me to e.g. a 
paragraph that tells me how to do it or a JIRA that includes documentation that 
will make things faster, otherwise I will look for it.
bq. 2. Why are we using system properties and not the config file to set this 
up?
Because of my understanding of Patrick Hunt's comment above: 
[#comment-13137642]. But I don't mind to change it to the config file if that 
is better.
bq. 3. Please with parenthesis with if/else blocks, even if there is a single 
statement currently.
OK
bq. 4. I don't find it very elegant to catch an exception to determine that we 
need to return false. Also, I'd rather not catch a generic exception, but 
instead catch the precise exception we are expecting in the case the property 
is not there.
That is just copied from getSnapCount and getGlobalOutstandingLimit already 
there in the same class. I don't mind changing it, but then I guess it would 
make sense to change it also in the other two methods, right?
bq. Would it make sense to have the java properties configuration value for 
leader election in 3.5.0?
The feature of listening only on the configured IP address is present already 
for 3.5.0 in trunk, although only for the leader election port. However, in 
this case, there is no configuration option. That is, the server only listens 
on the IP that is in the configuration file and there is no way to set an 
option so that it listens on all IPs for that port which is what versions 3.4.5 
and before used to do. Should there be a configuration option to 
"listenOnAllIPs" for 3.5.0 as the patch proposes for branch 3.4?

> Leader communication should listen on specified IP, not wildcard address
> 
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.3, 3.4.0
>Reporter: Jared Cantwell
>Assignee: Jared Cantwell
>Priority: Minor
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1096_branch3.4.patch, ZOOKEEPER-1096.patch, 
> ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication 
> and leader election (and not use the default of listening on all interfaces). 
>  This is similar to the clientPortAddress parameter that was added a year 
> ago.  After reviewing the code, we can't think of a reason why only the port 
> would be used with the wildcard interface, when servers are already 
> connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election 
> algorithms.
> Probably should have an option to toggle this, for backwards compatibility, 
> although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=h2+7gnj_4p28hgcxjh345h...@mail.gmail.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1375) SendThread is exiting after OOMError

[Keith Turner (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765979#comment-13765979
 ] 

Keith Turner commented on ZOOKEEPER-1375:
-

The finally in the java code in my prev comment should probably be the 
following. Also the the second catch should use a different variable name for 
the exception.

{code:java}
   }finally{
  if(e instanceof Error)
throw (Error)e;
  //the other likely type is probably a RuntimeException, should this be 
rethrown?
   }
{code}

> SendThread is exiting after OOMError
> 
>
> Key: ZOOKEEPER-1375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1375
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.0
>Reporter: Rakesh R
>
> After reviewing the ClientCnxn code, there is still chances of exiting the 
> SendThread without intimating the users. Say if client throws OOMError and 
> entered into the throwable block. Here again while sending the Disconnected 
> event, its creating "new WatchedEvent()" object.This will throw OOMError and 
> leads to exit the SendThread without any Disconnected event notification.
> {noformat}
> try{
> //...
> } catch (Throwable e)
> {
> //..
> cleanup();
>if(state.isAlive()){
> eventThread.queueEvent(
> new WatchedEvent(Event.EventType.None, 
> Event.KeeperState.Disconnected, null) )
>}
>//
> }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

ZooKeeper_branch33_solaris - Build # 645 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch33_solaris/645/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 105581 lines...]
[junit] 2013-09-13 07:06:14,401 - INFO  [main:ZooKeeperServer@154] - 
Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test889463036050266244.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test889463036050266244.junit.dir/version-2
[junit] 2013-09-13 07:06:14,403 - INFO  [main:NIOServerCnxn$Factory@143] - 
binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-09-13 07:06:14,404 - INFO  [main:FileSnap@82] - Reading 
snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test889463036050266244.junit.dir/version-2/snapshot.0
[junit] 2013-09-13 07:06:14,408 - INFO  [main:FileTxnSnapLog@256] - 
Snapshotting: b
[junit] 2013-09-13 07:06:14,410 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] 2013-09-13 07:06:14,411 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - 
Accepted socket connection from /127.0.0.1:40773
[junit] 2013-09-13 07:06:14,412 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing 
stat command from /127.0.0.1:40773
[junit] 2013-09-13 07:06:14,413 - INFO  
[Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output
[junit] 2013-09-13 07:06:14,413 - INFO  [Thread-4:NIOServerCnxn@1435] - 
Closed socket connection for client /127.0.0.1:40773 (no session established 
for client)
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-09-13 07:06:14,415 - INFO  [main:ClientBase@408] - STOPPING 
server
[junit] 2013-09-13 07:06:14,417 - INFO  
[ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop!
[junit] 2013-09-13 07:06:14,417 - INFO  
[SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited!
[junit] 2013-09-13 07:06:14,418 - INFO  [main:FinalRequestProcessor@370] - 
shutdown of request processor complete
[junit] 2013-09-13 07:06:14,419 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] ensureOnly:[]
[junit] 2013-09-13 07:06:14,421 - INFO  [main:ClientBase@401] - STARTING 
server
[junit] 2013-09-13 07:06:14,422 - INFO  [main:ZooKeeperServer@154] - 
Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test889463036050266244.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test889463036050266244.junit.dir/version-2
[junit] 2013-09-13 07:06:14,423 - INFO  [main:NIOServerCnxn$Factory@143] - 
binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-09-13 07:06:14,424 - INFO  [main:FileSnap@82] - Reading 
snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test889463036050266244.junit.dir/version-2/snapshot.b
[junit] 2013-09-13 07:06:14,427 - INFO  [main:FileTxnSnapLog@256] - 
Snapshotting: b
[junit] 2013-09-13 07:06:14,429 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] 2013-09-13 07:06:14,430 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - 
Accepted socket connection from /127.0.0.1:40775
[junit] 2013-09-13 07:06:14,430 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing 
stat command from /127.0.0.1:40775
[junit] 2013-09-13 07:06:14,431 - INFO  
[Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output
[junit] 2013-09-13 07:06:14,432 - INFO  [Thread-5:NIOServerCnxn@1435] - 
Closed socket connection for client /127.0.0.1:40775 (no session established 
for client)
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-09-13 07:06:14,434 - INFO  [main:ClientBase

ZooKeeper-trunk-solaris - Build # 669 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/669/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 193939 lines...]
[junit] 2013-09-13 09:10:16,970 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2013-09-13 09:10:16,971 [myid:] - INFO  [main:ZooKeeperServer@422] 
- shutting down
[junit] 2013-09-13 09:10:16,971 [myid:] - INFO  
[main:SessionTrackerImpl@180] - Shutting down
[junit] 2013-09-13 09:10:16,971 [myid:] - INFO  
[main:PrepRequestProcessor@929] - Shutting down
[junit] 2013-09-13 09:10:16,971 [myid:] - INFO  
[main:SyncRequestProcessor@175] - Shutting down
[junit] 2013-09-13 09:10:16,972 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2013-09-13 09:10:16,972 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@155] - SyncRequestProcessor exited!
[junit] 2013-09-13 09:10:16,972 [myid:] - INFO  
[main:FinalRequestProcessor@427] - shutdown of request processor complete
[junit] 2013-09-13 09:10:16,973 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-09-13 09:10:16,973 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[]
[junit] 2013-09-13 09:10:16,974 [myid:] - INFO  [main:ClientBase@414] - 
STARTING server
[junit] 2013-09-13 09:10:16,974 [myid:] - INFO  [main:ZooKeeperServer@149] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7018923441486966596.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7018923441486966596.junit.dir/version-2
[junit] 2013-09-13 09:10:16,975 [myid:] - INFO  
[main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2013-09-13 09:10:16,975 [myid:] - INFO  
[main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-09-13 09:10:16,976 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7018923441486966596.junit.dir/version-2/snapshot.b
[junit] 2013-09-13 09:10:16,979 [myid:] - INFO  [main:FileTxnSnapLog@297] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7018923441486966596.junit.dir/version-2/snapshot.b
[junit] 2013-09-13 09:10:16,980 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-09-13 09:10:16,981 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:58279
[junit] 2013-09-13 09:10:16,982 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@828] - Processing stat command from 
/127.0.0.1:58279
[junit] 2013-09-13 09:10:16,982 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn$StatCommand@677] - Stat command output
[junit] 2013-09-13 09:10:16,982 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@999] - Closed socket connection for client 
/127.0.0.1:58279 (no session established for client)
[junit] 2013-09-13 09:10:16,982 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2013-09-13 09:10:16,984 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2013-09-13 09:10:16,984 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2013-09-13 09:10:16,984 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2013-09-13 09:10:16,984 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-09-13 09:10:16,985 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota
[junit] 2013-09-13 09:10:16,985 [myid:] - INFO  [main:ClientBase@451] - 
tearDown starting
[junit] 2013-09-13 09:10:17,060 [myid:] - INFO  [main:ZooKeeper@777] - 
Session: 0x1411695c7d8 closed
[junit] 2013-09-13 09:10:17,060 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down
[junit] 2013-09-13 09:10:17,061 [myid:] - INFO  [main:ClientBase@421] - 
STOPPING server
[junit] 2013-09-13 09:10:17,061 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$Selec

ZooKeeper_branch33 - Build # 1073 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch33/1073/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 116167 lines...]
[junit] 2013-09-13 10:07:09,788 - INFO  [main:ZooKeeperServer@154] - 
Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7847762035647152281.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7847762035647152281.junit.dir/version-2
[junit] 2013-09-13 10:07:09,789 - INFO  [main:NIOServerCnxn$Factory@143] - 
binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-09-13 10:07:09,790 - INFO  [main:FileSnap@82] - Reading 
snapshot 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7847762035647152281.junit.dir/version-2/snapshot.0
[junit] 2013-09-13 10:07:09,794 - INFO  [main:FileTxnSnapLog@256] - 
Snapshotting: b
[junit] 2013-09-13 10:07:09,796 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] 2013-09-13 10:07:09,796 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - 
Accepted socket connection from /127.0.0.1:47661
[junit] 2013-09-13 10:07:09,797 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing 
stat command from /127.0.0.1:47661
[junit] 2013-09-13 10:07:09,797 - INFO  
[Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output
[junit] 2013-09-13 10:07:09,798 - INFO  [Thread-4:NIOServerCnxn@1435] - 
Closed socket connection for client /127.0.0.1:47661 (no session established 
for client)
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-09-13 10:07:09,800 - INFO  [main:ClientBase@408] - STOPPING 
server
[junit] 2013-09-13 10:07:09,800 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@278] - 
NIOServerCnxn factory exited run method
[junit] 2013-09-13 10:07:09,801 - INFO  
[ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop!
[junit] 2013-09-13 10:07:09,801 - INFO  
[SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited!
[junit] 2013-09-13 10:07:09,801 - INFO  [main:FinalRequestProcessor@370] - 
shutdown of request processor complete
[junit] 2013-09-13 10:07:09,802 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] ensureOnly:[]
[junit] 2013-09-13 10:07:09,804 - INFO  [main:ClientBase@401] - STARTING 
server
[junit] 2013-09-13 10:07:09,804 - INFO  [main:ZooKeeperServer@154] - 
Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7847762035647152281.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7847762035647152281.junit.dir/version-2
[junit] 2013-09-13 10:07:09,805 - INFO  [main:NIOServerCnxn$Factory@143] - 
binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-09-13 10:07:09,806 - INFO  [main:FileSnap@82] - Reading 
snapshot 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7847762035647152281.junit.dir/version-2/snapshot.b
[junit] 2013-09-13 10:07:09,809 - INFO  [main:FileTxnSnapLog@256] - 
Snapshotting: b
[junit] 2013-09-13 10:07:09,811 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] 2013-09-13 10:07:09,811 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - 
Accepted socket connection from /127.0.0.1:47663
[junit] 2013-09-13 10:07:09,812 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing 
stat command from /127.0.0.1:47663
[junit] 2013-09-13 10:07:09,812 - INFO  
[Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output
[junit] 2013-09-13 10:07:09,813 - INFO  [Thread-5:NIOServerCnxn@1435] - 
Closed socket connection for client /127.0.0.1:47663 (no session established 
for client)
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-09-13 10:07:09,814 - INFO  [main:ClientBase@431] - te

[jira] [Commented] (ZOOKEEPER-1096) Leader communication should listen on specified IP, not wildcard address

[Marshall McMullen (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766511#comment-13766511
 ] 

Marshall McMullen commented on ZOOKEEPER-1096:
--

+1 for using the config file to configure the ports and any behavior thereof as 
this matches the way we configure client ports and is a lot easier to use and 
deploy on a mass scale IMO than java properties.

> Leader communication should listen on specified IP, not wildcard address
> 
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.3, 3.4.0
>Reporter: Jared Cantwell
>Assignee: Jared Cantwell
>Priority: Minor
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1096_branch3.4.patch, ZOOKEEPER-1096.patch, 
> ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication 
> and leader election (and not use the default of listening on all interfaces). 
>  This is similar to the clientPortAddress parameter that was added a year 
> ago.  After reviewing the code, we can't think of a reason why only the port 
> would be used with the wildcard interface, when servers are already 
> connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election 
> algorithms.
> Probably should have an option to toggle this, for backwards compatibility, 
> although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=h2+7gnj_4p28hgcxjh345h...@mail.gmail.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

RE: [VOTE] Bookkeeper 4.2.2 release candidate 0

[FPJ]

The problem with the oom is that the test case doesn't complete. I had to
change the severity level from INFO to WARN to get it to run. For the other
problem, I don't have enough insight yet. 

-Flavio

> -Original Message-
> From: Ivan Kelly [mailto:iv...@apache.org]
> Sent: 13 September 2013 10:50
> To: bookkeeper-...@zookeeper.apache.org
> Cc: bookkeeper-u...@zookeeper.apache.org
> Subject: Re: [VOTE] Bookkeeper 4.2.2 release candidate 0
> 
> The oom issue isn't a blocker (the problem is zk's oververbose logging).
> BOOKKEEPER-683 is though.
> 
> I agree we should cancel this rc. However, it will probably be october
before I
> can cut a new one. Busy couple of weeks coming up.
> 
> -Ivan
> 
> 
> On Thu, Sep 12, 2013 at 09:35:39PM +0100, Flavio Junqueira wrote:
> > I'm getting the same problem with GcLedgersTest:
> >
> > Exception in thread "ThreadedStreamConsumer"
> java.lang.OutOfMemoryError: Java heap space
> > at java.util.Arrays.copyOf(Arrays.java:2367)
> > at
>
java.lang.AbstractStringBuilder.expandCapacity(AbstractStringBuilder.java:13
> 0)
> > at
>
java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder
> .java:114)
> > at
> java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:415)
> > at java.lang.StringBuffer.append(StringBuffer.java:237)
> > at
> org.apache.maven.surefire.report.ConsoleOutputFileReporter.writeMessag
> e(ConsoleOutputFileReporter.java:115)
> > at
> org.apache.maven.surefire.report.MulticastingReporter.writeMessage(Multi
> castingReporter.java:101)
> > at
> org.apache.maven.surefire.report.TestSetRunListener.writeTestOutput(Test
> SetRunListener.java:99)
> > at
> org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLi
> ne(ForkClient.java:132)
> > at
> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamCons
> umer$Pumper.run(ThreadedStreamConsumer.java:67)
> > at java.lang.Thread.run(Thread.java:722)
> >
> > and one test failure on hedwig-server (BOOKKEEPER-683). I don't want to
> be a party pooper, but I'd feel more comfortable if we could fix these
issues
> and have another release candidate. What do you think?
> >
> > -Flavio
> >
> >
> > On Sep 12, 2013, at 3:27 PM, Jiannan Wang 
> wrote:
> >
> > > Agree, thanks for the finding.
> > >
> > > Best,
> > > Jiannan
> > >
> > > On 9/12/13 6:05 PM, "Ivan Kelly"  wrote:
> > >
> > >> I managed to repro with
> > >> MAVEN_OPTS="-Xmx128M" mvn test -Dtest=GcLedgersTest
> > >>
> > >> The test in question creates 3 ledgers, using
> > >> asyncCreateLedgers, which causes a lot of zk INFO level log messages.
> > >>
> > >> This isn't an issue worth blocking the release for.
> > >>
> > >> -Ivan
> > >>
> > >> On Thu, Sep 12, 2013 at 09:42:49AM +, Ivan Kelly wrote:
> > >>> Hi Jiannan,
> > >>>
> > >>> Could you send me the logs for this. The  in the pom has
> > >>> no affect here because that only applies to the surefire child
> > >>> process. This OOM is in the maven process itself, because the test
> > >>> is producing too many logs. I'll try reducing my heap to see if I
> > >>> can get the same to happen.
> > >>>
> > >>> -Ivan
> > >>>
> > >>>
> > >>> On Thu, Sep 12, 2013 at 03:31:19AM +, Jiannan Wang wrote:
> >  +1 for this release.
> > 
> >  All test cases pass except
> >  org.apache.bookkeeper.meta.GcLedgersTest,
> > >>> which
> >  throws following exception
> >  --
> >  Exception in thread "ThreadedStreamConsumer"
> > >>> java.lang.OutOfMemoryError:
> >  Java heap space
> > at java.util.Arrays.copyOf(Arrays.java:2882)
> > at
> > 
> > >>> java.lang.AbstractStringBuilder.expandCapacity(AbstractStringBuild
> > >>> er.java
> > >>> :1
> >  00)
> > at
> > >>> java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:
> > >>> 390)
> > at java.lang.StringBuffer.append(StringBuffer.java:224)
> > at
> > 
> > >>>
> org.apache.maven.surefire.report.ConsoleOutputFileReporter.writeMe
> > >>> ssage(C
> > >>> on
> >  soleOutputFileReporter.java:115)
> > at
> > 
> > >>>
> org.apache.maven.surefire.report.MulticastingReporter.writeMessage
> > >>> (Multic
> > >>> as
> >  tingReporter.java:101)
> > at
> > 
> > >>>
> org.apache.maven.surefire.report.TestSetRunListener.writeTestOutpu
> > >>> t(TestS
> > >>> et
> >  RunListener.java:99)
> > at
> > 
> > >>> org.apache.maven.plugin.surefire.booterclient.output.ForkClient.co
> > >>> nsumeLi
> > >>> ne
> >  (ForkClient.java:132)
> > at
> > 
> > >>> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStrea
> > >>> mConsum
> > >>> er
> >  $Pumper.run(ThreadedStreamConsumer.java:67)
> > at java.lang.Thread.run(Thread.java:680)
> >  --
> > 
> >  I need to execute 'export MAVEN_OPTS="-Xmx1G"' before running
> the
> > >>> test.
> >  (So the -Xmx1G -Dj

Failed: ZOOKEEPER-1189 PreCommit Build #1577

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1189
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1577/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by remote host 127.0.0.1
Building remotely on hadoop9 in workspace 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build
Reverting /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk 
to depth infinity with ignoreExternals: false
Updating http://svn.apache.org/repos/asf/zookeeper/trunk at revision 
'2013-09-13T17:51:36.132 +'
At revision 1523034
no change for http://svn.apache.org/repos/asf/zookeeper/trunk since the 
previous build
No emails were triggered.
[PreCommit-ZOOKEEPER-Build] $ /bin/bash /tmp/hudson7682529665190149318.sh
/home/jenkins/tools/java/latest/bin/java
Buildfile: build.xml

check-for-findbugs:

findbugs.check:

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-1189.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] At revision 1523035.
 [exec] ZOOKEEPER-1189 is not "Patch Available".  Exiting.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 6 seconds
Archiving artifacts
ERROR: No artifacts found that match the file pattern 
"trunk/build/test/findbugs/newPatchFindbugsWarnings.html,trunk/patchprocess/*.txt,trunk/patchprocess/*Warnings.xml,trunk/build/test/test-cppunit/*.txt,trunk/build/tmp/zk.log".
 Configuration error?
ERROR: ?trunk/build/test/findbugs/newPatchFindbugsWarnings.html? doesn?t match 
anything: ?trunk? exists but not 
?trunk/build/test/findbugs/newPatchFindbugsWarnings.html?
Build step 'Archive the artifacts' changed build result to FAILURE
Recording test results
Description set: ZOOKEEPER-1189
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-1607) Read-only Observer

[Raul Gutierrez Segales (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raul Gutierrez Segales updated ZOOKEEPER-1607:
--

Attachment: persistent-read-only-for-observers.patch

New version of the patch with tests. Also - this is generated with git diff -p 
so it should be Hadoop QA friendly. 

> Read-only Observer
> --
>
> Key: ZOOKEEPER-1607
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1607
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
> Attachments: persistent-read-only-for-observers.patch
>
>
> This feature reused some of the mechanism already provided by 
> ReadOnlyZooKeeper (ZOOKEEPER-704) but implemented in a different way
> Goal: read-only clients should be able to connect to the observer or continue 
> to read data from the observer event when there is an outage of underling 
> quorum. This means that it is possible for the observer to provide 100% read 
> uptime for read-only local session (ZOOKEEPER-1147)
> Implementation: 
> The observer don't tear down itself when it lose connection with the leader. 
> It only close the connection associated with non read-only sessions and 
> global sessions. So the client can try other observer if this is a temporal 
> failure. 
> During the outage, the observer switch to read-only mode. All the pending and 
> future write requests get will get NOT_READONLY error. Read-only state 
> transition is sent to all session on that observer. The observer only accepts 
> a new connection from a read-only client.
> When the observer is able to reconnect to the leader. It sends state 
> transition (CONNECTED_STATE) to all current session. If it is able to 
> synchronize with the leader using DIFF, the steam of txns is sent through the 
> commit processor instead of applying to the DataTree directly to prevent 
> raise condition between in-flight read requests (see ZOOKEEPER-1505). The 
> client will receive watch events correctly and can start issuing write 
> requests. 
> However, if the observer is getting the snapshot. It need to drop all the 
> connection since it cannot fire a watch correctly.  
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1607) Read-only Observer

[Raul Gutierrez Segales (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raul Gutierrez Segales updated ZOOKEEPER-1607:
--

Attachment: (was: 
0001-RFC-Don-t-tear-down-an-Observer-when-we-lose-connect.patch)

> Read-only Observer
> --
>
> Key: ZOOKEEPER-1607
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1607
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
> Attachments: persistent-read-only-for-observers.patch
>
>
> This feature reused some of the mechanism already provided by 
> ReadOnlyZooKeeper (ZOOKEEPER-704) but implemented in a different way
> Goal: read-only clients should be able to connect to the observer or continue 
> to read data from the observer event when there is an outage of underling 
> quorum. This means that it is possible for the observer to provide 100% read 
> uptime for read-only local session (ZOOKEEPER-1147)
> Implementation: 
> The observer don't tear down itself when it lose connection with the leader. 
> It only close the connection associated with non read-only sessions and 
> global sessions. So the client can try other observer if this is a temporal 
> failure. 
> During the outage, the observer switch to read-only mode. All the pending and 
> future write requests get will get NOT_READONLY error. Read-only state 
> transition is sent to all session on that observer. The observer only accepts 
> a new connection from a read-only client.
> When the observer is able to reconnect to the leader. It sends state 
> transition (CONNECTED_STATE) to all current session. If it is able to 
> synchronize with the leader using DIFF, the steam of txns is sent through the 
> commit processor instead of applying to the DataTree directly to prevent 
> raise condition between in-flight read requests (see ZOOKEEPER-1505). The 
> client will receive watch events correctly and can start issuing write 
> requests. 
> However, if the observer is getting the snapshot. It need to drop all the 
> connection since it cannot fire a watch correctly.  
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1607) Read-only Observer

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766740#comment-13766740
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1607:
---

Arrrg I guess dependent patches aren't applied :(

> Read-only Observer
> --
>
> Key: ZOOKEEPER-1607
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1607
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
> Attachments: persistent-read-only-for-observers.patch
>
>
> This feature reused some of the mechanism already provided by 
> ReadOnlyZooKeeper (ZOOKEEPER-704) but implemented in a different way
> Goal: read-only clients should be able to connect to the observer or continue 
> to read data from the observer event when there is an outage of underling 
> quorum. This means that it is possible for the observer to provide 100% read 
> uptime for read-only local session (ZOOKEEPER-1147)
> Implementation: 
> The observer don't tear down itself when it lose connection with the leader. 
> It only close the connection associated with non read-only sessions and 
> global sessions. So the client can try other observer if this is a temporal 
> failure. 
> During the outage, the observer switch to read-only mode. All the pending and 
> future write requests get will get NOT_READONLY error. Read-only state 
> transition is sent to all session on that observer. The observer only accepts 
> a new connection from a read-only client.
> When the observer is able to reconnect to the leader. It sends state 
> transition (CONNECTED_STATE) to all current session. If it is able to 
> synchronize with the leader using DIFF, the steam of txns is sent through the 
> commit processor instead of applying to the DataTree directly to prevent 
> raise condition between in-flight read requests (see ZOOKEEPER-1505). The 
> client will receive watch events correctly and can start issuing write 
> requests. 
> However, if the observer is getting the snapshot. It need to drop all the 
> connection since it cannot fire a watch correctly.  
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1096) Leader communication should listen on specified IP, not wildcard address

[JIRA]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766474#comment-13766474
 ] 

Germán Blanco commented on ZOOKEEPER-1096:
--

Ok, I know how to update the documentation now. By the way, the forrest task 
seems to be broken for Windows. I will ask in the developers mailing list.

> Leader communication should listen on specified IP, not wildcard address
> 
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.3, 3.4.0
>Reporter: Jared Cantwell
>Assignee: Jared Cantwell
>Priority: Minor
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1096_branch3.4.patch, ZOOKEEPER-1096.patch, 
> ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication 
> and leader election (and not use the default of listening on all interfaces). 
>  This is similar to the clientPortAddress parameter that was added a year 
> ago.  After reviewing the code, we can't think of a reason why only the port 
> would be used with the wildcard interface, when servers are already 
> connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election 
> algorithms.
> Probably should have an option to toggle this, for backwards compatibility, 
> although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=h2+7gnj_4p28hgcxjh345h...@mail.gmail.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jenkins build is back to normal : bookkeeper-trunk #360

[Apache Jenkins Server]

See 

Failed: ZOOKEEPER-1607 PreCommit Build #1578

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1607
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1578/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 130 lines...]
 [exec] 6 out of 6 hunks FAILED -- saving rejects to file 
b/src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java.rej
 [exec] patching file 
b/src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
 [exec] Hunk #1 FAILED at 86.
 [exec] Hunk #2 FAILED at 110.
 [exec] 2 out of 2 hunks FAILED -- saving rejects to file 
b/src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java.rej
 [exec] patching file 
b/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
 [exec] Hunk #1 FAILED at 754.
 [exec] Hunk #2 FAILED at 931.
 [exec] 2 out of 2 hunks FAILED -- saving rejects to file 
b/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java.rej
 [exec] patching file 
b/src/java/test/org/apache/zookeeper/test/ObserverReadOnlyTest.java
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12603061/persistent-read-only-for-observers.patch
 [exec]   against trunk revision 1522079.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 2 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1578//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] fa0a834011e605107b3a41d8c7441f65fe570c2e logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 1

Total time: 46 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1607
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1607) Read-only Observer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766736#comment-13766736
 ] 

Hadoop QA commented on ZOOKEEPER-1607:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12603061/persistent-read-only-for-observers.patch
  against trunk revision 1522079.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 2 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1578//console

This message is automatically generated.

> Read-only Observer
> --
>
> Key: ZOOKEEPER-1607
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1607
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
> Attachments: persistent-read-only-for-observers.patch
>
>
> This feature reused some of the mechanism already provided by 
> ReadOnlyZooKeeper (ZOOKEEPER-704) but implemented in a different way
> Goal: read-only clients should be able to connect to the observer or continue 
> to read data from the observer event when there is an outage of underling 
> quorum. This means that it is possible for the observer to provide 100% read 
> uptime for read-only local session (ZOOKEEPER-1147)
> Implementation: 
> The observer don't tear down itself when it lose connection with the leader. 
> It only close the connection associated with non read-only sessions and 
> global sessions. So the client can try other observer if this is a temporal 
> failure. 
> During the outage, the observer switch to read-only mode. All the pending and 
> future write requests get will get NOT_READONLY error. Read-only state 
> transition is sent to all session on that observer. The observer only accepts 
> a new connection from a read-only client.
> When the observer is able to reconnect to the leader. It sends state 
> transition (CONNECTED_STATE) to all current session. If it is able to 
> synchronize with the leader using DIFF, the steam of txns is sent through the 
> commit processor instead of applying to the DataTree directly to prevent 
> raise condition between in-flight read requests (see ZOOKEEPER-1505). The 
> client will receive watch events correctly and can start issuing write 
> requests. 
> However, if the observer is getting the snapshot. It need to drop all the 
> connection since it cannot fire a watch correctly.  
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (BOOKKEEPER-685) Race in compaction algorithm from BOOKKEEPER-664

[Ivan Kelly (JIRA)]

Ivan Kelly created BOOKKEEPER-685:
-

 Summary: Race in compaction algorithm from BOOKKEEPER-664
 Key: BOOKKEEPER-685
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-685
 Project: Bookkeeper
  Issue Type: Bug
Reporter: Ivan Kelly
Priority: Blocker
 Fix For: 4.2.2


I discovered a race in the algorithm when I was forward porting to trunk.

1) Thread1: flushed.set(false)
2) Thread2: onRotateEntryLog() // flushed.set(true)
3) Thread1: entryLogger addEntry L123-E456
4) Thread1: offsets > max, waits for flushed, flushed is true(as set in 2), 
L123-E456 updated in ledger cache
5) T2: L123 flushed out of ledger cache
6) Crash

This will possible lose 1 entry. I've only reasoned this, not observed it, but 
it can happen.

The fix is pretty easy. EntryLoggerListener should notify with the point offset 
in the entry log it has synced as far as. 
  


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1552) Enable sync request processor in Observer

[Thawan Kooburat (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thawan Kooburat updated ZOOKEEPER-1552:
---

Attachment: ZOOKEEPER-1552.patch

Attach a trunk patch

> Enable sync request processor in Observer
> -
>
> Key: ZOOKEEPER-1552
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum, server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
>Assignee: Thawan Kooburat
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch
>
>
> Observer doesn't forward its txns to SyncRequestProcessor. So it never 
> persists the txns onto disk or periodically creates snapshots. This increases 
> the start-up time since it will get the entire snapshot if the observer has 
> be running for a long time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1552) Enable sync request processor in Observer

[Thawan Kooburat (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thawan Kooburat updated ZOOKEEPER-1552:
---

Attachment: ZOOKEEPER-1552-3.4.patch

Re-upload German's patch 

> Enable sync request processor in Observer
> -
>
> Key: ZOOKEEPER-1552
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum, server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
>Assignee: Thawan Kooburat
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch
>
>
> Observer doesn't forward its txns to SyncRequestProcessor. So it never 
> persists the txns onto disk or periodically creates snapshots. This increases 
> the start-up time since it will get the entire snapshot if the observer has 
> be running for a long time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Failed: ZOOKEEPER-1552 PreCommit Build #1579

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1579/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67 lines...]
 [exec] 
 [exec] 
 [exec] patching file 
src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
 [exec] patching file 
src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
 [exec] Hunk #2 FAILED at 61.
 [exec] Hunk #3 succeeded at 79 (offset -2 lines).
 [exec] Hunk #4 succeeded at 101 (offset -2 lines).
 [exec] 1 out of 4 hunks FAILED -- saving rejects to file 
src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java.rej
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12603168/ZOOKEEPER-1552-3.4.patch
 [exec]   against trunk revision 1522079.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1579//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] faf59c0da35e359f8ea86f6743bad1221f5b94cd logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 1

Total time: 41 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1552
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767240#comment-13767240
 ] 

Hadoop QA commented on ZOOKEEPER-1552:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12603168/ZOOKEEPER-1552-3.4.patch
  against trunk revision 1522079.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1579//console

This message is automatically generated.

> Enable sync request processor in Observer
> -
>
> Key: ZOOKEEPER-1552
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum, server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
>Assignee: Thawan Kooburat
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch
>
>
> Observer doesn't forward its txns to SyncRequestProcessor. So it never 
> persists the txns onto disk or periodically creates snapshots. This increases 
> the start-up time since it will get the entire snapshot if the observer has 
> be running for a long time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767251#comment-13767251
 ] 

Hadoop QA commented on ZOOKEEPER-1552:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12603168/ZOOKEEPER-1552-3.4.patch
  against trunk revision 1522079.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1580//console

This message is automatically generated.

> Enable sync request processor in Observer
> -
>
> Key: ZOOKEEPER-1552
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum, server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
>Assignee: Thawan Kooburat
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch
>
>
> Observer doesn't forward its txns to SyncRequestProcessor. So it never 
> persists the txns onto disk or periodically creates snapshots. This increases 
> the start-up time since it will get the entire snapshot if the observer has 
> be running for a long time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Failed: ZOOKEEPER-1552 PreCommit Build #1580

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1580/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67 lines...]
 [exec] 
 [exec] 
 [exec] patching file 
src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
 [exec] patching file 
src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
 [exec] Hunk #2 FAILED at 61.
 [exec] Hunk #3 succeeded at 79 (offset -2 lines).
 [exec] Hunk #4 succeeded at 101 (offset -2 lines).
 [exec] 1 out of 4 hunks FAILED -- saving rejects to file 
src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java.rej
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12603168/ZOOKEEPER-1552-3.4.patch
 [exec]   against trunk revision 1522079.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1580//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 14eff328de50f0d9da7bfe21c5682e4c64bd5a38 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 1

Total time: 44 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1552
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Created] (ZOOKEEPER-1758) Add documentation for zookeeper.observer.syncRequestProcessorEnabled flag

[Thawan Kooburat (JIRA)]

Thawan Kooburat created ZOOKEEPER-1758:
--

 Summary: Add documentation for 
zookeeper.observer.syncRequestProcessorEnabled flag
 Key: ZOOKEEPER-1758
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1758
 Project: ZooKeeper
  Issue Type: Improvement
Reporter: Thawan Kooburat
Assignee: Thawan Kooburat
Priority: Minor
 Fix For: 3.5.0, 3.4.6




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Failed: ZOOKEEPER-1552 PreCommit Build #1581

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1581/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67 lines...]
 [exec] 
 [exec] 
 [exec] patching file 
src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
 [exec] patching file 
src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
 [exec] Hunk #2 FAILED at 61.
 [exec] Hunk #3 succeeded at 79 (offset -2 lines).
 [exec] Hunk #4 succeeded at 101 (offset -2 lines).
 [exec] 1 out of 4 hunks FAILED -- saving rejects to file 
src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java.rej
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12603168/ZOOKEEPER-1552-3.4.patch
 [exec]   against trunk revision 1522079.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1581//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] e8871eab2adf2d443f470267782cd1bd9e926c93 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 1

Total time: 42 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1552
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767260#comment-13767260
 ] 

Hadoop QA commented on ZOOKEEPER-1552:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12603168/ZOOKEEPER-1552-3.4.patch
  against trunk revision 1522079.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1581//console

This message is automatically generated.

> Enable sync request processor in Observer
> -
>
> Key: ZOOKEEPER-1552
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum, server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
>Assignee: Thawan Kooburat
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch
>
>
> Observer doesn't forward its txns to SyncRequestProcessor. So it never 
> persists the txns onto disk or periodically creates snapshots. This increases 
> the start-up time since it will get the entire snapshot if the observer has 
> be running for a long time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1758) Add documentation for zookeeper.observer.syncRequestProcessorEnabled flag

[Thawan Kooburat (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thawan Kooburat updated ZOOKEEPER-1758:
---

Attachment: ZOOKEEPER-1758.patch

> Add documentation for zookeeper.observer.syncRequestProcessorEnabled flag
> -
>
> Key: ZOOKEEPER-1758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1758
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Thawan Kooburat
>Assignee: Thawan Kooburat
>Priority: Minor
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1758.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer

[Thawan Kooburat (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767286#comment-13767286
 ] 

Thawan Kooburat commented on ZOOKEEPER-1552:


Not sure how to tell Hadoop QA to pickup a certain file to run.   Also upload a 
documentation patch

> Enable sync request processor in Observer
> -
>
> Key: ZOOKEEPER-1552
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum, server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
>Assignee: Thawan Kooburat
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch
>
>
> Observer doesn't forward its txns to SyncRequestProcessor. So it never 
> persists the txns onto disk or periodically creates snapshots. This increases 
> the start-up time since it will get the entire snapshot if the observer has 
> be running for a long time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1551) Observer ignore txns that comes after snapshot and UPTODATE

[Thawan Kooburat (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thawan Kooburat updated ZOOKEEPER-1551:
---

Attachment: ZOOKEEPER-1551-3.4.patch

Upload 3.4 patch

> Observer ignore txns that comes after snapshot and UPTODATE 
> 
>
> Key: ZOOKEEPER-1551
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1551
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum, server
>Affects Versions: 3.4.3
>Reporter: Thawan Kooburat
>Assignee: Thawan Kooburat
>Priority: Blocker
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1551-3.4.patch, ZOOKEEPER-1551.patch, 
> ZOOKEEPER-1551.patch, ZOOKEEPER-1551-trunk.patch
>
>
> In Learner.java, txns which comes after the learner has taken the snapshot 
> (after NEWLEADER packet) are stored in packetsNotCommitted. The follower has 
> special logic to apply these txns at the end of syncWithLeader() method. 
> However, the observer will ignore these txns completely, causing data 
> inconsistency. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1757) Adler32 may not be sufficient to protect against data corruption

[Thawan Kooburat (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thawan Kooburat updated ZOOKEEPER-1757:
---

Priority: Minor  (was: Major)

> Adler32 may not be sufficient to protect against data corruption
> 
>
> Key: ZOOKEEPER-1757
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1757
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: Linux.  Oracle JDK6/7
>Reporter: Thawan Kooburat
>Priority: Minor
> Attachments: ZOOKEEPER.1757.patch, ZOOKEEPER.1757.patch
>
>
> I was investigating data inconsistency bug in our internal branch. One 
> possible area is snapshot/txnlog corruption. So I wrote a more robust 
> corruption test and found that it is easy to break our checksum algorithm 
> which is Adler32.
> When this happen, it is more likely that corrupted data will fail other 
> sanity check during deserialization phase, but it is still scary that it can 
> pass the checksum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Failed: ZOOKEEPER-1758 PreCommit Build #1582

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1758
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1582/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 265171 lines...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12603173/ZOOKEEPER-1758.patch
 [exec]   against trunk revision 1522079.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1582//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1582//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1582//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 86bf39838b4e4eed2507f86495707df6add42c19 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 1

Total time: 30 minutes 55 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1758
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1758) Add documentation for zookeeper.observer.syncRequestProcessorEnabled flag

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767296#comment-13767296
 ] 

Hadoop QA commented on ZOOKEEPER-1758:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12603173/ZOOKEEPER-1758.patch
  against trunk revision 1522079.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1582//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1582//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1582//console

This message is automatically generated.

> Add documentation for zookeeper.observer.syncRequestProcessorEnabled flag
> -
>
> Key: ZOOKEEPER-1758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1758
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Thawan Kooburat
>Assignee: Thawan Kooburat
>Priority: Minor
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1758.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1757) Adler32 may not be sufficient to protect against data corruption

[Thawan Kooburat (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767297#comment-13767297
 ] 

Thawan Kooburat commented on ZOOKEEPER-1757:


Reducing the severity because it is unlikely the server will load the snapshot 
cleanly.  It would fail other sanity check while deserializing the snapshot.

However, one thing to note is that we are using just 8-byte Aler32 checksum for 
the entire snapshot.  For snapshot, i think it would be better to go with 
md5sum.  In our internal branch, we compress the snapshot before writing, so we 
get additional checksum through compression   

> Adler32 may not be sufficient to protect against data corruption
> 
>
> Key: ZOOKEEPER-1757
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1757
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: Linux.  Oracle JDK6/7
>Reporter: Thawan Kooburat
>Priority: Minor
> Attachments: ZOOKEEPER.1757.patch, ZOOKEEPER.1757.patch
>
>
> I was investigating data inconsistency bug in our internal branch. One 
> possible area is snapshot/txnlog corruption. So I wrote a more robust 
> corruption test and found that it is easy to break our checksum algorithm 
> which is Adler32.
> When this happen, it is more likely that corrupted data will fail other 
> sanity check during deserialization phase, but it is still scary that it can 
> pass the checksum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira