date:20131107

[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch

2013-11-07 Thread Flavio Junqueira (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815750#comment-13815750
 ] 

Flavio Junqueira commented on ZOOKEEPER-1808:
-

Ok, thanks for the feedback. Could you review it, please?

> Add version to FLE notifications for 3.4 branch
> ---
>
> Key: ZOOKEEPER-1808
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1808.patch
>
>
> Add version to notification messages so that we can differentiate messages 
> during rolling upgrades. This task is for the 3.4 branch only. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1804) Stat the realtime tps of zookeepr server

2013-11-07 Thread Leader Ni (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leader Ni updated ZOOKEEPER-1804:
-

Fix Version/s: 3.5.0

> Stat the realtime tps of zookeepr server
> 
>
> Key: ZOOKEEPER-1804
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1804
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Leader Ni
>Assignee: Leader Ni
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1804.patch, ZOOKEEPER-1804.patch
>
>
> At this time, we assessed whether zookeeper supports some business scenarios, 
> always use the number of subscribers, or to assess the number of clients。
> You konw, some times, many client connection with zookeeper, but do noting, 
> and the onthers do complex business logic。
> So，we must stat the realtime tps of zookeepr。
> [-Solution---]
> Solution1: 
> If you only want to know the real time transaction processed, you can use the 
> patch "ZOOKEEPER-1804.patch".
> Solution2:
> If you also want to know how client use zookeeper, and the real time r/w ps 
> of each zookeeper client, you can use the patch "ZOOKEEPER-1804-2.patch"
> use java properties: -Dserver_process_stats=true to open the function.
> Sample:
> $>echo rwps|nc localhost 2181
> RealTime R/W Statistics:
> getChildren2:　　　0.5994005994005994
> createSession:　　1.6983016983016983
> closeSession:　　　0.999000999000999
> setData:　110.18981018981019
> setWatches:　　　129.17082917082917
> getChildren:　　　 68.83116883116884
> delete:　　19.980019980019982
> create: 　22.27772227772228
> exists:　　1806.2937062937062
> getDate:　729.5704295704296



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1804) Stat the realtime tps of zookeepr server

2013-11-07 Thread Leader Ni (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leader Ni updated ZOOKEEPER-1804:
-

Attachment: (was: ZOOKEEPER-1804-2.patch)

> Stat the realtime tps of zookeepr server
> 
>
> Key: ZOOKEEPER-1804
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1804
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Leader Ni
>Assignee: Leader Ni
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1804.patch, ZOOKEEPER-1804.patch
>
>
> At this time, we assessed whether zookeeper supports some business scenarios, 
> always use the number of subscribers, or to assess the number of clients。
> You konw, some times, many client connection with zookeeper, but do noting, 
> and the onthers do complex business logic。
> So，we must stat the realtime tps of zookeepr。
> [-Solution---]
> Solution1: 
> If you only want to know the real time transaction processed, you can use the 
> patch "ZOOKEEPER-1804.patch".
> Solution2:
> If you also want to know how client use zookeeper, and the real time r/w ps 
> of each zookeeper client, you can use the patch "ZOOKEEPER-1804-2.patch"
> use java properties: -Dserver_process_stats=true to open the function.
> Sample:
> $>echo rwps|nc localhost 2181
> RealTime R/W Statistics:
> getChildren2:　　　0.5994005994005994
> createSession:　　1.6983016983016983
> closeSession:　　　0.999000999000999
> setData:　110.18981018981019
> setWatches:　　　129.17082917082917
> getChildren:　　　 68.83116883116884
> delete:　　19.980019980019982
> create: 　22.27772227772228
> exists:　　1806.2937062937062
> getDate:　729.5704295704296



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1804) Stat the realtime tps of zookeepr server

2013-11-07 Thread Leader Ni (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leader Ni updated ZOOKEEPER-1804:
-

Attachment: ZOOKEEPER-1804.patch

patch for trunk

> Stat the realtime tps of zookeepr server
> 
>
> Key: ZOOKEEPER-1804
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1804
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Leader Ni
>Assignee: Leader Ni
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1804.patch, ZOOKEEPER-1804.patch
>
>
> At this time, we assessed whether zookeeper supports some business scenarios, 
> always use the number of subscribers, or to assess the number of clients。
> You konw, some times, many client connection with zookeeper, but do noting, 
> and the onthers do complex business logic。
> So，we must stat the realtime tps of zookeepr。
> [-Solution---]
> Solution1: 
> If you only want to know the real time transaction processed, you can use the 
> patch "ZOOKEEPER-1804.patch".
> Solution2:
> If you also want to know how client use zookeeper, and the real time r/w ps 
> of each zookeeper client, you can use the patch "ZOOKEEPER-1804-2.patch"
> use java properties: -Dserver_process_stats=true to open the function.
> Sample:
> $>echo rwps|nc localhost 2181
> RealTime R/W Statistics:
> getChildren2:　　　0.5994005994005994
> createSession:　　1.6983016983016983
> closeSession:　　　0.999000999000999
> setData:　110.18981018981019
> setWatches:　　　129.17082917082917
> getChildren:　　　 68.83116883116884
> delete:　　19.980019980019982
> create: 　22.27772227772228
> exists:　　1806.2937062937062
> getDate:　729.5704295704296



--
This message was sent by Atlassian JIRA
(v6.1#6144)

zookeeper pull request: Stat the realtime tps of zookeepr server

2013-11-07 Thread nileader

GitHub user nileader opened a pull request:

https://github.com/apache/zookeeper/pull/6

Stat the realtime tps of zookeepr server

Apache issue: 
ZOOKEEPER-1804(https://issues.apache.org/jira/browse/ZOOKEEPER-1804)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nileader/zookeeper trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/6.patch


commit be0eb53c67d3704722195acd6269ed970f934510
Author: é¶æ¶(nileader) 
Date:   2013-11-07T09:14:00Z

Stat the realtime tps of zookeepr server
Apache issue: 
ZOOKEEPER-1804(https://issues.apache.org/jira/browse/ZOOKEEPER-1804)

[jira] [Created] (BOOKKEEPER-702) Upgrade protobuf-java to 2.5.0 version

2013-11-07 Thread Rakesh R (JIRA)

Rakesh R created BOOKKEEPER-702:
---

 Summary: Upgrade protobuf-java to 2.5.0 version
 Key: BOOKKEEPER-702
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-702
 Project: Bookkeeper
  Issue Type: Improvement
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Blocker


HDFS is using BK for the shared memory approach through BKJM plugin. Presently 
HDFS is using Bookkeeper4.0.0 version and when tries to upgrade to latest 4.2.2 
version, there is a conflicts in protobuf versions between the components. 
Latest HDFS 2.1 branch is using protobuf-java-2.5.0 version, but BK has 
protobuf-java-2.4.1 version.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

ZooKeeper-trunk-solaris - Build # 724 - Still Failing

2013-11-07 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/724/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 207327 lines...]
[junit] 2013-11-07 09:30:54,936 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2013-11-07 09:30:54,937 [myid:] - INFO  [main:ZooKeeperServer@428] 
- shutting down
[junit] 2013-11-07 09:30:54,937 [myid:] - INFO  
[main:SessionTrackerImpl@183] - Shutting down
[junit] 2013-11-07 09:30:54,937 [myid:] - INFO  
[main:PrepRequestProcessor@972] - Shutting down
[junit] 2013-11-07 09:30:54,937 [myid:] - INFO  
[main:SyncRequestProcessor@190] - Shutting down
[junit] 2013-11-07 09:30:54,937 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2013-11-07 09:30:54,938 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited!
[junit] 2013-11-07 09:30:54,938 [myid:] - INFO  
[main:FinalRequestProcessor@442] - shutdown of request processor complete
[junit] 2013-11-07 09:30:54,938 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-11-07 09:30:54,939 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[]
[junit] 2013-11-07 09:30:54,940 [myid:] - INFO  [main:ClientBase@414] - 
STARTING server
[junit] 2013-11-07 09:30:54,940 [myid:] - INFO  [main:ZooKeeperServer@149] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7125800987186436938.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7125800987186436938.junit.dir/version-2
[junit] 2013-11-07 09:30:54,941 [myid:] - INFO  
[main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2013-11-07 09:30:54,941 [myid:] - INFO  
[main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-11-07 09:30:54,942 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7125800987186436938.junit.dir/version-2/snapshot.b
[junit] 2013-11-07 09:30:54,945 [myid:] - INFO  [main:FileTxnSnapLog@297] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7125800987186436938.junit.dir/version-2/snapshot.b
[junit] 2013-11-07 09:30:54,946 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-11-07 09:30:54,947 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:44709
[junit] 2013-11-07 09:30:54,947 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@828] - Processing stat command from 
/127.0.0.1:44709
[junit] 2013-11-07 09:30:54,947 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn$StatCommand@677] - Stat command output
[junit] 2013-11-07 09:30:54,948 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@999] - Closed socket connection for client 
/127.0.0.1:44709 (no session established for client)
[junit] 2013-11-07 09:30:54,948 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2013-11-07 09:30:54,949 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2013-11-07 09:30:54,949 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2013-11-07 09:30:54,949 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2013-11-07 09:30:54,950 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-11-07 09:30:54,950 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota
[junit] 2013-11-07 09:30:54,950 [myid:] - INFO  [main:ClientBase@451] - 
tearDown starting
[junit] 2013-11-07 09:30:55,020 [myid:] - INFO  [main:ZooKeeper@777] - 
Session: 0x14231e66fa3 closed
[junit] 2013-11-07 09:30:55,020 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down
[junit] 2013-11-07 09:30:55,020 [myid:] - INFO  [main:ClientBase@421] - 
STOPPING server
[junit] 2013-11-07 09:30:55,021 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420]

Failed: ZOOKEEPER-1804 PreCommit Build #1746

2013-11-07 Thread Apache Jenkins Server

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1804
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1746/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 262573 lines...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12612555/ZOOKEEPER-1804.patch
 [exec]   against trunk revision 1539529.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 4 new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1746//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1746//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1746//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] ead3353f6cd9ab58647ac5291cd17d9630a8e345 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 2

Total time: 33 minutes 22 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1804
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1804) Stat the realtime tps of zookeepr server

2013-11-07 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815823#comment-13815823
 ] 

Hadoop QA commented on ZOOKEEPER-1804:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12612555/ZOOKEEPER-1804.patch
  against trunk revision 1539529.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 4 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1746//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1746//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1746//console

This message is automatically generated.

> Stat the realtime tps of zookeepr server
> 
>
> Key: ZOOKEEPER-1804
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1804
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Leader Ni
>Assignee: Leader Ni
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1804.patch, ZOOKEEPER-1804.patch
>
>
> At this time, we assessed whether zookeeper supports some business scenarios, 
> always use the number of subscribers, or to assess the number of clients。
> You konw, some times, many client connection with zookeeper, but do noting, 
> and the onthers do complex business logic。
> So，we must stat the realtime tps of zookeepr。
> [-Solution---]
> Solution1: 
> If you only want to know the real time transaction processed, you can use the 
> patch "ZOOKEEPER-1804.patch".
> Solution2:
> If you also want to know how client use zookeeper, and the real time r/w ps 
> of each zookeeper client, you can use the patch "ZOOKEEPER-1804-2.patch"
> use java properties: -Dserver_process_stats=true to open the function.
> Sample:
> $>echo rwps|nc localhost 2181
> RealTime R/W Statistics:
> getChildren2:　　　0.5994005994005994
> createSession:　　1.6983016983016983
> closeSession:　　　0.999000999000999
> setData:　110.18981018981019
> setWatches:　　　129.17082917082917
> getChildren:　　　 68.83116883116884
> delete:　　19.980019980019982
> create: 　22.27772227772228
> exists:　　1806.2937062937062
> getDate:　729.5704295704296



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1382) Zookeeper server holds onto dead/expired session ids in the watch data structures

2013-11-07 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Germán Blanco updated ZOOKEEPER-1382:
-

Attachment: ZOOKEEPER-1382.patch

spaces and style changes

> Zookeeper server holds onto dead/expired session ids in the watch data 
> structures
> -
>
> Key: ZOOKEEPER-1382
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1382
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.5
>Reporter: Neha Narkhede
>Assignee: Germán Blanco
>Priority: Critical
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1382-branch-3.4.patch, 
> ZOOKEEPER-1382-branch-3.4.patch, ZOOKEEPER-1382-branch-3.4.patch, 
> ZOOKEEPER-1382.patch, ZOOKEEPER-1382.patch, ZOOKEEPER-1382.patch, 
> ZOOKEEPER-1382.patch, ZOOKEEPER-1382_3.3.4.patch
>
>
> I've observed that zookeeper server holds onto expired session ids in the 
> watcher data structures. The result is the wchp command reports session ids 
> that cannot be found through cons/dump and those expired session ids sit 
> there maybe until the server is restarted. Here are snippets from the client 
> and the server logs that lead to this state, for one particular session id 
> 0x134485fd7bcb26f -
> There are 4 servers in the zookeeper cluster - 223, 224, 225 (leader), 226 
> and I'm using ZkClient to connect to the cluster
> From the application log -
> application.log.2012-01-26-325.gz:2012/01/26 04:56:36.177 INFO [ClientCnxn] 
> [main-SendThread(223.prod:12913)] [application Session establishment complete 
> on server 223.prod/172.17.135.38:12913, sessionid = 0x134485fd7bcb26f, 
> negotiated timeout = 6000
> application.log.2012-01-27.gz:2012/01/27 09:52:37.714 INFO [ClientCnxn] 
> [main-SendThread(223.prod:12913)] [application] Client session timed out, 
> have not heard from server in 9827ms for sessionid 0x134485fd7bcb26f, closing 
> socket connection and attempting reconnect
> application.log.2012-01-27.gz:2012/01/27 09:52:38.191 INFO [ClientCnxn] 
> [main-SendThread(226.prod:12913)] [application] Unable to reconnect to 
> ZooKeeper service, session 0x134485fd7bcb26f has expired, closing socket 
> connection
> On the leader zk, 225 -
> zookeeper.log.2012-01-27-leader-225.gz:2012-01-27 09:52:34,010 - INFO  
> [SessionTracker:ZooKeeperServer@314] - Expiring session 0x134485fd7bcb26f, 
> timeout of 6000ms exceeded
> zookeeper.log.2012-01-27-leader-225.gz:2012-01-27 09:52:34,010 - INFO  
> [ProcessThread:-1:PrepRequestProcessor@391] - Processed session termination 
> for sessionid: 0x134485fd7bcb26f
> On the server, the client was initially connected to, 223 -
> zookeeper.log.2012-01-26-223.gz:2012-01-26 04:56:36,173 - INFO  
> [CommitProcessor:1:NIOServerCnxn@1580] - Established session 
> 0x134485fd7bcb26f with negotiated timeout 6000 for client /172.17.136.82:45020
> zookeeper.log.2012-01-27-223.gz:2012-01-27 09:52:34,018 - INFO  
> [CommitProcessor:1:NIOServerCnxn@1435] - Closed socket connection for client 
> /172.17.136.82:45020 which had sessionid 0x134485fd7bcb26f
> Here are the log snippets from 226, which is the server, the client 
> reconnected to, before getting session expired event -
> 2012-01-27 09:52:38,190 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:12913:NIOServerCnxn@770] - Client 
> attempting to renew session 0x134485fd7bcb26f at /172.17.136.82:49367
> 2012-01-27 09:52:38,191 - INFO  
> [QuorumPeer:/0.0.0.0:12913:NIOServerCnxn@1573] - Invalid session 
> 0x134485fd7bcb26f for client /172.17.136.82:49367, probably expired
> 2012-01-27 09:52:38,191 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:12913:NIOServerCnxn@1435] - Closed 
> socket connection for client /172.17.136.82:49367 which had sessionid 
> 0x134485fd7bcb26f
> wchp output from 226, taken on 01/30 -
> nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep 0x134485fd7bcb26f 
> *226.*wchp* | wc -l
> 3
> wchp output from 223, taken on 01/30 -
> nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep 0x134485fd7bcb26f 
> *223.*wchp* | wc -l
> 0
> cons output from 223 and 226, taken on 01/30 -
> nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep 0x134485fd7bcb26f 
> *226.*cons* | wc -l
> 0
> nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep 0x134485fd7bcb26f 
> *223.*cons* | wc -l
> 0
> So, what seems to have happened is that the client was able to re-register 
> the watches on the new server (226), after it got disconnected from 223, 
> inspite of having an expired session id. 
> In NIOServerCnxn, I saw that after suspecting that a session is expired, a 
> server removes the cnxn and its watches from its internal data structures. 
> But before that it allows more requests to be processed even if the session 
> is expired -
> // Now that the session is re

[jira] [Commented] (ZOOKEEPER-1783) Distinguish initial configuration from first established configuration

2013-11-07 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815846#comment-13815846
 ] 

Hudson commented on ZOOKEEPER-1783:
---

SUCCESS: Integrated in ZooKeeper-trunk #2113 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/2113/])
ZOOKEEPER-1783. Distinguish initial configuration from first established 
configuration (shralex via breed) (breed: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1539529)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/c/tests/TestReconfigServer.cc
* 
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
* 
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
* 
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java
* 
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java


> Distinguish initial configuration from first established configuration
> --
>
> Key: ZOOKEEPER-1783
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1783
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum, server
>Affects Versions: 3.5.0
>Reporter: Alexander Shraer
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1783-ver1.patch, ZOOKEEPER-1783-ver2.patch, 
> ZOOKEEPER-1783-ver3.patch, ZOOKEEPER-1783-ver4.patch, 
> ZOOKEEPER-1783-ver5.patch, ZOOKEEPER-1783-ver6.patch, 
> ZOOKEEPER-1783-ver7.patch, ZOOKEEPER-1783-ver8.patch, 
> ZOOKEEPER-1783-ver9.patch, ZOOKEEPER-1783.patch
>
>
> We need a way to distinguish an initial config of a server and an initial 
> config of a running ensemble (before any reconfigs happen). Currently both 
> have version 0. 
> The version of a config increases with each reconfiguration, so the problem 
> is just with the initial config.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1382) Zookeeper server holds onto dead/expired session ids in the watch data structures

2013-11-07 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815855#comment-13815855
 ] 

Hadoop QA commented on ZOOKEEPER-1382:
--

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12612572/ZOOKEEPER-1382.patch
  against trunk revision 1539529.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 12 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1747//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1747//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1747//console

This message is automatically generated.

> Zookeeper server holds onto dead/expired session ids in the watch data 
> structures
> -
>
> Key: ZOOKEEPER-1382
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1382
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.5
>Reporter: Neha Narkhede
>Assignee: Germán Blanco
>Priority: Critical
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1382-branch-3.4.patch, 
> ZOOKEEPER-1382-branch-3.4.patch, ZOOKEEPER-1382-branch-3.4.patch, 
> ZOOKEEPER-1382.patch, ZOOKEEPER-1382.patch, ZOOKEEPER-1382.patch, 
> ZOOKEEPER-1382.patch, ZOOKEEPER-1382_3.3.4.patch
>
>
> I've observed that zookeeper server holds onto expired session ids in the 
> watcher data structures. The result is the wchp command reports session ids 
> that cannot be found through cons/dump and those expired session ids sit 
> there maybe until the server is restarted. Here are snippets from the client 
> and the server logs that lead to this state, for one particular session id 
> 0x134485fd7bcb26f -
> There are 4 servers in the zookeeper cluster - 223, 224, 225 (leader), 226 
> and I'm using ZkClient to connect to the cluster
> From the application log -
> application.log.2012-01-26-325.gz:2012/01/26 04:56:36.177 INFO [ClientCnxn] 
> [main-SendThread(223.prod:12913)] [application Session establishment complete 
> on server 223.prod/172.17.135.38:12913, sessionid = 0x134485fd7bcb26f, 
> negotiated timeout = 6000
> application.log.2012-01-27.gz:2012/01/27 09:52:37.714 INFO [ClientCnxn] 
> [main-SendThread(223.prod:12913)] [application] Client session timed out, 
> have not heard from server in 9827ms for sessionid 0x134485fd7bcb26f, closing 
> socket connection and attempting reconnect
> application.log.2012-01-27.gz:2012/01/27 09:52:38.191 INFO [ClientCnxn] 
> [main-SendThread(226.prod:12913)] [application] Unable to reconnect to 
> ZooKeeper service, session 0x134485fd7bcb26f has expired, closing socket 
> connection
> On the leader zk, 225 -
> zookeeper.log.2012-01-27-leader-225.gz:2012-01-27 09:52:34,010 - INFO  
> [SessionTracker:ZooKeeperServer@314] - Expiring session 0x134485fd7bcb26f, 
> timeout of 6000ms exceeded
> zookeeper.log.2012-01-27-leader-225.gz:2012-01-27 09:52:34,010 - INFO  
> [ProcessThread:-1:PrepRequestProcessor@391] - Processed session termination 
> for sessionid: 0x134485fd7bcb26f
> On the server, the client was initially connected to, 223 -
> zookeeper.log.2012-01-26-223.gz:2012-01-26 04:56:36,173 - INFO  
> [CommitProcessor:1:NIOServerCnxn@1580] - Established session 
> 0x134485fd7bcb26f with negotiated timeout 6000 for client /172.17.136.82:45020
> zookeeper.log.2012-01-27-223.gz:2012-01-27 09:52:34,018 - INFO  
> [CommitProcessor:1:NIOServerCnxn@1435] - Closed socket connection for client 
> /172.17.136.82:45020 which had sessionid 0x134485fd7bcb26f
> Here are the log snippets from 226, which is the server, the client 
> reconnected to, before getting session expired event -
> 2012-01-27 09:52:38,190 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:12913:NIOServerCnxn@770] - Client 
> attempting to renew session 0x134485fd7bcb26f at /172.17.136.82:49367
> 2012-01-27 09:52:38,191 - INFO  
> [QuorumPeer:/0.0.0.0:12913:NIOServerCnxn@1573] - Invalid session 
> 0x134485fd7bcb26f for client /172.17.136.82:49367, probably expired
> 2012-01-27 09:52:38,191 - INFO  
> [NIOServerCxn.Facto

Success: ZOOKEEPER-1382 PreCommit Build #1747

2013-11-07 Thread Apache Jenkins Server

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1382
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1747/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 264529 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12612572/ZOOKEEPER-1382.patch
 [exec]   against trunk revision 1539529.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 12 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1747//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1747//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1747//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 96708cb24f2bfb44fb09be07e3a9cf1c4185ff6c logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 33 minutes 12 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1382
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch

2013-11-07 Thread JIRA


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815858#comment-13815858
 ] 

Germán Blanco commented on ZOOKEEPER-1808:
--

The patch doesn't seem to work for me.
It seems to be based on directory "src", it complains about three files not 
being there, and then it seems to have failed to create those files.
Could you please upload a new one?

> Add version to FLE notifications for 3.4 branch
> ---
>
> Key: ZOOKEEPER-1808
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1808.patch
>
>
> Add version to notification messages so that we can differentiate messages 
> during rolling upgrades. This task is for the 3.4 branch only. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch

2013-11-07 Thread Flavio Junqueira (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-1808:


Attachment: ZOOKEEPER-1808.patch

This one should do it. Thanks, [~abranzyck]!

> Add version to FLE notifications for 3.4 branch
> ---
>
> Key: ZOOKEEPER-1808
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
>
>
> Add version to notification messages so that we can differentiate messages 
> during rolling upgrades. This task is for the 3.4 branch only. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch

2013-11-07 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815963#comment-13815963
 ] 

Hadoop QA commented on ZOOKEEPER-1808:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12612600/ZOOKEEPER-1808.patch
  against trunk revision 1539529.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 21 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1748//console

This message is automatically generated.

> Add version to FLE notifications for 3.4 branch
> ---
>
> Key: ZOOKEEPER-1808
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
>
>
> Add version to notification messages so that we can differentiate messages 
> during rolling upgrades. This task is for the 3.4 branch only. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Failed: ZOOKEEPER-1808 PreCommit Build #1748

2013-11-07 Thread Apache Jenkins Server

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1748/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 97 lines...]
 [exec] Apply anyway? [n] 
 [exec] Skipping patch.
 [exec] 1 out of 1 hunk ignored -- saving rejects to file 
src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java.rej
 [exec] patching file 
src/java/test/org/apache/zookeeper/test/FLETestUtils.java
 [exec] Reversed (or previously applied) patch detected!  Assume -R? [n] 
 [exec] Apply anyway? [n] 
 [exec] Skipping patch.
 [exec] 1 out of 1 hunk ignored -- saving rejects to file 
src/java/test/org/apache/zookeeper/test/FLETestUtils.java.rej
 [exec] patching file 
src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java
 [exec] Hunk #1 succeeded at 37 (offset -1 lines).
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12612600/ZOOKEEPER-1808.patch
 [exec]   against trunk revision 1539529.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 21 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1748//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 8f65f4e62bdf5155ae4e95fe06ad2120c6f0bf13 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 1

Total time: 1 minute 18 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1808
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1804) Stat the realtime tps of zookeepr server

2013-11-07 Thread Raul Gutierrez Segales (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816056#comment-13816056
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1804:
---

Small styling nits, in things like:

{noformat}
+   if ( zkServer == null ) {
+   pw.println( ZK_NOT_SERVING );
{noformat}

the spaces after ( and before ) aren't used in the rest of the code.

Also - at the cost of introducing another dependency though - you might want to 
check Twitter's stats package which has convenience classes/methods for keeping 
stats (also useful for the case of write/read latency to keep p99, etc):

http://twitter.github.io/commons/apidocs/#com.twitter.common.stats.Stats

We use this in an internal branch atm. 


> Stat the realtime tps of zookeepr server
> 
>
> Key: ZOOKEEPER-1804
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1804
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Leader Ni
>Assignee: Leader Ni
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1804.patch, ZOOKEEPER-1804.patch
>
>
> At this time, we assessed whether zookeeper supports some business scenarios, 
> always use the number of subscribers, or to assess the number of clients。
> You konw, some times, many client connection with zookeeper, but do noting, 
> and the onthers do complex business logic。
> So，we must stat the realtime tps of zookeepr。
> [-Solution---]
> Solution1: 
> If you only want to know the real time transaction processed, you can use the 
> patch "ZOOKEEPER-1804.patch".
> Solution2:
> If you also want to know how client use zookeeper, and the real time r/w ps 
> of each zookeeper client, you can use the patch "ZOOKEEPER-1804-2.patch"
> use java properties: -Dserver_process_stats=true to open the function.
> Sample:
> $>echo rwps|nc localhost 2181
> RealTime R/W Statistics:
> getChildren2:　　　0.5994005994005994
> createSession:　　1.6983016983016983
> closeSession:　　　0.999000999000999
> setData:　110.18981018981019
> setWatches:　　　129.17082917082917
> getChildren:　　　 68.83116883116884
> delete:　　19.980019980019982
> create: 　22.27772227772228
> exists:　　1806.2937062937062
> getDate:　729.5704295704296



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2013-11-07 Thread Alexander Shraer (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Shraer updated ZOOKEEPER-1807:


Attachment: ZOOKEEPER-1807-ver3.patch

> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807.patch, notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2013-11-07 Thread Raul Gutierrez Segales (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816152#comment-13816152
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1807:
---

[~shralex]: do you think that, perhaps, adding a comment elaborating a bit more 
on the rationale of notifications and the state of the new/old config would be 
worthwhile? I am thinking the comment should be along sendNotifications().

> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807.patch, notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2013-11-07 Thread Raul Gutierrez Segales (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816157#comment-13816157
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1807:
---

(could we get a reviewboard for this? some inline comments below)

For:

{noformat}
+// start server 3 with new config
+zk[2] = new ZooKeeper("127.0.0.1:" + ports[2][2], 
ClientBase.CONNECTION_TIMEOUT, this);
{noformat}

I think the zk[2] assignment goes before the comment. 

For:

{noformat}

+for (int i=2; i<3; i++) {
+Assert.assertTrue("waiting for server "+ i + " being up",
+ClientBase.waitForServerUp("127.0.0.1:" + ports[i][2],
+CONNECTION_TIMEOUT * 2));
+ReconfigTest.testServerHasConfig(zk[i], allServersNext, null);  
+}
{noformat}

i<= 3? Or no loop if you only want it to loop one time I guess.

Also the ports assignment loop and the currentQuorumCfgSection creation are 
repeated in testObserverConvertedToParticipantDuringFLE and 
testCurrentObserverIsParticipantInNewConfig; mind DRY-ing this up a bit by 
putting those in private methods? (i.e.: generatePorts() and 
generateInitialConfig() or such such). 



> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807.patch, notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Success: ZOOKEEPER-1807 PreCommit Build #1749

2013-11-07 Thread Apache Jenkins Server

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1749/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 293543 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12612635/ZOOKEEPER-1807-ver3.patch
 [exec]   against trunk revision 1539529.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1749//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1749//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1749//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 686f0266cd877ddb005b372084853c132a08236f logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 34 minutes 20 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1807
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2013-11-07 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816173#comment-13816173
 ] 

Hadoop QA commented on ZOOKEEPER-1807:
--

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12612635/ZOOKEEPER-1807-ver3.patch
  against trunk revision 1539529.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1749//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1749//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1749//console

This message is automatically generated.

> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807.patch, notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Review Request 15317: Send FLE notifications only to voters in current config, reverting a change made in zk-107

2013-11-07 Thread Alexander Shraer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15317/
---

Review request for zookeeper.


Bugs: ZOOKEEPER-1807
https://issues.apache.org/jira/browse/ZOOKEEPER-1807


Repository: zookeeper


Description
---

ZOOKEEPER-1807


Diffs
-

  ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
1539709 
  ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1539709 
  ./src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java 
1539709 

Diff: https://reviews.apache.org/r/15317/diff/


Testing
---

two tests added to ReconfigRecoveryTest


Thanks,

Alexander Shraer

[jira] [Updated] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2013-11-07 Thread Alexander Shraer (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Shraer updated ZOOKEEPER-1807:


Attachment: ZOOKEEPER-1807-ver4.patch

https://reviews.apache.org/r/15317/

thanks for the comments, Raul.

[~fpj] Raul and others, please see if my comment makes sense

> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807-ver4.patch, ZOOKEEPER-1807.patch, 
> notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Re: Review Request 15317: Send FLE notifications only to voters in current config, reverting a change made in zk-107

2013-11-07 Thread Raul Gutierrez Segales


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15317/#review28421
---



./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java


nit: For an example



./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java


two nits:
- maybe these comments can be merged with the comment block before the 
method definition (it's a short method anyway).
- Either use or don't use . at the end of your sentences (consistently). 



./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java


super nit: if possible, lets not introduce the trailing spaces.



./src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java


ditto



./src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java


ditto wrt trailing spaces (same for the other recurrences). 


- Raul Gutierrez Segales


On Nov. 7, 2013, 6:50 p.m., Alexander Shraer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15317/
> ---
> 
> (Updated Nov. 7, 2013, 6:50 p.m.)
> 
> 
> Review request for zookeeper.
> 
> 
> Bugs: ZOOKEEPER-1807
> https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> 
> 
> Repository: zookeeper
> 
> 
> Description
> ---
> 
> ZOOKEEPER-1807
> 
> 
> Diffs
> -
> 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
> 1539709 
>   ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1539709 
>   
> ./src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java 
> 1539709 
> 
> Diff: https://reviews.apache.org/r/15317/diff/
> 
> 
> Testing
> ---
> 
> two tests added to ReconfigRecoveryTest
> 
> 
> Thanks,
> 
> Alexander Shraer
> 
>

[jira] [Commented] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2013-11-07 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816316#comment-13816316
 ] 

Hadoop QA commented on ZOOKEEPER-1807:
--

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12612664/ZOOKEEPER-1807-ver4.patch
  against trunk revision 1539529.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1750//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1750//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1750//console

This message is automatically generated.

> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807-ver4.patch, ZOOKEEPER-1807.patch, 
> notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Success: ZOOKEEPER-1807 PreCommit Build #1750

2013-11-07 Thread Apache Jenkins Server

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1750/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 228937 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12612664/ZOOKEEPER-1807-ver4.patch
 [exec]   against trunk revision 1539529.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1750//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1750//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1750//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 79edd894606dc0358ee84db1e0a441683d77f344 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 34 minutes 57 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1807
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

Re: Review Request 15317: Send FLE notifications only to voters in current config, reverting a change made in zk-107

2013-11-07 Thread Alexander Shraer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15317/#review28444
---

Ship it!


Ship It!

- Alexander Shraer


On Nov. 7, 2013, 6:50 p.m., Alexander Shraer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15317/
> ---
> 
> (Updated Nov. 7, 2013, 6:50 p.m.)
> 
> 
> Review request for zookeeper.
> 
> 
> Bugs: ZOOKEEPER-1807
> https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> 
> 
> Repository: zookeeper
> 
> 
> Description
> ---
> 
> ZOOKEEPER-1807
> 
> 
> Diffs
> -
> 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
> 1539709 
>   ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1539709 
>   
> ./src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java 
> 1539709 
> 
> Diff: https://reviews.apache.org/r/15317/diff/
> 
> 
> Testing
> ---
> 
> two tests added to ReconfigRecoveryTest
> 
> 
> Thanks,
> 
> Alexander Shraer
> 
>

Re: Review Request 15317: Send FLE notifications only to voters in current config, reverting a change made in zk-107

2013-11-07 Thread Alexander Shraer



> On Nov. 7, 2013, 9:09 p.m., Alexander Shraer wrote:
> > Ship It!

oops thats not what I meant :)


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15317/#review28444
---


On Nov. 7, 2013, 6:50 p.m., Alexander Shraer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15317/
> ---
> 
> (Updated Nov. 7, 2013, 6:50 p.m.)
> 
> 
> Review request for zookeeper.
> 
> 
> Bugs: ZOOKEEPER-1807
> https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> 
> 
> Repository: zookeeper
> 
> 
> Description
> ---
> 
> ZOOKEEPER-1807
> 
> 
> Diffs
> -
> 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
> 1539709 
>   ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1539709 
>   
> ./src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java 
> 1539709 
> 
> Diff: https://reviews.apache.org/r/15317/diff/
> 
> 
> Testing
> ---
> 
> two tests added to ReconfigRecoveryTest
> 
> 
> Thanks,
> 
> Alexander Shraer
> 
>

[jira] [Updated] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2013-11-07 Thread Alexander Shraer (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Shraer updated ZOOKEEPER-1807:


Attachment: ZOOKEEPER-1807-ver5.patch

> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807-ver4.patch, 
> ZOOKEEPER-1807-ver5.patch, ZOOKEEPER-1807.patch, notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Re: Review Request 15317: Send FLE notifications only to voters in current config, reverting a change made in zk-107

2013-11-07 Thread Alexander Shraer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15317/
---

(Updated Nov. 7, 2013, 9:23 p.m.)


Review request for zookeeper.


Changes
---

addressed Raul's comments


Bugs: ZOOKEEPER-1807
https://issues.apache.org/jira/browse/ZOOKEEPER-1807


Repository: zookeeper


Description
---

ZOOKEEPER-1807


Diffs (updated)
-

  ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
1539709 
  ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1539709 
  ./src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java 
1539709 

Diff: https://reviews.apache.org/r/15317/diff/


Testing
---

two tests added to ReconfigRecoveryTest


Thanks,

Alexander Shraer

[jira] [Commented] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2013-11-07 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816797#comment-13816797
 ] 

Hadoop QA commented on ZOOKEEPER-1807:
--

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12612698/ZOOKEEPER-1807-ver5.patch
  against trunk revision 1539529.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1751//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1751//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1751//console

This message is automatically generated.

> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807-ver4.patch, 
> ZOOKEEPER-1807-ver5.patch, ZOOKEEPER-1807.patch, notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Success: ZOOKEEPER-1807 PreCommit Build #1751

2013-11-07 Thread Apache Jenkins Server

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1751/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 271640 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12612698/ZOOKEEPER-1807-ver5.patch
 [exec]   against trunk revision 1539529.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1751//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1751//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1751//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] e1b8386b9de75e6b29a0b06b8e67240e3da0e29a logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 35 minutes 47 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1807
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Updated] (ZOOKEEPER-1798) Fix race condition in testNormalObserverRun

2013-11-07 Thread Thawan Kooburat (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thawan Kooburat updated ZOOKEEPER-1798:
---

Attachment: ZOOKEEPER-1798-2.patch

Attach a patch that also shutdown sync request processor as part of observer 
shutdown

> Fix race condition in testNormalObserverRun
> ---
>
> Key: ZOOKEEPER-1798
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1798
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Flavio Junqueira
>Assignee: Thawan Kooburat
>Priority: Blocker
> Fix For: 3.4.6, 3.5.0
>
> Attachments: TEST-org.apache.zookeeper.server.quorum.Zab1_0Test.txt, 
> ZOOKEEPER-1798-2.patch, ZOOKEEPER-1798-b3.4.patch, ZOOKEEPER-1798-b3.4.patch, 
> ZOOKEEPER-1798-b3.4.patch, ZOOKEEPER-1798.patch, ZOOKEEPER-1798.patch
>
>
> This is the output messges:
> 
> Testcase: testNormalObserverRun took 4.221 sec
> FAILED
> expected: but was:
> junit.framework.AssertionFailedError: expected: but was:
> at 
> org.apache.zookeeper.server.quorum.Zab1_0Test$8.converseWithObserver(Zab1_0Test.java:1118)
> at 
> org.apache.zookeeper.server.quorum.Zab1_0Test.testObserverConversation(Zab1_0Test.java:546)
> at 
> org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun(Zab1_0Test.java:994)
> 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1798) Fix race condition in testNormalObserverRun

2013-11-07 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817030#comment-13817030
 ] 

Hadoop QA commented on ZOOKEEPER-1798:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12612782/ZOOKEEPER-1798-2.patch
  against trunk revision 1539529.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1752//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1752//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1752//console

This message is automatically generated.

> Fix race condition in testNormalObserverRun
> ---
>
> Key: ZOOKEEPER-1798
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1798
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Flavio Junqueira
>Assignee: Thawan Kooburat
>Priority: Blocker
> Fix For: 3.4.6, 3.5.0
>
> Attachments: TEST-org.apache.zookeeper.server.quorum.Zab1_0Test.txt, 
> ZOOKEEPER-1798-2.patch, ZOOKEEPER-1798-b3.4.patch, ZOOKEEPER-1798-b3.4.patch, 
> ZOOKEEPER-1798-b3.4.patch, ZOOKEEPER-1798.patch, ZOOKEEPER-1798.patch
>
>
> This is the output messges:
> 
> Testcase: testNormalObserverRun took 4.221 sec
> FAILED
> expected: but was:
> junit.framework.AssertionFailedError: expected: but was:
> at 
> org.apache.zookeeper.server.quorum.Zab1_0Test$8.converseWithObserver(Zab1_0Test.java:1118)
> at 
> org.apache.zookeeper.server.quorum.Zab1_0Test.testObserverConversation(Zab1_0Test.java:546)
> at 
> org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun(Zab1_0Test.java:994)
> 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Failed: ZOOKEEPER-1798 PreCommit Build #1752

2013-11-07 Thread Apache Jenkins Server

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1798
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1752/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 228588 lines...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12612782/ZOOKEEPER-1798-2.patch
 [exec]   against trunk revision 1539529.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1752//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1752//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1752//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] c7115cd73c23e5c17d3a9f281c48fb94d934c852 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 2

Total time: 30 minutes 15 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1798
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
1 tests failed.
REGRESSION:  org.apache.zookeeper.test.FLETest.testTripleElection

Error Message:
Fewer than a a majority has joined

Stack Trace:
junit.framework.AssertionFailedError: Fewer than a a majority has joined
at org.apache.zookeeper.test.FLETest.runElection(FLETest.java:355)
at 
org.apache.zookeeper.test.FLETest.testTripleElection(FLETest.java:282)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

[jira] [Commented] (ZOOKEEPER-1806) testCurrentServersAreObserversInNextConfig failing frequently on trunk with non-jdk6

2013-11-07 Thread Patrick Hunt (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817056#comment-13817056
 ] 

Patrick Hunt commented on ZOOKEEPER-1806:
-

I'm not sure, is that really the issue? What does junit mean when it says 
"crashed"? Did the jvm itself crash?

> testCurrentServersAreObserversInNextConfig failing frequently on trunk with 
> non-jdk6
> 
>
> Key: ZOOKEEPER-1806
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1806
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
>
> testCurrentServersAreObserversInNextConfig failing frequently on trunk with 
> jdk7
> I see a number of failures recently on this test. Is it a real issue or 
> flakey? Perhaps due to re-ordering/cleanup with jdk7 as we've seen with some 
> other tests? (I don't see this test failing with jdk6)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

38 matches

Mail list logo