[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820945#comment-13820945 ] Germán Blanco commented on ZOOKEEPER-1808: -- I am assuming that we only need to ensure that the rolling upgrade works for official releases (3.4.5, 3.4.5, 3.5.0 ...) and not e.g. between an snapshot of trunk and 3.5.0. As I see it, in 3.5.0 the checks should be modified in that now there will also be a "backCompatibility40" (strict comparison length == 40) that includes the version number. Configuration information will follow the version number. For any message including the version number, this version number is what needs to be checked in order to parse any message content above the length of 40. > Add version to FLE notifications for 3.4 branch > --- > > Key: ZOOKEEPER-1808 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, > ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, > ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch > > > Add version to notification messages so that we can differentiate messages > during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820963#comment-13820963 ] Helen Hastings commented on ZOOKEEPER-1691: --- Currently working on turning the hack into a solution. > Add a flag to disable standalone mode > - > > Key: ZOOKEEPER-1691 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1691 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Reporter: Michi Mutsuzaki >Assignee: Helen Hastings > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, > ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch > > > Currently you cannot use dynamic reconfiguration to bootstrap zookeeper > cluster because the server goes into standalone mode when there is only one > server in the cluster. > --Michi -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1794) Add hash check to transaction history in quorum servers
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-1794: - Attachment: ZOOKEEPER-1794.patch No tests included. > Add hash check to transaction history in quorum servers > --- > > Key: ZOOKEEPER-1794 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1794 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum >Reporter: Germán Blanco >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1794.patch > > Original Estimate: 336h > Remaining Estimate: 336h > > The goal of this task is to add a hash number to each transaction in the > transaction history. This hash number will be the same in all members of the > quorum, since it shall have the same result if the members have the same > transaction history. That means that there will be no need to send any new > information between members of the quorum, during the broadcast phase. The > hash number will be checked by the leader when learners try to connect, and > it shall also be sent together with the snapshot during synchronisation. If > the hash number does not match, the synchronisation shall be done with a > snapshot in order to overwrite the conflicts in the transaction history. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1794) Add hash check to transaction history in quorum servers
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-1794: - Description: The goal of this task is to add a hash number to each transaction in the transaction history. This hash number will depend on the entire transaction history. This hash number will be the same in all members of the quorum, since it shall have the same result if the members have the same transaction history. That means that there will be no need to send any new information between members of the quorum, during the broadcast phase. The hash number will be checked by the leader when learners try to connect, and it shall also be sent together with the snapshot during synchronisation. If the hash number does not match, the synchronisation shall be done with a snapshot in order to overwrite the conflicts in the transaction history. (was: The goal of this task is to add a hash number to each transaction in the transaction history. This hash number will be the same in all members of the quorum, since it shall have the same result if the members have the same transaction history. That means that there will be no need to send any new information between members of the quorum, during the broadcast phase. The hash number will be checked by the leader when learners try to connect, and it shall also be sent together with the snapshot during synchronisation. If the hash number does not match, the synchronisation shall be done with a snapshot in order to overwrite the conflicts in the transaction history.) > Add hash check to transaction history in quorum servers > --- > > Key: ZOOKEEPER-1794 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1794 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum >Reporter: Germán Blanco >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1794.patch > > Original Estimate: 336h > Remaining Estimate: 336h > > The goal of this task is to add a hash number to each transaction in the > transaction history. This hash number will depend on the entire transaction > history. This hash number will be the same in all members of the quorum, > since it shall have the same result if the members have the same transaction > history. That means that there will be no need to send any new information > between members of the quorum, during the broadcast phase. The hash number > will be checked by the leader when learners try to connect, and it shall also > be sent together with the snapshot during synchronisation. If the hash number > does not match, the synchronisation shall be done with a snapshot in order to > overwrite the conflicts in the transaction history. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1794) Add hash check to transaction history in quorum servers
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820353#comment-13820353 ] Hadoop QA commented on ZOOKEEPER-1794: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613347/ZOOKEEPER-1794.patch against trunk revision 1540961. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1761//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1761//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1761//console This message is automatically generated. > Add hash check to transaction history in quorum servers > --- > > Key: ZOOKEEPER-1794 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1794 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum >Reporter: Germán Blanco >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1794.patch > > Original Estimate: 336h > Remaining Estimate: 336h > > The goal of this task is to add a hash number to each transaction in the > transaction history. This hash number will depend on the entire transaction > history. This hash number will be the same in all members of the quorum, > since it shall have the same result if the members have the same transaction > history. That means that there will be no need to send any new information > between members of the quorum, during the broadcast phase. The hash number > will be checked by the leader when learners try to connect, and it shall also > be sent together with the snapshot during synchronisation. If the hash number > does not match, the synchronisation shall be done with a snapshot in order to > overwrite the conflicts in the transaction history. -- This message was sent by Atlassian JIRA (v6.1#6144)
Failed: ZOOKEEPER-1794 PreCommit Build #1761
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1794 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1761/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 285536 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12613347/ZOOKEEPER-1794.patch [exec] against trunk revision 1540961. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1761//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1761//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1761//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 501e28927ff7f5002875bc05a776519ed462feaa logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 33 minutes 11 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1794 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820599#comment-13820599
]
Raul Gutierrez Segales commented on ZOOKEEPER-1808:
---
Some stylistic nits:
{noformat}
+requestBuffer.putLong(epoch);
+requestBuffer.putInt( Notification.CURRENTVERSION );
{noformat}
no spaces between parenthesis and parameters.
{noformat}
+if(response.buffer.remaining() >= 4) {
+n.version = response.buffer.getInt();
+} else {
+n.version = 0x0;
+}
{noformat}
More succinct:
{noformat}
+ n.version ? response.buffer.remaining() >= 4 :
0x0;
{noformat}
Nit:
{noformat}
private void printNotification(Notification n){
-LOG.info("Notification: " + n.leader + " (n.leader), 0x"
+LOG.info("Notification: " + Long.toHexString(n.version) + " (message
format version), "
...
{noformat}
Maybe that belongs as toString inside Notification?
Super nit: there's two extra newlines in
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java.
> Add version to FLE notifications for 3.4 branch
> ---
>
> Key: ZOOKEEPER-1808
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
> ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
> ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
>
>
> Add version to notification messages so that we can differentiate messages
> during rolling upgrades. This task is for the 3.4 branch only.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820600#comment-13820600
]
Raul Gutierrez Segales commented on ZOOKEEPER-1808:
---
Sorry meant:
{noformat}
n.version = response.buffer.remaining() >= 4 ? response.buffer.getInt() : 0x0;
{noformat}
> Add version to FLE notifications for 3.4 branch
> ---
>
> Key: ZOOKEEPER-1808
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
> ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
> ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
>
>
> Add version to notification messages so that we can differentiate messages
> during rolling upgrades. This task is for the 3.4 branch only.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820780#comment-13820780 ] Alexander Shraer commented on ZOOKEEPER-1808: - > In this case, I'd rather simply check the number of remaining bytes like in > the attached patch. This will need to change for the 3.5.0 patch since there I'm setting the buffer length so that it exactly fits the message (the configuration has variable length). Anyway, I think its fine that the patches for 3.5.0 and 3.4.6 do different things. > Add version to FLE notifications for 3.4 branch > --- > > Key: ZOOKEEPER-1808 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, > ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, > ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch > > > Add version to notification messages so that we can differentiate messages > during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
Failed: ZOOKEEPER-1691 PreCommit Build #1762
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1691 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1762/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86 lines...] [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java [exec] Hunk #1 FAILED at 925. [exec] 1 out of 1 hunk FAILED -- saving rejects to file src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java.rej [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java [exec] Hunk #1 succeeded at 74 (offset 4 lines). [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java [exec] Hunk #1 succeeded at 1228 (offset 39 lines). [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java [exec] patching file src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java [exec] patching file src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12606410/ZOOKEEPER-1691.patch [exec] against trunk revision 1540961. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 12 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1762//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 132d28644f776f1f2647258e06d0f5a3fc1b8694 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 1 minute 30 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1691 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820819#comment-13820819 ] Hadoop QA commented on ZOOKEEPER-1691: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12606410/ZOOKEEPER-1691.patch against trunk revision 1540961. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1762//console This message is automatically generated. > Add a flag to disable standalone mode > - > > Key: ZOOKEEPER-1691 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1691 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Reporter: Michi Mutsuzaki >Assignee: Helen Hastings > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, > ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch > > > Currently you cannot use dynamic reconfiguration to bootstrap zookeeper > cluster because the server goes into standalone mode when there is only one > server in the cluster. > --Michi -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820842#comment-13820842 ] Michi Mutsuzaki commented on ZOOKEEPER-1691: The patch doesn't apply anymore. It would be great if we can check this in soon. Helen/Alex, what are remaining issues? Thanks! --Michi > Add a flag to disable standalone mode > - > > Key: ZOOKEEPER-1691 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1691 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Reporter: Michi Mutsuzaki >Assignee: Helen Hastings > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, > ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch > > > Currently you cannot use dynamic reconfiguration to bootstrap zookeeper > cluster because the server goes into standalone mode when there is only one > server in the cluster. > --Michi -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820935#comment-13820935 ] Alexander Shraer commented on ZOOKEEPER-1691: - Hi Michi, Delete the FastLeaderElection.java part of the patch and it should apply. The change to FastLeaderElection.java in the patch are problematic in any case - they're sort of a hack, we should find a solution instead. Once you delete these changes you'll see that one of the tests doesn't pass, not sure where is the problem exactly. Fixing FastLeaderElection to support a single server and making the test pass are the remaining issues I know of. Alex > Add a flag to disable standalone mode > - > > Key: ZOOKEEPER-1691 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1691 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Reporter: Michi Mutsuzaki >Assignee: Helen Hastings > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, > ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch > > > Currently you cannot use dynamic reconfiguration to bootstrap zookeeper > cluster because the server goes into standalone mode when there is only one > server in the cluster. > --Michi -- This message was sent by Atlassian JIRA (v6.1#6144)
