ZooKeeper_branch33 - Build # 1136 - Failure
See https://builds.apache.org/job/ZooKeeper_branch33/1136/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 108288 lines...] [junit] 2013-11-16 09:51:09,589 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7364576467573699812.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7364576467573699812.junit.dir/version-2 [junit] 2013-11-16 09:51:09,590 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-16 09:51:09,591 - INFO [main:FileSnap@82] - Reading snapshot /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7364576467573699812.junit.dir/version-2/snapshot.0 [junit] 2013-11-16 09:51:09,594 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2013-11-16 09:51:09,597 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-16 09:51:09,597 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:55015 [junit] 2013-11-16 09:51:09,598 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:55015 [junit] 2013-11-16 09:51:09,598 - INFO [Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2013-11-16 09:51:09,599 - INFO [Thread-4:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:55015 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-16 09:51:09,600 - INFO [main:ClientBase@408] - STOPPING server [junit] 2013-11-16 09:51:09,601 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@278] - NIOServerCnxn factory exited run method [junit] 2013-11-16 09:51:09,601 - INFO [ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop! [junit] 2013-11-16 09:51:09,601 - INFO [SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited! [junit] 2013-11-16 09:51:09,602 - INFO [main:FinalRequestProcessor@370] - shutdown of request processor complete [junit] 2013-11-16 09:51:09,602 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] ensureOnly:[] [junit] 2013-11-16 09:51:09,604 - INFO [main:ClientBase@401] - STARTING server [junit] 2013-11-16 09:51:09,604 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7364576467573699812.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7364576467573699812.junit.dir/version-2 [junit] 2013-11-16 09:51:09,605 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-16 09:51:09,606 - INFO [main:FileSnap@82] - Reading snapshot /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch33/branch-3.3/build/test/tmp/test7364576467573699812.junit.dir/version-2/snapshot.b [junit] 2013-11-16 09:51:09,609 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2013-11-16 09:51:09,610 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-16 09:51:09,611 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:55017 [junit] 2013-11-16 09:51:09,611 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:55017 [junit] 2013-11-16 09:51:09,612 - INFO [Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2013-11-16 09:51:09,612 - INFO [Thread-5:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:55017 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-16 09:51:09,614 - INFO [main:ClientBase@431] -
[jira] [Comment Edited] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13823908#comment-13823908 ] Flavio Junqueira edited comment on ZOOKEEPER-1808 at 11/16/13 10:07 AM: Thanks for the reviews. Updated to revision 1542489. was (Author: fpj): Thanks for the reviews. Updated to revision 1542359. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
ZooKeeper-trunk-solaris - Build # 732 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/732/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 207596 lines...] [junit] 2013-11-16 10:48:48,244 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2013-11-16 10:48:48,245 [myid:] - INFO [main:ZooKeeperServer@428] - shutting down [junit] 2013-11-16 10:48:48,245 [myid:] - INFO [main:SessionTrackerImpl@183] - Shutting down [junit] 2013-11-16 10:48:48,245 [myid:] - INFO [main:PrepRequestProcessor@972] - Shutting down [junit] 2013-11-16 10:48:48,245 [myid:] - INFO [main:SyncRequestProcessor@190] - Shutting down [junit] 2013-11-16 10:48:48,245 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop! [junit] 2013-11-16 10:48:48,246 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited! [junit] 2013-11-16 10:48:48,246 [myid:] - INFO [main:FinalRequestProcessor@442] - shutdown of request processor complete [junit] 2013-11-16 10:48:48,246 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-16 10:48:48,247 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-11-16 10:48:48,248 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-11-16 10:48:48,248 [myid:] - INFO [main:ZooKeeperServer@149] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test942226858560484590.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test942226858560484590.junit.dir/version-2 [junit] 2013-11-16 10:48:48,249 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2013-11-16 10:48:48,249 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-16 10:48:48,251 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test942226858560484590.junit.dir/version-2/snapshot.b [junit] 2013-11-16 10:48:48,253 [myid:] - INFO [main:FileTxnSnapLog@297] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test942226858560484590.junit.dir/version-2/snapshot.b [junit] 2013-11-16 10:48:48,254 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-16 10:48:48,255 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:41305 [junit] 2013-11-16 10:48:48,256 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@828] - Processing stat command from /127.0.0.1:41305 [junit] 2013-11-16 10:48:48,256 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@677] - Stat command output [junit] 2013-11-16 10:48:48,256 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@999] - Closed socket connection for client /127.0.0.1:41305 (no session established for client) [junit] 2013-11-16 10:48:48,256 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-16 10:48:48,258 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-16 10:48:48,258 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-16 10:48:48,258 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-16 10:48:48,258 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-16 10:48:48,259 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-11-16 10:48:48,259 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-11-16 10:48:48,324 [myid:] - INFO [main:ZooKeeper@777] - Session: 0x1426086f662 closed [junit] 2013-11-16 10:48:48,325 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down [junit] 2013-11-16 10:48:48,325 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-16 10:48:48,333 [myid:] - INFO
[jira] [Created] (ZOOKEEPER-1817) Fix don't care for b3.4
Flavio Junqueira created ZOOKEEPER-1817: --- Summary: Fix don't care for b3.4 Key: ZOOKEEPER-1817 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1786) ZooKeeper data model documentation is incorrect
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824459#comment-13824459
]
Hudson commented on ZOOKEEPER-1786:
---
SUCCESS: Integrated in ZooKeeper-trunk #2121 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2121/])
ZOOKEEPER-1786. ZooKeeper data model documentation is incorrect (Niraj Tolia
via fpj) (fpj:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1542355)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
ZooKeeper data model documentation is incorrect
---
Key: ZOOKEEPER-1786
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1786
Project: ZooKeeper
Issue Type: Bug
Components: documentation
Affects Versions: 3.4.6
Reporter: Niraj Tolia
Assignee: Niraj Tolia
Priority: Minor
Fix For: 3.4.6, 3.5.0
Attachments: ZOOKEEPER-1786.patch
When I look at
https://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html#ch_zkDataModel,
I see two things that seem wrong in terms of restricted characters:
* \uXFFFE - \uX (where X is a digit 1 - E)
* \uF - \uF
These definitions are invalid characters in Java and aren't reflected in
PathUtils either (or PathUtilsTest). In fact the code in PathUtils states:
{code:borderStyle=solid}
} else if (c '\u' c = '\u001f'
|| c = '\u007f' c = '\u009F'
|| c = '\ud800' c = '\uf8ff'
|| c = '\ufff0' c = '\u') {
reason = invalid charater @ + i;
break;
}
{code}
Unless I am missing something, this simple patch should fix the documentation
problem:
{code}
Index: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
===
--- src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
(revision 1530514)
+++ src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
(working copy)
@@ -139,8 +139,7 @@
listitem
paraThe following characters are not allowed: \ud800 - uF8FF,
-\uFFF0 - u, \uXFFFE - \uX (where X is a digit 1 - E),
\uF -
-\uF./para
+\uFFF0 - u./para
/listitem
listitem
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-1808: Priority: Blocker (was: Major) Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (ZOOKEEPER-1818) Fix don't care for trunk
Flavio Junqueira created ZOOKEEPER-1818: --- Summary: Fix don't care for trunk Key: ZOOKEEPER-1818 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1818 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Priority: Blocker Fix For: 3.5.0 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-1817: Attachment: ZOOKEEPER-1817.patch [~abranzyck], [~rgs], please review and check that it doesn't break rolling upgrades. Also, waiting for your nits, [~rgs]. ;-) Fix don't care for b3.4 --- Key: ZOOKEEPER-1817 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1817.patch See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-1817: Attachment: ZOOKEEPER-1817.patch Fix don't care for b3.4 --- Key: ZOOKEEPER-1817 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824481#comment-13824481 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614222/ZOOKEEPER-1817.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1775//console This message is automatically generated. Fix don't care for b3.4 --- Key: ZOOKEEPER-1817 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
Failed: ZOOKEEPER-1817 PreCommit Build #1775
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1775/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 70 lines...] [exec] [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java [exec] Hunk #1 succeeded at 67 (offset 1 line). [exec] Hunk #2 succeeded at 637 with fuzz 2 (offset 20 lines). [exec] Hunk #3 succeeded at 924 (offset 20 lines). [exec] Hunk #4 succeeded at 946 (offset 20 lines). [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/Vote.java [exec] Hunk #1 FAILED at 125. [exec] 1 out of 1 hunk FAILED -- saving rejects to file src/java/main/org/apache/zookeeper/server/quorum/Vote.java.rej [exec] patching file src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12614222/ZOOKEEPER-1817.patch [exec] against trunk revision 1542355. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1775//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 431684cae357e277ec5bbdb25a72041188e1b88c logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 1 minute 25 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1817 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824620#comment-13824620 ] Raul Gutierrez Segales commented on ZOOKEEPER-1810: --- Doesn't look like https://reviews.apache.org/r/15568/ was updated? Or should we continue the review (and give the +1s) here? Add version to FLE notifications for trunk -- Key: ZOOKEEPER-1810 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 Project: ZooKeeper Issue Type: Sub-task Affects Versions: 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.5.0 Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824622#comment-13824622 ] Raul Gutierrez Segales commented on ZOOKEEPER-1817: --- With the mix of inline and reviewboard reviews I am not sure where we should review this one :) Is there a reviewboard for this one as well or just inline? If there is mind adding the link here for posterity - thanks [~fpj]. Fix don't care for b3.4 --- Key: ZOOKEEPER-1817 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824625#comment-13824625 ] Raul Gutierrez Segales commented on ZOOKEEPER-1817: --- Ah - the rb is https://reviews.apache.org/r/15625/. Though it's having issues - maybe try reloading? I guess reviewboard applies against the git mirrors and there was a lag in Apache's git-svn sync yesterday (i think). Fix don't care for b3.4 --- Key: ZOOKEEPER-1817 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824632#comment-13824632
]
Raul Gutierrez Segales commented on ZOOKEEPER-1653:
---
I take back the last comment, I carelessly overlooked the inheriting class.
zookeeper fails to start because of inconsistent epoch
--
Key: ZOOKEEPER-1653
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
Project: ZooKeeper
Issue Type: Bug
Components: quorum
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Fix For: 3.4.6
Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.3.4.patch,
ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
It looks like QuorumPeer.loadDataBase() could fail if the server was
restarted after zk.takeSnapshot() but before finishing
self.setCurrentEpoch(newEpoch) in Learner.java.
{code:java}
case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
zk.takeSnapshot();
self.setCurrentEpoch(newEpoch); // got restarted here
snapshotTaken = true;
writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
true);
break;
{code}
The server fails to start because currentEpoch is still 1 but the last
processed zkid from the snapshot has been updated.
{noformat}
2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
disk
java.io.IOException: The current epoch, 1, is older than the last zxid,
8589934592
at
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
at
org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
...
{noformat}
{noformat}
$ find datadir
datadir
datadir/version-2
datadir/version-2/currentEpoch.tmp
datadir/version-2/acceptedEpoch
datadir/version-2/snapshot.0
datadir/version-2/currentEpoch
datadir/version-2/snapshot.2
$ cat datadir/version-2/currentEpoch.tmp
2%
$ cat datadir/version-2/acceptedEpoch
2%
$ cat datadir/version-2/currentEpoch
1%
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824630#comment-13824630
]
Raul Gutierrez Segales commented on ZOOKEEPER-1653:
---
Nit in:
{noformat}
+static void writeLongToFile(File file, long value) throws IOException {
+AtomicFileOutputStream out = new AtomicFileOutputStream(file);
+BufferedWriter bw = new BufferedWriter(new OutputStreamWriter(out));
+boolean aborted = false;
+try {
+bw.write(Long.toString(value));
+bw.flush();
+out.flush();
+out.close();
+} catch (IOException e) {
+LOG.error(Failed to write new file + file, e);
+out.abort();
+throw e;
+}
+}
{noformat}
aborted is not used.
Nit in:
{noformat}
+LOG.info(Validating current epoch: + servers.mt[i].dataDir);
{noformat}
use {} instead of concatenating.
Nit:
{noformat}
+// Shut down the cluster
{noformat}
should be Shutdown the cluster.
In src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java:
{noformat}
+CountDownLatch mainFailed;
{noformat}
is assigned and modified but never asserted or checked?
zookeeper fails to start because of inconsistent epoch
--
Key: ZOOKEEPER-1653
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
Project: ZooKeeper
Issue Type: Bug
Components: quorum
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Fix For: 3.4.6
Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.3.4.patch,
ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
It looks like QuorumPeer.loadDataBase() could fail if the server was
restarted after zk.takeSnapshot() but before finishing
self.setCurrentEpoch(newEpoch) in Learner.java.
{code:java}
case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
zk.takeSnapshot();
self.setCurrentEpoch(newEpoch); // got restarted here
snapshotTaken = true;
writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
true);
break;
{code}
The server fails to start because currentEpoch is still 1 but the last
processed zkid from the snapshot has been updated.
{noformat}
2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
disk
java.io.IOException: The current epoch, 1, is older than the last zxid,
8589934592
at
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
at
org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
...
{noformat}
{noformat}
$ find datadir
datadir
datadir/version-2
datadir/version-2/currentEpoch.tmp
datadir/version-2/acceptedEpoch
datadir/version-2/snapshot.0
datadir/version-2/currentEpoch
datadir/version-2/snapshot.2
$ cat datadir/version-2/currentEpoch.tmp
2%
$ cat datadir/version-2/acceptedEpoch
2%
$ cat datadir/version-2/currentEpoch
1%
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824634#comment-13824634
]
Raul Gutierrez Segales commented on ZOOKEEPER-1653:
---
One more nit in
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java:
{noformat}
+currentEpochFile = new File(new File(follower.dataDir, version-2),
+currentEpoch);
+File updatingEpochFile = new File(
+new File(follower.dataDir, version-2),
+QuorumPeer.UPDATING_EPOCH_FILENAME);
{noformat}
could be abbreviated with:
{noformat}
+File followerDataDir = new File(follower.dataDir, version-2);
+currentEpochFile = new File(followerDataDir, currentEpoch);
+File updatingEpochFile = new File(followerDataDir,
QuorumPeer.UPDATING_EPOCH_FILENAME);
{noformat}
Also - should there be a constant for currentEpoch too?
zookeeper fails to start because of inconsistent epoch
--
Key: ZOOKEEPER-1653
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
Project: ZooKeeper
Issue Type: Bug
Components: quorum
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Fix For: 3.4.6
Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.3.4.patch,
ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
It looks like QuorumPeer.loadDataBase() could fail if the server was
restarted after zk.takeSnapshot() but before finishing
self.setCurrentEpoch(newEpoch) in Learner.java.
{code:java}
case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
zk.takeSnapshot();
self.setCurrentEpoch(newEpoch); // got restarted here
snapshotTaken = true;
writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
true);
break;
{code}
The server fails to start because currentEpoch is still 1 but the last
processed zkid from the snapshot has been updated.
{noformat}
2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
disk
java.io.IOException: The current epoch, 1, is older than the last zxid,
8589934592
at
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
at
org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
...
{noformat}
{noformat}
$ find datadir
datadir
datadir/version-2
datadir/version-2/currentEpoch.tmp
datadir/version-2/acceptedEpoch
datadir/version-2/snapshot.0
datadir/version-2/currentEpoch
datadir/version-2/snapshot.2
$ cat datadir/version-2/currentEpoch.tmp
2%
$ cat datadir/version-2/acceptedEpoch
2%
$ cat datadir/version-2/currentEpoch
1%
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1573) Unable to load database due to missing parent node
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824644#comment-13824644
]
Raul Gutierrez Segales commented on ZOOKEEPER-1573:
---
Nit - maybe this:
{noformat}
+ * Snapshots are lazily created. So when the snapshot was in progress
+ * there is a chance that some of the later transactions can go into
+ * snapshot. While restoring same transactions NONODE/NODEEXISTS errors
+ * can come. Basically we can ignore all errors during the restore.
{noformat}
could be more clear like this:
{noformat}
+ * Snapshots are lazily created. So when a snapshot is in progress,
+ * there is a chance for later transactions to make to into the
snapshot.
+ * Then when the snapshot is restored, NONODE/NODEEXISTS errors
+ * could occur. It should be safe to ignore these.
{noformat}
Nit:
{noformat}
+LOG.warn(Intrrupted);
{noformat}
typo.
Nit:
{noformat}
+LOG.debug(Ignoring processTxn failure hdr: + hdr.getType() +
: error: + rc.err + path: + rc.path);
{noformat}
use string extrapolation with {} instead of string concatenation.
Nit:
{noformat}
+/**
+ * Test we can restore a snapshot that has delete txns ahead of the zxid
of the snapshot file. ZOOKEEPER-1573
+ */
{noformat}
make it:
{noformat}
+/**
+ * ZOOKEEPER-1573: test restoring a snapshot with deleted txns ahead of
the snapshot file's zxid.
+ */
{noformat}
Nit:
{noformat}
+LOG.info(Set lastProcessedZxid to +
zks.getZKDatabase().getDataTreeLastProcessedZxid());
{noformat}
ditto wrt to string extrapolation via {}.
Unable to load database due to missing parent node
--
Key: ZOOKEEPER-1573
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1573
Project: ZooKeeper
Issue Type: Bug
Components: server
Affects Versions: 3.4.3, 3.5.0
Reporter: Thawan Kooburat
Attachments: ZOOKEEPER-1573.patch
While replaying txnlog on data tree, the server has a code to detect missing
parent node. This code block was last modified as part of ZOOKEEPER-1333. In
our production, we found a case where this check is return false positive.
The sequence of txns is as follows:
zxid 1: create /prefix/a
zxid 2: create /prefix/a/b
zxid 3: delete /prefix/a/b
zxid 4: delete /prefix/a
The server start capturing snapshot at zxid 1. However, by the time it
traversing the data tree down to /prefix, txn 4 is already applied and
/prefix have no children.
When the server restore from snapshot, it process txnlog starting from zxid
2. This txn generate missing parent error and the server refuse to start up.
The same check allow me to discover bug in ZOOKEEPER-1551, but I don't know
if we have any option beside removing this check to solve this issue.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
ZooKeeper_branch33_solaris - Build # 709 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch33_solaris/709/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 90185 lines...] [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-17 06:55:47,950 - INFO [main:ClientBase@408] - STOPPING server [junit] 2013-11-17 06:55:47,953 - INFO [SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited! [junit] 2013-11-17 06:55:47,953 - INFO [ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop! [junit] 2013-11-17 06:55:47,953 - INFO [main:FinalRequestProcessor@370] - shutdown of request processor complete [junit] 2013-11-17 06:55:47,955 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] ensureOnly:[] [junit] 2013-11-17 06:55:47,956 - INFO [main:ClientBase@401] - STARTING server [junit] 2013-11-17 06:55:47,957 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test5982346275289136619.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test5982346275289136619.junit.dir/version-2 [junit] 2013-11-17 06:55:47,958 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-17 06:55:47,959 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test5982346275289136619.junit.dir/version-2/snapshot.b [junit] 2013-11-17 06:55:47,962 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2013-11-17 06:55:47,964 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-17 06:55:47,965 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:50032 [junit] 2013-11-17 06:55:47,966 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:50032 [junit] 2013-11-17 06:55:47,966 - INFO [Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2013-11-17 06:55:47,968 - INFO [Thread-5:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:50032 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-17 06:55:47,970 - INFO [main:ClientBase@431] - tearDown starting [junit] 2013-11-17 06:55:47,970 - INFO [main:ClientBase@443] - fdcount after test is: 41 [junit] 2013-11-17 06:55:48,009 - INFO [SessionTracker:SessionTrackerImpl@161] - SessionTrackerImpl exited loop! [junit] 2013-11-17 06:55:48,009 - INFO [SessionTracker:SessionTrackerImpl@161] - SessionTrackerImpl exited loop! [junit] 2013-11-17 06:55:49,499 - INFO [main-SendThread(localhost:11221):ClientCnxn$SendThread@1058] - Opening socket connection to server localhost/127.0.0.1:11221 [junit] 2013-11-17 06:55:49,500 - INFO [main-SendThread(localhost:11221):ClientCnxn$SendThread@947] - Socket connection established to localhost/127.0.0.1:11221, initiating session [junit] 2013-11-17 06:55:49,500 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:50034 [junit] 2013-11-17 06:55:49,501 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@770] - Client attempting to renew session 0x14264d801c3 at /127.0.0.1:50034 [junit] 2013-11-17 06:55:49,502 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1580] - Established session 0x14264d801c3 with negotiated timeout 3 for client /127.0.0.1:50034 [junit] 2013-11-17 06:55:49,502 - INFO [main-SendThread(localhost:11221):ClientCnxn$SendThread@736] - Session establishment complete on server localhost/127.0.0.1:11221, sessionid = 0x14264d801c3, negotiated timeout = 3 [junit] 2013-11-17 06:55:49,502 - INFO [ProcessThread:-1:PrepRequestProcessor@399] - Processed session termination for sessionid: 0x14264d801c3 [junit] 2013-11-17 06:55:49,503 - INFO [SyncThread:0:FileTxnLog@199]
Jenkins build is back to normal : bookkeeper-trunk #441
See https://builds.apache.org/job/bookkeeper-trunk/441/
