ZooKeeper-trunk-solaris - Build # 933 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/933/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by timer
Building remotely on solaris1 (Solaris) in workspace
/export/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris
Updating http://svn.apache.org/repos/asf/zookeeper/trunk at revision
'2015-02-06T08:30:30.828 +'
U CHANGES.txt
U src/java/main/org/apache/zookeeper/ClientCnxn.java
U src/java/main/org/apache/zookeeper/Shell.java
U src/java/main/org/apache/zookeeper/ZKUtil.java
U src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
U src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
U src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
U src/java/main/org/apache/zookeeper/server/ServerStats.java
U src/java/main/org/apache/zookeeper/server/ConnectionBean.java
U src/java/main/org/apache/zookeeper/server/Request.java
U src/java/main/org/apache/zookeeper/server/WorkerService.java
U src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
U
src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
U src/java/main/org/apache/zookeeper/server/quorum/Follower.java
U
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
U
src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java
U src/java/main/org/apache/zookeeper/server/quorum/Leader.java
U src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
U src/java/main/org/apache/zookeeper/server/ZKDatabase.java
U src/java/main/org/apache/zookeeper/server/ExpiryQueue.java
U src/java/main/org/apache/zookeeper/server/RateLogger.java
U src/java/main/org/apache/zookeeper/Login.java
A src/java/main/org/apache/zookeeper/common/Time.java
U src/java/main/org/apache/zookeeper/ClientCnxnSocket.java
U src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java
U src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java
U src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java
U
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
U src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
U src/java/test/org/apache/zookeeper/test/ClientHammerTest.java
U src/java/test/org/apache/zookeeper/test/TestHammer.java
U src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
U src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java
U src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java
U src/java/test/org/apache/zookeeper/test/ClientBase.java
U src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java
A src/java/test/org/apache/zookeeper/common/TimeTest.java
At revision 1657753
Updating http://svn.apache.org/repos/asf/hadoop/nightly at revision
'2015-02-06T08:30:30.828 +'
At revision 1657753
no change for http://svn.apache.org/repos/asf/hadoop/nightly since the previous
build
No emails were triggered.
[locks-and-latches] Checking to see if we really have the locks
[locks-and-latches] Have all the locks, build can start
[ZooKeeper-trunk-solaris] $ /bin/bash /var/tmp/hudson1613248724049467386.sh
[trunk] $
/export/home/hudson/hudson-slave/tools/hudson.tasks.Ant_AntInstallation/ant-1.8.2/bin/ant
"-DBUILD_ARGS=-Dfindbugs.home=${FINDBUGS_HOME} -Dforrest.home=${FORREST_HOME}
-Djava5.home=${JAVA5_HOME}" -DBUILD_TARGETS=hudson-test-trunk
-DANALYSIS_TARGETS=test "-DBUILD_FLAGS=-Dtest.junit.output.format=xml
-Dtest.output=yes " -Dtest.output=yes -Dtest.junit.output.format=xml clean
test-core-java
Error: JAVA_HOME is not defined correctly.
We cannot execute /home/jenkins/tools/java/latest1.7/bin/java
Build step 'Invoke Ant' marked build as failure
[locks-and-latches] Releasing all the locks
[locks-and-latches] All the locks released
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure
###
## FAILED TESTS (if any)
##
No tests ran.
[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308985#comment-14308985 ] Hudson commented on ZOOKEEPER-1366: --- FAILURE: Integrated in ZooKeeper-trunk #2587 (See [https://builds.apache.org/job/ZooKeeper-trunk/2587/]) ZOOKEEPER-1366 Zookeeper should be tolerant of clock adjustments (Hongchao Deng via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1657745) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxnSocket.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/Login.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/Shell.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZKUtil.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/common/Time.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ConnectionBean.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ExpiryQueue.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/RateLogger.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerStats.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/WorkerService.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZKDatabase.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Follower.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java * /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java * /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java * /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/common/TimeTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientBase.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientHammerTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/TestHammer.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java > Zookeeper should be tolerant of clock adjustments > - > > Key: ZOOKEEPER-1366 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366 > Project: ZooKeeper > Issue Type: Bug >Reporter: Ted Dunning >Assignee: Hongchao Deng >Priority: Critical > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, > ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, > ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, > ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, > ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, > ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, > zookeeper-3.4.5-ZK1366-SC01.patch > > > If you want to wreak havoc on a ZK based system just do [date -s "+1hour"] > and watch the mayhem as all sessions expire at once. > This shouldn't happen. Zookeeper could easily know handle elapsed times as > elapsed times rather than as differences between absolute times. The > absolute times are subject to adjustment when the clock is set while a timer > is not subject to this problem. In Java, System.currentTimeMillis() gives > you absolute time while System.nanoTime() gives you time based on a timer > from an arbitrary epoch. > I have done this and have been running tests now for some tens of minutes > with
ZooKeeper-trunk - Build # 2587 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk/2587/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 352162 lines...] [junit] 2015-02-06 11:15:14,321 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2015-02-06 11:15:14,322 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:60265 [junit] 2015-02-06 11:15:14,323 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from /127.0.0.1:60265 [junit] 2015-02-06 11:15:14,323 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output [junit] 2015-02-06 11:15:14,324 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:60265 (no session established for client) [junit] 2015-02-06 11:15:14,324 [myid:] - INFO [main:JMXEnv@224] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2015-02-06 11:15:14,326 [myid:] - INFO [main:JMXEnv@241] - expect:InMemoryDataTree [junit] 2015-02-06 11:15:14,326 [myid:] - INFO [main:JMXEnv@245] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2015-02-06 11:15:14,326 [myid:] - INFO [main:JMXEnv@241] - expect:StandaloneServer_port [junit] 2015-02-06 11:15:14,327 [myid:] - INFO [main:JMXEnv@245] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2015-02-06 11:15:14,327 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 85029 [junit] 2015-02-06 11:15:14,327 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 24 [junit] 2015-02-06 11:15:14,328 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2015-02-06 11:15:14,328 [myid:] - INFO [main:ClientBase@521] - tearDown starting [junit] 2015-02-06 11:15:14,387 [myid:] - INFO [main:ZooKeeper@968] - Session: 0x10286f00106 closed [junit] 2015-02-06 11:15:14,387 [myid:] - INFO [main:ClientBase@491] - STOPPING server [junit] 2015-02-06 11:15:14,387 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@531] - EventThread shut down [junit] 2015-02-06 11:15:14,387 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2015-02-06 11:15:14,387 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2015-02-06 11:15:14,387 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2015-02-06 11:15:14,388 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2015-02-06 11:15:14,388 [myid:] - INFO [main:ZooKeeperServer@440] - shutting down [junit] 2015-02-06 11:15:14,389 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2015-02-06 11:15:14,389 [myid:] - INFO [main:PrepRequestProcessor@974] - Shutting down [junit] 2015-02-06 11:15:14,389 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2015-02-06 11:15:14,389 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop! [junit] 2015-02-06 11:15:14,390 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2015-02-06 11:15:14,390 [myid:] - INFO [main:FinalRequestProcessor@477] - shutdown of request processor complete [junit] 2015-02-06 11:15:14,390 [myid:] - INFO [main:MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree] [junit] 2015-02-06 11:15:14,391 [myid:] - INFO [main:MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11221] [junit] 2015-02-06 11:15:14,391 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2015-02-06 11:15:14,392 [myid:] - INFO [main:JMXEnv@142] - ensureOnly:[] [junit] 2015-02-06 11:15:14,396 [myid:] - INFO [main:ClientBase@546] - fdcount after test is: 46 at start it was 34 [junit] 2015-02-06 11:15:14,396 [myid:] - INFO [main:ClientBase@548] - sleeping for 20 secs [junit] 2015-02-06 11:15:14,398 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testQuota [junit] 2015-02-06 11:15:14,398 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testQuota [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, T
ZooKeeper-trunk-jdk8 - Build # 285 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/285/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 351404 lines...] [junit] 2015-02-06 11:36:34,029 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2015-02-06 11:36:34,029 [myid:] - INFO [main:JMXEnv@142] - ensureOnly:[] [junit] 2015-02-06 11:36:34,031 [myid:] - INFO [main:ClientBase@444] - STARTING server [junit] 2015-02-06 11:36:34,031 [myid:] - INFO [main:ClientBase@365] - CREATING server instance 127.0.0.1:11221 [junit] 2015-02-06 11:36:34,031 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 32 worker threads, and 64 kB direct buffers. [junit] 2015-02-06 11:36:34,032 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2015-02-06 11:36:34,032 [myid:] - INFO [main:ClientBase@340] - STARTING server instance 127.0.0.1:11221 [junit] 2015-02-06 11:36:34,032 [myid:] - INFO [main:ZooKeeperServer@778] - minSessionTimeout set to 6000 [junit] 2015-02-06 11:36:34,032 [myid:] - INFO [main:ZooKeeperServer@787] - maxSessionTimeout set to 6 [junit] 2015-02-06 11:36:34,033 [myid:] - INFO [main:ZooKeeperServer@153] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk8/trunk/build/test/tmp/test7439725881303335698.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk8/trunk/build/test/tmp/test7439725881303335698.junit.dir/version-2 [junit] 2015-02-06 11:36:34,034 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk8/trunk/build/test/tmp/test7439725881303335698.junit.dir/version-2/snapshot.b [junit] 2015-02-06 11:36:34,036 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk8/trunk/build/test/tmp/test7439725881303335698.junit.dir/version-2/snapshot.b [junit] 2015-02-06 11:36:34,038 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2015-02-06 11:36:34,039 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:35609 [junit] 2015-02-06 11:36:34,040 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from /127.0.0.1:35609 [junit] 2015-02-06 11:36:34,040 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output [junit] 2015-02-06 11:36:34,040 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:35609 (no session established for client) [junit] 2015-02-06 11:36:34,040 [myid:] - INFO [main:JMXEnv@224] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2015-02-06 11:36:34,042 [myid:] - INFO [main:JMXEnv@241] - expect:InMemoryDataTree [junit] 2015-02-06 11:36:34,042 [myid:] - INFO [main:JMXEnv@245] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2015-02-06 11:36:34,043 [myid:] - INFO [main:JMXEnv@241] - expect:StandaloneServer_port [junit] 2015-02-06 11:36:34,043 [myid:] - INFO [main:JMXEnv@245] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2015-02-06 11:36:34,043 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 62024 [junit] 2015-02-06 11:36:34,043 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 24 [junit] 2015-02-06 11:36:34,044 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2015-02-06 11:36:34,044 [myid:] - INFO [main:ClientBase@521] - tearDown starting [junit] 2015-02-06 11:36:34,105 [myid:] - INFO [main:ZooKeeper@968] - Session: 0x1028708eabd closed [junit] 2015-02-06 11:36:34,106 [myid:] - INFO [main:ClientBase@491] - STOPPING server [junit] 2015-02-06 11:36:34,105 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@531] - EventThread shut down [junit] 2015-02-06 11:36:34,106 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2015-02-06 11:36:34,106 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2015-02-06 11:36:34,106 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpir
[jira] [Commented] (ZOOKEEPER-1952) Default log directory and file name can be changed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309118#comment-14309118 ] Hari Krishna Dara commented on ZOOKEEPER-1952: -- I got the patch to apply against current trunk and made the below further changes: - Renamed ZOOKEEPER_LOGFILE to ZOO_LOG_FILE to be consistent with the rest - There was a typo in the original patch where ZOOKEEPR_LOGFILE was used in 3 different places, I changed these also to ZOO_LOG_FILE. - I reverted the change to log4j.properties. The current defaults are actually consistent with the other related projects such as hadoop and hbase. I can submit the new patch after some more testing, is that fine? > Default log directory and file name can be changed > -- > > Key: ZOOKEEPER-1952 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1952 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.6 >Reporter: nijel >Assignee: nijel >Priority: Minor > Fix For: 3.5.1 > > Attachments: ZOOKEEPER-1952-1.patch > > > The log folder and log file name is configurable now. > The default log folder is "." in distribution. So the log file > (zookeeper.out) will be placed in bin folder > Can this be changed to /logs/zookeeperserver-.log ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Time for a 3.5.1-alpha release?
Sounds reasonable. Let's try to get these in, but depending on how much progress we make we might need to cut off at some point an push a release. They can always catch the next train. I'll try to update the jira list over the weekend, clean them up and see where we are. Patrick On Thu, Feb 5, 2015 at 9:39 PM, Michi Mutsuzaki wrote: > I'd like to get ZOOKEEPER-1506 in. > > On Thu, Feb 5, 2015 at 1:25 PM, Flavio Junqueira > wrote: >> I'd like to see the SSL work in for the next release. >> >> -Flavio >> >>> On 05 Feb 2015, at 19:34, Raúl Gutiérrez Segalés >>> wrote: >>> >>> +1 >>> >>> It would be nice, but they are not blockers, to get these in: >>> >>> https://issues.apache.org/jira/browse/ZOOKEEPER-1998 >>> https://issues.apache.org/jira/browse/ZOOKEEPER-2051 >>> https://issues.apache.org/jira/browse/ZOOKEEPER-2098 >>> >>> thanks Patrick! >>> >>> >>> -rgs >>> >>> >>> On 5 February 2015 at 11:22, Michi Mutsuzaki wrote: >>> +1 I can check in ZOOKEEPER-1366 tonight. On Thu, Feb 5, 2015 at 10:57 AM, Rakesh Radhakrishnan wrote: > +1 for 3.5.1-alpha release > > I think its good to include the following jira issues: > >ZOOKEEPER-1366 (so far we got two +1) >ZOOKEEPER-1907 (its not blocking, good to have imprv) > > Best Regards, > Rakesh > > On Thu, Feb 5, 2015 at 11:27 PM, Patrick Hunt wrote: > >> Hi folks. 3.5.0-alpha has been out for a bit now, we've gotten some >> good feedback and a number of jira issues have been resolved. What do >> you think about putting out an updated 3.5.1-alpha release with the >> latest changes? Anything blocking us or that you feel important to >> include? >> >> Regards, >> >> Patrick >> >>
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309511#comment-14309511 ] Hongchao Deng commented on ZOOKEEPER-2094: -- Hi [~iandi]. I am concerned about the error handling in X509Auth. It simply returns null and do some logging of exceptions. This would cause massive exceptions in logging at the end. It should stop running when some properties (keystore, trustore, etc.) isn't set right. Any idea on this? > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309571#comment-14309571 ] Hongchao Deng commented on ZOOKEEPER-2094: -- And I also realized in Netty server, if SSL properties isn't set correctly, it would simply fall back to normal only without SSL. The same problem, maybe we should throw some exception and stop the server? > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309607#comment-14309607 ] Ian Dimayuga commented on ZOOKEEPER-2094: - [~hdeng] Agreed, I can make it less forgiving if secure is enabled. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309646#comment-14309646 ] Ian Dimayuga commented on ZOOKEEPER-2094: - [~hdeng] However, regarding the null trustManager or null keyManager in X509Auth, these are actually legal states in some use cases. If the server-side SSLContext is initialized with a null trustManager then that is because the server does not choose to verify the client. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309658#comment-14309658 ] Hongchao Deng commented on ZOOKEEPER-2094: -- I mean the null SSL context. I didn't have any opinion yet. So I am writing documentation for possible behavior. Here's what I thought: 1. Client A null SSL context will cause a null pointer exception 2. Server It will automatically fall back to non-SSL pipeline. I am wondering if you have better idea to handle this such as stopping the client/server from running. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309766#comment-14309766 ] Ian Dimayuga commented on ZOOKEEPER-2094: - [~hdeng] Currently I have changed it so the server throws an exception in the failure cases, instead of just omitting the SslHandler from the pipeline. I can change the client so that it will just exit with useful output/logging if the right parameters are missing. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309771#comment-14309771 ] Hongchao Deng commented on ZOOKEEPER-2094: -- Cool. Upload them when you are done so I can merge it. I am working on a few refactoring, documentation now. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 30576: ZOOKEEPER-2094: SSL on Netty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30576/ --- (Updated Feb. 6, 2015, 8:16 p.m.) Review request for zookeeper. Repository: zookeeper-git Description --- SSL on Netty Diffs (updated) - build.xml e4c8e0374b25a5bcab7cfe77543378fdb8f98b06 src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 914a24471b0a27f7cf650c3ed2eef1077178853f src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e5a856aefba6f5c106d3f4861d3de8f1e1 src/docs/src/documentation/content/xdocs/zookeeperStarted.xml b24b17ad5254321affcaef7b7ecb3a73fc266f84 src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java 87e7834bc91c52d4a2d100dbcc98d41a1b98b849 src/java/main/org/apache/zookeeper/ZooKeeper.java dd13cc9ba5096312b06999a03ae0057cd3677623 src/java/main/org/apache/zookeeper/ZooKeeperMain.java 496e88748cf6aa291c8b71583a28fdb55fdf7761 src/java/main/org/apache/zookeeper/auth/X509Auth.java PRE-CREATION src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java e41465ab93a3a59dbced8294e83b1651ad0dfe69 src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java e02753f4fb926a8cc6c7a7c10af42f949c1e210c src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java acabb33f6c7a000706763ccba94cbaf5aaaca08e src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java b4bdc82f8b52f736c6ee3d67bb793a3616c1b436 src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 09a794844978456fc3580adc22b6064e2a12cf77 src/java/main/org/apache/zookeeper/server/ServerCnxn.java a47d85662970cc0c219a46b226737a8689f8fe96 src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 14037722c569d560acef56de0b5a7ae13464128c src/java/main/org/apache/zookeeper/server/ServerConfig.java f2b8463e871739319bdf40be1f014d5ad0af5602 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887 src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java 0eb5c7f979199f2f7dcb9e5cfa011a9b20113713 src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java b756d349abeb1fc69534100c3633db4c1c18e031 src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java 406015f84a51e6afcfe704b881f8494bdd687a25 src/java/main/org/apache/zookeeper/server/auth/X509AuthenticationProvider.java PRE-CREATION src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda src/java/main/org/apache/zookeeper/server/quorum/Learner.java 87f4c0627141c2cfee0533aca7ba2e7ff91433e3 src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java badc8df1f05dea4be337bc8312d7ac22f6c77dc3 src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java d17c58d59e0131a78adde1becb5c23ce8c7a16a7 src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 2aab6d09f9bd980ed76f886fb8168aae2ac8f99f src/java/test/data/auth/test.cert PRE-CREATION src/java/test/data/auth/testKeyStore.jks PRE-CREATION src/java/test/data/auth/testTrustStore.jks PRE-CREATION src/java/test/data/auth/testUntrustedKeyStore.jks PRE-CREATION src/java/test/org/apache/zookeeper/server/TestServerCnxn.java PRE-CREATION src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 6ce058e48d17410d89d8348ee659dd7752bfd578 src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb src/java/test/org/apache/zookeeper/test/ReconfigTest.java 8b238ee7463508122010208ebc3e786caa2cf1b1 src/java/test/org/apache/zookeeper/test/SSLAuthTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30576/diff/ Testing --- Thanks, Hongchao Deng
[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2094: - Attachment: ZOOKEEPER-2094.patch > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, > testKeyStore.jks, testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309820#comment-14309820 ] Hongchao Deng commented on ZOOKEEPER-2094: -- Hi Ian. I do the following changes: 1. docs in cli tool 2. input stream close in X509Auth 3. rename: getSecureClientCnxns -> isCnxnsSecure 4. throw exception when ssl on server isn’t set up. 5. There is ordering requirement between cnxnFactory and secureCnxnFactory. It shouldn’t rely on “zks.running” 6. synchronized on “initialized in AuthenticationProvider class 7. unnecessary imports & Formatting Please take a look at the RB (there is a function to show difference to previous changes). I did a basic throw exception in server side handling null ssl context. I think it would cause NPE in client so I haven't done anything about it. Let's discuss more on handling user input. Other than that, everything looks good to me. I run multiple jenkins test and it goes well so far. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, > testKeyStore.jks, testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper-trunk-openjdk7 - Build # 714 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/714/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 348263 lines...] [junit] 2015-02-06 20:35:27,061 [myid:] - INFO [main:MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11221] [junit] 2015-02-06 20:35:27,062 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2015-02-06 20:35:27,062 [myid:] - INFO [main:JMXEnv@142] - ensureOnly:[] [junit] 2015-02-06 20:35:27,064 [myid:] - INFO [main:ClientBase@444] - STARTING server [junit] 2015-02-06 20:35:27,064 [myid:] - INFO [main:ClientBase@365] - CREATING server instance 127.0.0.1:11221 [junit] 2015-02-06 20:35:27,065 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 32 worker threads, and 64 kB direct buffers. [junit] 2015-02-06 20:35:27,065 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2015-02-06 20:35:27,065 [myid:] - INFO [main:ClientBase@340] - STARTING server instance 127.0.0.1:11221 [junit] 2015-02-06 20:35:27,066 [myid:] - INFO [main:ZooKeeperServer@778] - minSessionTimeout set to 6000 [junit] 2015-02-06 20:35:27,066 [myid:] - INFO [main:ZooKeeperServer@787] - maxSessionTimeout set to 6 [junit] 2015-02-06 20:35:27,066 [myid:] - INFO [main:ZooKeeperServer@153] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test6221947830026803086.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test6221947830026803086.junit.dir/version-2 [junit] 2015-02-06 20:35:27,067 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test6221947830026803086.junit.dir/version-2/snapshot.b [junit] 2015-02-06 20:35:27,070 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test6221947830026803086.junit.dir/version-2/snapshot.b [junit] 2015-02-06 20:35:27,072 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2015-02-06 20:35:27,072 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:53552 [junit] 2015-02-06 20:35:27,074 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from /127.0.0.1:53552 [junit] 2015-02-06 20:35:27,074 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output [junit] 2015-02-06 20:35:27,074 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:53552 (no session established for client) [junit] 2015-02-06 20:35:27,075 [myid:] - INFO [main:JMXEnv@224] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2015-02-06 20:35:27,077 [myid:] - INFO [main:JMXEnv@241] - expect:InMemoryDataTree [junit] 2015-02-06 20:35:27,077 [myid:] - INFO [main:JMXEnv@245] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2015-02-06 20:35:27,077 [myid:] - INFO [main:JMXEnv@241] - expect:StandaloneServer_port [junit] 2015-02-06 20:35:27,077 [myid:] - INFO [main:JMXEnv@245] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2015-02-06 20:35:27,077 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 85671 [junit] 2015-02-06 20:35:27,078 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 24 [junit] 2015-02-06 20:35:27,078 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2015-02-06 20:35:27,078 [myid:] - INFO [main:ClientBase@521] - tearDown starting [junit] 2015-02-06 20:35:27,138 [myid:] - INFO [main:ZooKeeper@968] - Session: 0x100a3af62ae closed [junit] 2015-02-06 20:35:27,138 [myid:] - INFO [main:ClientBase@491] - STOPPING server [junit] 2015-02-06 20:35:27,138 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2015-02-06 20:35:27,138 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@531] - EventThread shut down [junit] 2015-02-06 20:35:27,138 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219] - ac
[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2094: - Attachment: (was: ZOOKEEPER-2094.patch) > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309998#comment-14309998 ] Ian Dimayuga commented on ZOOKEEPER-2094: - [~hdeng] Thanks for the patch. I'm merging it with my changes and will upload soon. I think isCnxnsSecure should either be "isCnxnSecure" or "areCnxnsSecure". If you have no preference, I will change to the latter since from the server perspective there are multiple connections. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2094: - Attachment: ZOOKEEPER-2094.patch > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, > testKeyStore.jks, testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310003#comment-14310003 ] Hongchao Deng commented on ZOOKEEPER-2094: -- Sure. I think both names are good. Please merge with the latest patch because there is a mistake in startup() that I change.. It'd better to have you review that too. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, > testKeyStore.jks, testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Dimayuga updated ZOOKEEPER-2094: Attachment: ZOOKEEPER-2094.patch Clarify documentation around security configuration and logging around clientPort and secureClientPort configuration Fail quickly on both server and client when SSL is incorrectly or insufficiently configured Change isCnxnsSecure to areCnxnsSecure > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310128#comment-14310128 ] Hongchao Deng commented on ZOOKEEPER-2094: -- Applying the patch is so hard... I wonder if we could do "git diff --binary BEGIN END" here since we don't run Jenkins here.. "git apply" will do the trick adding those binaries. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310137#comment-14310137 ] Ian Dimayuga commented on ZOOKEEPER-2094: - [~hdeng] Is there something I can do differently when generating the patch to help you? > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310143#comment-14310143 ] Hongchao Deng commented on ZOOKEEPER-2094: -- What about generating patch using "git diff --binary BEGIN END" and applying patch using "git apply" When it's good to commit, we need to generate svn patch and I think some committer needs to include those *.jks binaries in. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Dimayuga updated ZOOKEEPER-2094: Attachment: ZOOKEEPER-2094.patch Generate patch using git diff --binary > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310189#comment-14310189 ] Hongchao Deng commented on ZOOKEEPER-2094: -- Still failed.. What git command you use to generate the patch? I tried locally with "git diff --binary BEGIN END" and it's smooth with just "git apply". > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310195#comment-14310195 ] Ian Dimayuga commented on ZOOKEEPER-2094: - git diff --no-prefix --binary trunk -- I then replace all \r\n with \n because Windows. I can try it without --no-prefix and see if that's the issue. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310204#comment-14310204 ] Hongchao Deng commented on ZOOKEEPER-2094: -- You can't simply replace \r\n in patch -.-||| Unlike patch command, git will check revision ... Just give me the patch after "git diff", I will fix the \r\n problem. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, > testKeyStore.jks, testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Dimayuga updated ZOOKEEPER-2094: Attachment: ZOOKEEPER-2094.patch Try to upload a git patch without --no-prefix. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, > testKeyStore.jks, testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310209#comment-14310209 ] Ian Dimayuga commented on ZOOKEEPER-2094: - I see, that doesn't work with binary. Okay, I will upload raw. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, > testKeyStore.jks, testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Dimayuga updated ZOOKEEPER-2094: Attachment: ZOOKEEPER-2094.patch Upload just the raw git diff --binary > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310219#comment-14310219 ] Hongchao Deng commented on ZOOKEEPER-2094: -- The patch you uploaded is a mess... https://issues.apache.org/jira/secure/attachment/12697178/ZOOKEEPER-2094.patch Alright.. I have one last idea.. Do you have public github that I can pull from? > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310222#comment-14310222 ] Hongchao Deng commented on ZOOKEEPER-2094: -- Or you can open a Linux VM and then do git diff inside. I believe ZK gitattributes eliminates \r\n by default. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310239#comment-14310239 ] Ian Dimayuga commented on ZOOKEEPER-2094: - [~hdeng] Okay I've pushed to GitHub: https://github.com/iandimayuga/zookeeper/tree/iandi-netty-trunk > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310314#comment-14310314 ] Hongchao Deng commented on ZOOKEEPER-2094: -- Cool. Have done a merge and reviewed completely. Great work [~iandi]. I only changed some comments in Netty Client. No code change. I messed up my git so open another RB: https://reviews.apache.org/r/30753/diff/# [~iandi], Please do another review. Thanks! [~fpj], Can you take a review at the RB? I think Ian and I are reaching the final consensus. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310317#comment-14310317 ] Hongchao Deng commented on ZOOKEEPER-2094: -- And since we didn't have hadoop-QA to test it, I will reach some people to test it regarding unit test and deployment load test. Hope you can help in testing as well. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310362#comment-14310362 ] Hongchao Deng commented on ZOOKEEPER-2094: -- Also [~rakeshr] [~rgs]. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: https://reviews.apache.org/r/30576/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2094: - Description: Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider to perform authentication. Review board: https://reviews.apache.org/r/30753/diff/# was: Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider to perform authentication. Review board: https://reviews.apache.org/r/30576/diff/# > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, > testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: > https://reviews.apache.org/r/30753/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2094: - Attachment: ZOOKEEPER-2094-git-apply.patch Uploading a patch for people to try and test it. Apply the patch by doing "git apply" is enough. > SSL feature on Netty > > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Ian Dimayuga >Assignee: Ian Dimayuga > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2094-git-apply.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, > testTrustStore.jks, testUntrustedKeyStore.jks > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. > Review board: > https://reviews.apache.org/r/30753/diff/# -- This message was sent by Atlassian JIRA (v6.3.4#6332)
